From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39505C05027 for ; Fri, 3 Feb 2023 18:21:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8E50C85FB2; Fri, 3 Feb 2023 19:20:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="d7uPG4TX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8690385F9F; Fri, 3 Feb 2023 19:20:33 +0100 (CET) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5F4A685FB2 for ; Fri, 3 Feb 2023 19:20:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82e.google.com with SMTP id h24so6515158qtr.0 for ; Fri, 03 Feb 2023 10:20:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eThwDhFmJD66pIV9OEFhnXF25aprue8UryKeBGi8xB4=; b=d7uPG4TXdyxFwd2F1nHGP37hhjX7lvc/BLoBMhvyGMXWyP0dcIBUcOjrfT7NkidvoB MrytAWOXbCYfhys7enOMe32ydR2/NLxKp1MGL3Z0iV/7P2HftJJoqBmjuE5PDKaH4GsV rihYPrJu/vCpRGYDoxiqyTMk6LquVPd9xoARE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eThwDhFmJD66pIV9OEFhnXF25aprue8UryKeBGi8xB4=; b=ziW9wPFWNslwmMfkJ9nJup5PJu7AFRjcL98xp+h4DexZLTkYc5OZtlFSIblufNdcMf pDKqWEr+PN1W6IQjVGDdN2IjvwrkF7O/J8JOEx8CptjqcBgCD2ybbt7T/l7a8hFPZ9HN TD29mSxdJ7EcN6KSle/hbnN2V10571vHKmtXShETpYsLsWJkELH1rzTmAOiHIQeDbcCh UhntGSy5iDRhcSKd6m41/VD7wDe3q0VZtpey0K/y9pfWNKzvtPBBdSvFTuE0hCXCFSKB 38kFkw0ff2NauOTBJpLY+WONL8VEfLivJ8UvjtPOMHG9td8cvoYhBumm7r6YyhJbsiuB InEw== X-Gm-Message-State: AO0yUKXIQZwsewWeQIMUgRKO71dOjK+qfZowWmX5IqOEZMBSXRQ+2yw3 kEaCtzb+hu8zr5638TBe2X8SYg== X-Google-Smtp-Source: AK7set9n9PiRZR4m22YodUQeS2e87nVf2UcZMJclRxuZPQNlzzf51O3DJBHFsKxIfwnYbBA/7ejiOQ== X-Received: by 2002:ac8:7e93:0:b0:3b9:c0b4:8b00 with SMTP id w19-20020ac87e93000000b003b9c0b48b00mr15908365qtj.27.1675448427150; Fri, 03 Feb 2023 10:20:27 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-d049-1ce1-b939-5115.res6.spectrum.com. [2603:6081:7b00:6400:d049:1ce1:b939:5115]) by smtp.gmail.com with ESMTPSA id bi15-20020a05620a318f00b006e99290e83fsm2245177qkb.107.2023.02.03.10.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 10:20:26 -0800 (PST) Date: Fri, 3 Feb 2023 13:20:25 -0500 From: Tom Rini To: seanedmond@linux.microsoft.com Cc: u-boot@lists.denx.de, joe.hershberger@ni.com, rfried.dev@gmail.com, seanedmond@microsoft.com Subject: Re: [PATCH] net: tftp: Fix for DATA ACK for block count out of order Message-ID: References: <20230105021626.7032-1-seanedmond@linux.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qqWdbVzgU0MS4TMu" Content-Disposition: inline In-Reply-To: <20230105021626.7032-1-seanedmond@linux.microsoft.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --qqWdbVzgU0MS4TMu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 04, 2023 at 06:16:26PM -0800, seanedmond@linux.microsoft.com wr= ote: > From: Sean Edmond >=20 > In rfc7440, if an ACK is not received by the server or if the > last data block in a window is dropped, the server will timeout and > retransmit the window. In this case, the block count received will be > less than the internal block count. In this case, the client > should not ACK. ACK should only be sent if the received block > count is greater than the expected block count. >=20 > Signed-off-by: Sean Edmond > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! --=20 Tom --qqWdbVzgU0MS4TMu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPdUGgACgkQFHw5/5Y0 tyxbPQv/eq2HxbFu72UumcLgoh4/Kp7o2lUPdoKSz4Wd2YFDp1WCnWkTt8bhKUfV pVNixbfG7oRl3HVRPQjJHZG5kCCmMD+J3voi0afLInWHOv7jO1Nt4+a4fJ/ManCO TRjqi3bYKvmuqU1Zusl7heKkMj8S7T9zzffNNgXri6Wqmh1YkPivw72BLOvDR3Ca ADPbdC7+5d0qHsKwOCPJKEaNkquXj1y2hzwdNm8og5TdoKNSp3+ojRhmM017PVBB m/NGTipwX671f0gVdzZ7lVPX4LnUM89wlY7Usisb7hoRq70TmX97JKs+RMdA1D8L xqsYdqOPvYsz0CWGQsPqvoOaY8f2nobksCcs6tJwjGVsEe8CoqrL+3cPhAwR6jQu f1vaAIkG4Baq4I1IGOaIdYY8CpfDgexXlwqtfwazH3Bfo3TBhpZCQoqwGdPOZunw FvWIHod6p3MqWMkyEIOIw8OPlQOIRkbNk8+UBrg5vcx2V3jiq3IecuCKermmCY/3 Z4IKRMyS =VLyn -----END PGP SIGNATURE----- --qqWdbVzgU0MS4TMu--