Re: [PATCH v7] board: mntre: imx8mq: Add MNT Reform 2 board support

[Dominique Martinet <asmadeus@codewreck.org>]

Patrick Wildt wrote on Wed, Feb 01, 2023 at 12:57:47AM +0100:
> The MNT Reform 2 is a modular DIY laptop.  In its initial version it
> is based on the BoundaryDevices i.MX8MQ SoM.  Some parts have been
> lifted from BoundaryDevices official U-Boot downstream project.
> 
> Signed-off-by: Patrick Wildt <patrick@blueri.se>

Thanks for this patch!

(a bit late but I see checkpatch has a few things to say about this
(multiple blank lines, const position, SPDX comment position,
and 'if (IS_ENABLED) instead of #ifdef' to name a few)... But most if
not all of these come from the "source" evk files so it's probably best
to ignore and roll with it to keep differences minimal if a backport is
required)

I've reviewed the following:
arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi
arch/arm/mach-imx/imx8m/Kconfig
git diff --no-index board/freescale/imx8mq_evk/Kconfig board/mntre/imx8mq_reform2/Kconfig
git diff --no-index board/freescale/imx8mq_evk/MAINTAINERS board/mntre/imx8mq_reform2/MAINTAINERS
git diff --no-index board/freescale/imx8mq_evk/Makefile board/mntre/imx8mq_reform2/Makefile
git diff --no-index board/freescale/imx8mq_evk/imx8mq_evk.c board/mntre/imx8mq_reform2/imx8mq_reform2.c
git diff --no-index board/freescale/imx8mq_evk/spl.c board/mntre/imx8mq_reform2/spl.c
git diff --no-index configs/imx8mq_evk_defconfig configs/imx8mq_reform2_defconfig
git diff --no-index include/configs/imx8mq_evk.h include/configs/imx8mq_reform2.h
and board/mntre/imx8mq_reform2/lpddr4_timing* are autogenerated?

which covers everything, and it looks good to me:
Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>


Thanks!
-- 
Dominique Martinet