From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7ACE5C61DA4 for ; Sat, 4 Feb 2023 13:43:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9A04985CDA; Sat, 4 Feb 2023 14:43:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=codewreck.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=codewreck.org header.i=@codewreck.org header.b="kzfRNM04"; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b="x74T+jg9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E172F85FCD; Sat, 4 Feb 2023 11:50:45 +0100 (CET) Received: from nautica.notk.org (ipv6.notk.org [IPv6:2001:41d0:1:7a93::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4A23D85F88 for ; Sat, 4 Feb 2023 11:50:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=codewreck.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=asmadeus@codewreck.org Received: by nautica.notk.org (Postfix, from userid 108) id 409D0C009; Sat, 4 Feb 2023 11:51:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1675507864; bh=WcdLDIxmEsuuDUpr9/P+GaxxVAVMTd8tRuefLvYWLTg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kzfRNM04gSU4M7JmZUNdcCmMN1nfgy6QypTq1vpHEzinv25ri+PdlR0/HPQhtKM4L GH3kVzTowhdwKSFP0EkEs+sdLoMl6RdL5GxR9JZhTwn2xUKig+uZ3ImyWeqgYKlihD wDvb9NkBTsN3vQu+rdthi9SSvjvm8TJdeLDTzVIQIdNej7baoZggZDrGQQvn2BP54l y1Y44x6TDBDcVSzd0VbbLQbWIqKAui46oU39zmZOEjBnbdpdHo2thWumxtF0l0GAm/ eS7jMpplsVEgTOEM2Mw/yjZdlF6sNNXLMDOfv88MIKv6w8DpwbnEh7sDrVGqEhGG1j GW2xnq8zu/sZQ== Received: from odin.codewreck.org (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 84C0CC009; Sat, 4 Feb 2023 11:51:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1675507862; bh=WcdLDIxmEsuuDUpr9/P+GaxxVAVMTd8tRuefLvYWLTg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x74T+jg9QsYr0GLh06cjpGsIXbAC2GXv/m5lPVNGUCn4Mau0K4ltFUZ0gH62Ig2HW VKBvadEudXKvveVDigP5GXbU0DelTsPrD/FJNrYVbsslaUVN3QNlAC42iOlZxTHIkM 9THEFxkKewanH5gaDlGrnFYlNEuQSGS0Znhek9b4Pp946NlLml9dhDqrTiM+ODFHmW QfhGh6gwjSEZerxjkIaTgEQPZPbw2ZNwMA7SHGxURQ3B3fZ7X/4SIxTyBHEZTiCW4V Ljz79UzOx7jWUqy/T3l6ST//e+br4FOT6JEIrpypg4arDdd/O6HTwstot8s07Yj4Om Mbn1O8bK1VIuQ== Received: from localhost (odin.codewreck.org [local]) by odin.codewreck.org (OpenSMTPD) with ESMTPA id 6d47a86b; Sat, 4 Feb 2023 10:50:36 +0000 (UTC) Date: Sat, 4 Feb 2023 19:50:21 +0900 From: Dominique Martinet To: Patrick Wildt Cc: Stefano Babic , Fabio Estevam , u-boot@lists.denx.de, "Lukas F. Hartmann" Subject: Re: [PATCH v7] board: mntre: imx8mq: Add MNT Reform 2 board support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Sat, 04 Feb 2023 14:43:38 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Patrick Wildt wrote on Wed, Feb 01, 2023 at 12:57:47AM +0100: > The MNT Reform 2 is a modular DIY laptop. In its initial version it > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been > lifted from BoundaryDevices official U-Boot downstream project. > > Signed-off-by: Patrick Wildt Thanks for this patch! (a bit late but I see checkpatch has a few things to say about this (multiple blank lines, const position, SPDX comment position, and 'if (IS_ENABLED) instead of #ifdef' to name a few)... But most if not all of these come from the "source" evk files so it's probably best to ignore and roll with it to keep differences minimal if a backport is required) I've reviewed the following: arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi arch/arm/mach-imx/imx8m/Kconfig git diff --no-index board/freescale/imx8mq_evk/Kconfig board/mntre/imx8mq_reform2/Kconfig git diff --no-index board/freescale/imx8mq_evk/MAINTAINERS board/mntre/imx8mq_reform2/MAINTAINERS git diff --no-index board/freescale/imx8mq_evk/Makefile board/mntre/imx8mq_reform2/Makefile git diff --no-index board/freescale/imx8mq_evk/imx8mq_evk.c board/mntre/imx8mq_reform2/imx8mq_reform2.c git diff --no-index board/freescale/imx8mq_evk/spl.c board/mntre/imx8mq_reform2/spl.c git diff --no-index configs/imx8mq_evk_defconfig configs/imx8mq_reform2_defconfig git diff --no-index include/configs/imx8mq_evk.h include/configs/imx8mq_reform2.h and board/mntre/imx8mq_reform2/lpddr4_timing* are autogenerated? which covers everything, and it looks good to me: Reviewed-by: Dominique Martinet Thanks! -- Dominique Martinet