From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0B83C636CC for ; Sun, 5 Feb 2023 02:02:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75261857C4; Sun, 5 Feb 2023 03:02:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GiODNcet"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A2FAF85745; Sun, 5 Feb 2023 03:01:57 +0100 (CET) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9C427857C4 for ; Sun, 5 Feb 2023 03:01:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id m26so9572355qtp.9 for ; Sat, 04 Feb 2023 18:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NuZIRgqBk/n3Flw9bFFsUCR7WD+7bDVNwXY/quvxc1k=; b=GiODNcetm/GHc7OaW4TEqmCfODx4HBHWB5aRHkvK3PpehpyKKDRZhzChyCUVoh6f6k j0UzhuGKggHMEsuENxn2zC2Aq7td1ToCRYU+eUeePVHF3CRHmwskErHt1w+DtIIpQfQZ 0dGwQsLB384wo8HK6IrfVRWCT68cZyazRymwI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NuZIRgqBk/n3Flw9bFFsUCR7WD+7bDVNwXY/quvxc1k=; b=Bp5DR3AYPCHaN8FjQJoxIlFD+742p6ZEdIEPDRAqfrkG0IJdEg1pxPZXGWxcghAvhK VRGg9B/WBRXLyGAQzbC/7QLw3IMz2szij1LwnoBNx2xJTgigyIMJoschGOk5fnY5L282 BhDvxnp0e+gOZdFbNGzoUfNF+bCETF+RmnYx3IB/VrADUzXaz8ba20hb+rtRro5Awuc7 GqdxoZuy0x8lp+c98FMBop/nC/0EvLGeGXd/zyySJEkHnCRRn4ljXzK+4JS/uMZACPQa EWugseuISeWv46j4c+j0puIufgU68Fbd3ssOGlZWDA9la9kfpdF1A1urzQcSZIFMLCxq CQug== X-Gm-Message-State: AO0yUKW2hOqVkNwOLaE7smtKETk4KRM/YfiXKZebEr4S1YbtfPTeGoQE tBRbi5aBzb2fKLtJgoAtiyZRSQ== X-Google-Smtp-Source: AK7set+NwXT/6jfRGZnePvmMARUPWr9T3BVeGVmzLJkx+sreBWt08d0ZGH2Xs28uYZXB29pBCKxAkw== X-Received: by 2002:a05:622a:1741:b0:3ba:1ea6:d993 with SMTP id l1-20020a05622a174100b003ba1ea6d993mr1198399qtk.44.1675562513301; Sat, 04 Feb 2023 18:01:53 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-e262-5321-61d7-c2e4.res6.spectrum.com. [2603:6081:7b00:6400:e262:5321:61d7:c2e4]) by smtp.gmail.com with ESMTPSA id g19-20020ac84b73000000b003b8558eabd0sm4490057qts.23.2023.02.04.18.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Feb 2023 18:01:52 -0800 (PST) Date: Sat, 4 Feb 2023 21:01:51 -0500 From: Tom Rini To: Simon Glass Cc: Heinrich Schuchardt , Brandon Maier , Ilias Apalodimas , Kautuk Consul , Leo Yu-Chi Liang , Philippe Reynes , Rasmus Villemoes , Sughosh Ganu , U-Boot Mailing List Subject: Re: [PATCH 019/171] lib: Add a Kconfig for SPL_GENERATE_ACPI_TABLE Message-ID: References: <20230130144324.206208-1-sjg@chromium.org> <20230130144324.206208-20-sjg@chromium.org> <00b8e154-8de5-7956-5661-acfc749736e0@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MTrfFA5itlCuIY2F" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --MTrfFA5itlCuIY2F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 04, 2023 at 06:21:47PM -0700, Simon Glass wrote: > Hi Tom, Heinrich, >=20 > On Mon, 30 Jan 2023 at 07:52, Tom Rini wrote: > > > > On Mon, Jan 30, 2023 at 03:50:23PM +0100, Heinrich Schuchardt wrote: > > > On 1/30/23 15:40, Simon Glass wrote: > > > > This is implicitly used in the source and seems useful, so add it. > > > > > > Please, provide a clear description how this will be used. > > > > To follow up on what I just sent, Simon seems to be taking a pass at > > adding to Kconfig many / most of the options that aren't available today > > but are implied by the usage of CONFIG_IS_ENABLED(FOO). So, this is > > another case where IS_ENABLED(CONFIG_FOO) should be used. >=20 > This is needed for coral, which needs to know whether to include the > code to generate the ACPI tables or not. It needs to be omitted in > SPL, for code-size reasons. >=20 > If we use IS_ENABLED() then it will be built into SPL. OK, so then this needs to be part of the split config series as it relies on CONFIG_IS_ENABLED behavior that is changed by split config. --=20 Tom --MTrfFA5itlCuIY2F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPfDg4ACgkQFHw5/5Y0 tyxlTAv/RFEQLwf5zaBTnHPGbsJuWAyn94/0aJeEnBGyyvJGkRYHcryIvwkZim/i vdQ79U4dCh7XNtUM83qkp1ep11lsC5hicOIaj5vPwcOZfh47RhQVeNFhM7qNiutg V9vYkY80SKPShPELuh4y8xTvgw/dQnj9K1fwS/dXyTVJJpDI9toYQokCqg+2OD2s HGTIh5gjAUwGgxhVN7bXSzx9oFAwemSvOU6pgmeXXrCBucSPfavgk0dqFCczjlCU qX0YYpjq8xc2zWJrVJ4y93/Trq0bzW0t29xIaF+7BsqJh5a88aZq45fsfQTx4wHo J9VrS/t3VSU06dM+UX/s31TrovKNMaFOCFe/nJrA5K+81hxqOmS6UbpZxxco5VgD +Qh3oVj82F8/y4RfNZeovLa7Yb0/EUM+maV1+wYZAyi+PiInVnEj7Tom6bA2B/k0 Bty5gER9uYiMRj/ao/C1qm0O37MyEnsCo1fAjJlcF5bxb6A6ZTeZIlJ5TdBHzAbe 0K/XO9Rz =o5W8 -----END PGP SIGNATURE----- --MTrfFA5itlCuIY2F--