public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik@grimler.se>
To: u-boot@lists.denx.de
Subject: Re: [PATCH] odroid: add CROS_EC to odroid_defconfig
Date: Tue, 24 Jan 2023 19:38:54 +0100	[thread overview]
Message-ID: <Y9Alvn4bxfReTxH2@L14.lan> (raw)
In-Reply-To: <IYRZOR.AG747YAI39QV2@diskos.nl>

Hi Joost,

[ ... ]

> > That would be OK too, but if you do that, please use IS_ENABLED()
> > rather than #ifdef
> 
> I've tested the alternative, and that works for me as well. I am
> slightly in favour of the alternative, because it seems illogical to
> require building a driver that is never going to be used. On the other
> hand this patch only affects the Odroid U2, and the alternative every
> board using an Exnyos chip.
> 
> I'm still wondering why other boards, e.g. the Odroid XU3, are seemingly
> (I don't have any) unaffected by this.

Odroid-xu4 has the same issue, and the proposed solutions fixes the
issue there as well.  I also think the alternative `#if
IS_ENABLED(CONFIG_CROS_EC)`-solution would be better.

Thanks for reporting the issue!

Best regards,
Henrik Grimler

      reply	other threads:[~2023-01-24 19:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 23:16 [PATCH] odroid: add CROS_EC to odroid_defconfig Joost van Zwieten
2023-01-23  8:33 ` Peter Robinson
2023-01-23  9:39   ` Joost van Zwieten
2023-01-23 18:42     ` Simon Glass
2023-01-24 13:25       ` Joost van Zwieten
2023-01-24 18:38         ` Henrik Grimler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9Alvn4bxfReTxH2@L14.lan \
    --to=henrik@grimler.se \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox