From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E37CC25B50 for ; Tue, 24 Jan 2023 19:16:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 831288563B; Tue, 24 Jan 2023 20:16:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=grimler.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=grimler.se header.i=@grimler.se header.b="K91xNSUC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 587398563A; Tue, 24 Jan 2023 19:38:59 +0100 (CET) Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DA05E8565F for ; Tue, 24 Jan 2023 19:38:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=grimler.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=henrik@grimler.se Date: Tue, 24 Jan 2023 19:38:54 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grimler.se; s=key1; t=1674585536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=xSvlnnaVZtT7NJEUWW3lCKzwufXvQ5dr8zdj05r+tms=; b=K91xNSUCaqTZFp6Ss5M50pNYRqNxIotRWEhi0JeosHHIr7/4NEAQyGOyIVopbYw1rGYKE1 nwzp/St9z1ZvTeg1xLq/IKSVYVzlTESoLPAExgC4SQfpUclCgoOXOssSwkF0MdQqRPAePs sS8BX7/VLn85aDe61aCfWf+yFNgoO9Q= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Henrik Grimler To: u-boot@lists.denx.de Subject: Re: [PATCH] odroid: add CROS_EC to odroid_defconfig Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Mailman-Approved-At: Tue, 24 Jan 2023 20:16:25 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Joost, [ ... ] > > That would be OK too, but if you do that, please use IS_ENABLED() > > rather than #ifdef > > I've tested the alternative, and that works for me as well. I am > slightly in favour of the alternative, because it seems illogical to > require building a driver that is never going to be used. On the other > hand this patch only affects the Odroid U2, and the alternative every > board using an Exnyos chip. > > I'm still wondering why other boards, e.g. the Odroid XU3, are seemingly > (I don't have any) unaffected by this. Odroid-xu4 has the same issue, and the proposed solutions fixes the issue there as well. I also think the alternative `#if IS_ENABLED(CONFIG_CROS_EC)`-solution would be better. Thanks for reporting the issue! Best regards, Henrik Grimler