Re: [PATCH v4 2/6] tpm: Support boot measurements

Simon Glass
2023-02-02T17:13:01Z

Hi Eddie / Ilias,

On Thu, 2 Feb 2023 at 09:24, Eddie James <eajames@linux.ibm.com> wrote:
>
>
> On 1/26/23 01:51, Ilias Apalodimas wrote:
> > Hi Eddie,
> >
> > Thanks for the cleanup! Unfortunately this doesn't compile with EFI
> > selected, but in general it looks pretty good.
>
>
> Thanks, yes I forgot to remove tcg2_pcr_read
>
>
> >
> > On Wed, Jan 25, 2023 at 11:18:06AM -0600, Eddie James wrote:
> >> Add TPM2 functions to support boot measurement. This includes
> >> starting up the TPM, initializing/appending the event log, and
> >> measuring the U-Boot version. Much of the code was used in the
> >> EFI subsystem, so remove it there and use the common functions.
> >>
> >> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> >> ---
> >> include/efi_tcg2.h | 44 --
> >> include/tpm-v2.h | 254 ++++++++++
> >> lib/efi_loader/efi_tcg2.c | 975 +++-----------------------------------
> >> lib/tpm-v2.c | 799 +++++++++++++++++++++++++++++++
> >> 4 files changed, 1129 insertions(+), 943 deletions(-)

Can you please point to the spec containing what this implements? I am
still not sure why the identifiers and filenames have EFI in them.

Regards,
Simon