From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 363E9C54EAA for ; Thu, 26 Jan 2023 19:18:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7DA5F856CE; Thu, 26 Jan 2023 20:17:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ga+Fgfjt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AD9CC856D3; Thu, 26 Jan 2023 20:17:44 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5EE00855B5 for ; Thu, 26 Jan 2023 20:17:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id h24so2121586qta.12 for ; Thu, 26 Jan 2023 11:17:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9TbMnOpo4Xzn+3WXET3KFKVEXtR0mnX6Pd8aLbA8rYQ=; b=ga+FgfjtvPoLj14L6eP5lA1vumaNKbpHG+MXsSMF9VHefRMUCtXn9JP3Om64N14VyN ExFDElpuTwn/hzebsij7Ir1e7Zt/eB6KChHHEm0n6aKMHc/H82LFQTYpbPxItfNso6f/ y3XhH8bq2HufAE0cT6nItTZzGN9vqFTQ0UzZs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9TbMnOpo4Xzn+3WXET3KFKVEXtR0mnX6Pd8aLbA8rYQ=; b=B8nt4St8Q5I2Qos7wa1ofCCL6oOJGTG7pS3f1xuJSX0mSP2pAQuBleu5l10dFToIhd KIZpNR9RGAhRyjasDFmAzhn3dD5vJjNTGhxoZtkxKIjCILeEiZxfMpRZswWhfh796HGk D8HTyLuAAUsXLJdDQ6hKQKHfe5CYI8sMFQChomu6aPWydMoHwFd9o0Tn6OW4eigfPxT2 qx72LMQ2BerHaX3qkWBFJvqOoEfHZC5g8fXnhqhlDWsPS0ob4MRRmAitqM8ArGWu7q8G zZCC1QW2f3j+OfXz/ZgBQ/sIDKM4OMLg8fgHovaXHDXTDU4jwUbc7GW1V98ZT0F47FU2 WMdQ== X-Gm-Message-State: AO0yUKUZRSY80SNH5qm6O9QCry9DPViV7yUhRx3C/atSvih8DJb67VoK sJbuYbBNfsh0eBpeuXOoVJsZLw== X-Google-Smtp-Source: AK7set+UUJiNJwWPPpkb6YriT/Ofzx/9rUoIsAIpJDdGk2QtJ1pvd61FAGEgh+UIWH+qFSj3fKDTjQ== X-Received: by 2002:ac8:5e54:0:b0:3b6:2e12:4d25 with SMTP id i20-20020ac85e54000000b003b62e124d25mr11941225qtx.31.1674760657052; Thu, 26 Jan 2023 11:17:37 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-3a56-04fb-7eea-5810.res6.spectrum.com. [2603:6081:7b00:6400:3a56:4fb:7eea:5810]) by smtp.gmail.com with ESMTPSA id d10-20020ac800ca000000b003b0b903720esm1271581qtg.13.2023.01.26.11.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 11:17:36 -0800 (PST) Date: Thu, 26 Jan 2023 14:17:34 -0500 From: Tom Rini To: Mario Kicherer Cc: u-boot@lists.denx.de, sbabic@denx.de, festevam@gmail.com, uboot-imx@nxp.com, daniel.schwierzeck@gmail.com, weijie.gao@mediatek.com, GSS_MTK_Uboot_upstream@mediatek.com, rick@andestech.com, ycliang@andestech.com Subject: Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD Message-ID: References: <20230119152822.1214202-1-dev@kicherer.org> <20230119152822.1214202-2-dev@kicherer.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JxvQLSdiWzGe6IMr" Content-Disposition: inline In-Reply-To: <20230119152822.1214202-2-dev@kicherer.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --JxvQLSdiWzGe6IMr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 19, 2023 at 04:28:21PM +0100, Mario Kicherer wrote: > Add BOOT_DEVICE_NOR2 as a second SPL_LOAD_IMAGE_METHOD to enable a > board-specific spl_nor_get_uboot_base() function to return an alternative > address in the NOR flash in case booting from BOOT_DEVICE_NOR fails. >=20 > Signed-off-by: Mario Kicherer > --- > arch/arm/include/asm/spl.h | 1 + > arch/mips/include/asm/spl.h | 1 + > arch/riscv/include/asm/spl.h | 1 + > common/spl/spl_nor.c | 1 + > 4 files changed, 4 insertions(+) This breaks a lot of platforms, as it only covers a few of the cases where BOOT_DEVICE_NOR is listed. I would also really like to see how this ends up being used in the board specific case as I do wonder if we can't solve this some other way that won't have impact so many other platforms. Thanks! --=20 Tom --JxvQLSdiWzGe6IMr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPS0csACgkQFHw5/5Y0 tyxQHAwAgiVz5gRk1NGVqM6alj/H8w1hGlN8ljbLje5Uk6A34d9/3jp80ggzz21A GZOFyJgCdX34dqtrAswK5134l1ZBTa+ijdiL/iLr+c90FOFlFEVxQkCzfDIcm8kb tCR/6rPkYyR+L12NMCIog6jzAB6CA9wqJGdvmJHZdKntBJ6f0LVcRExWIbnh1lgX QVy/NwyNjgbPqQHCxEdRBNtVjCKrUhNgUrARy7a7O6U6bRDddc9kh3iZZKD7xP9D Q1yIe/o8pbh3jm1715Z2K+tSDoW4rpNFfkkacPEPKLf6sHR6Y3sLvLmkfp3UKgBQ dXTrbhdFr0FB7UA/fnrxE8o1fw8TKFqAUA7KKQgtIAk/wGVzXHCkc9GR6JcyO3bX 60Ot/1CtSLTIAUNgKE0Zo0CCVcCMn7KKwJBA3gJCKTCyZFZNitOLulEB0dKrOtXG lY5AxbLh6HfWlsIARAs+8taq5MuEqVQLpmvn7RPzSMom8Qvh3UubKQ+lemWlzZDQ aTAO41BB =XUAS -----END PGP SIGNATURE----- --JxvQLSdiWzGe6IMr--