From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2A87C54EAA for ; Fri, 27 Jan 2023 15:49:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 11740856E9; Fri, 27 Jan 2023 16:49:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="PKSqBTB8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 757AB855D2; Fri, 27 Jan 2023 16:48:40 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CFA49855D2 for ; Fri, 27 Jan 2023 16:48:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id jr19so4307845qtb.7 for ; Fri, 27 Jan 2023 07:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AheDtqWyJ9tbTjxv+nKGNMq+TH/us7eK8kLDlMtP40k=; b=PKSqBTB8SKMklVTFTz6oWYkr/SkPuCY5z688hjvffi2JV3XCTBhhXisjAciLVOIZzX VvNOz8s1nXhZbnjArrdbzJdDygDKAio4oagQGhNaISsHKWtR1ue5lopILAGckehryhbw mcWQhTUGM/e1Bitb3m/96AOIO8SGOYJmO1qa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AheDtqWyJ9tbTjxv+nKGNMq+TH/us7eK8kLDlMtP40k=; b=vmwum6kbzyIRQdMQ8Ce9jUzypcWTEbjI28XBMV6NO02RIP5RKw4+SUTfV/bRxTsgXd okCXus1v5QiKTpSfCOmmpIji4T1wnkJuO+E1GfoeENXscdx1kLb0ZFCx4PxCYHoJbRMg 8oxNLIi5WSUuYmBG8Q54TbdsKCz7rM7Atfu/QUnvMz4cClDqMDnVugpKvEzrbtkDK3RY Zb6AwySxaATm5wjv58KpZSRc+JxI9fybZun4B3ENvCaodNskdEcQNW1A0lVkUj4x4EBJ D4FBJETyKrq5wVn8QF/yEDUDRT5fG23YTDb9qwav5I/zAJHUouUzs8ZRNYClFI7AbFof UZuw== X-Gm-Message-State: AO0yUKXZ1DezKPGAc+bztj0BqemmgfgijAgnWYUq6QFV9KfLXIm7Z8bf 1lx2XV8p2C/uafEWg+ptSB/r6A== X-Google-Smtp-Source: AK7set9eh40kcWvX+8e6sDv93XKuiF/G6J350gtAfJhSElaLGJ2f3LVofwAOwQfu+eGRUcuh7O5p+g== X-Received: by 2002:ac8:5cc6:0:b0:3b6:2d75:9b07 with SMTP id s6-20020ac85cc6000000b003b62d759b07mr21165689qta.26.1674834514559; Fri, 27 Jan 2023 07:48:34 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-bacc-4546-b75d-3c88.res6.spectrum.com. [2603:6081:7b00:6400:bacc:4546:b75d:3c88]) by smtp.gmail.com with ESMTPSA id d12-20020ac85acc000000b003b68d445654sm1454484qtd.91.2023.01.27.07.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 07:48:34 -0800 (PST) Date: Fri, 27 Jan 2023 10:48:30 -0500 From: Tom Rini To: Daniel Schwierzeck Cc: Simon Glass , u-boot@lists.denx.de, Adam Ford , Alexey Brodkin , Ashok Reddy Soma , Aswath Govindraju , Bharat Gooty , Bin Meng , Brandon Maier , Bryan Brattlof , Chris Packham , Dave Gerlach , Eugeniy Paltsev , Heinrich Schuchardt , Ilias Apalodimas , Jacky Bai , Jagan Teki , Jan Kiszka , Jim Liu , John Keeping , Kautuk Consul , Kever Yang , Le Jin , Lukasz Majewski , Marek Vasut , Masahisa Kojima , Michal Simek , Nobuhiro Iwamatsu , Pali =?iso-8859-1?Q?Roh=E1r?= , Peng Fan , Philipp Tomsich , Philippe Reynes , Rasmus Villemoes , Rayagonda Kokatanur , Rick Chen , Samuel Holland , Sean Anderson , Stefan Bosch , Sughosh Ganu , Tianrui Wei , Vignesh Raghavendra , Weijie Gao , Ye Li , uboot-snps-arc@synopsys.com Subject: Re: [PATCH 02/88] treewide: Correct invalid Kconfig syntax and warnings Message-ID: References: <20230123220031.3540724-1-sjg@chromium.org> <20230123220031.3540724-3-sjg@chromium.org> <3a43b9e0-2c01-a94d-e7de-202989b9cedc@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f6n7KeKNMdlx5FcK" Content-Disposition: inline In-Reply-To: <3a43b9e0-2c01-a94d-e7de-202989b9cedc@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailman-Approved-At: Fri, 27 Jan 2023 16:49:17 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --f6n7KeKNMdlx5FcK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 27, 2023 at 04:00:15PM +0100, Daniel Schwierzeck wrote: >=20 >=20 > On 1/27/23 14:45, Tom Rini wrote: > > On Mon, Jan 23, 2023 at 02:59:05PM -0700, Simon Glass wrote: > >=20 > > > In several places a 'select' is used to select a choice, which is not > > > supported by Kconfig. In other places, the filename for the 'source' > > > command is not in quites. > > >=20 > > > Fix these two problems throughout the tree, so that kconfiglib does n= ot > > > show any more warnings. > > >=20 > > > Signed-off-by: Simon Glass > >=20 > > OK, to summarize what I just said in another email and clarify future > > work. Please first split this patch in to its own series that corrects > > each type of problem, per commit. The missing quotes for example, and > > then the extra whitespace ones. Next, commenting out a select is wrong, > > and each case needs to be better understood / fixed. I'm honestly not > > sure if asking endianness for MIPS is right and if we should select that > > from boards too, like ARC, but probably. The ARC_MMU one also should > > just not be asked, I suspect, but as a separate patch where you cc > > Alexey, we'll find out :) And so on, for each. Thanks. > >=20 >=20 > For MIPS the endianess (and also architecture/ISA level) needs to be able= to be set > by the user via menuconfig as most MIPS cores or SoCs can support multipl= e variants. > The idea is that the specific SoC or machine just sets the supported opti= ons to > restrict the options the user can choose. The board's defconfig should se= t the > required default value for each option but must not *select* it. >=20 > See the Boston board for example: >=20 > config TARGET_BOSTON > bool "Support Boston" > ... > select SUPPORTS_BIG_ENDIAN > select SUPPORTS_CPU_MIPS32_R1 > select SUPPORTS_CPU_MIPS32_R2 > select SUPPORTS_CPU_MIPS32_R6 > select SUPPORTS_CPU_MIPS64_R1 > select SUPPORTS_CPU_MIPS64_R2 > select SUPPORTS_CPU_MIPS64_R6 > select SUPPORTS_LITTLE_ENDIAN >=20 >=20 >=20 > A possible fix for ARC could be: >=20 >=20 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -53,8 +53,6 @@ config ARC > select SUPPORT_OF_CONTROL > select SYS_CACHE_SHIFT_7 > select TIMER > - select SYS_BIG_ENDIAN if CPU_BIG_ENDIAN > - select SYS_LITTLE_ENDIAN if !CPU_BIG_ENDIAN > config ARM > bool "ARM architecture" > @@ -490,7 +488,7 @@ endif > source "board/keymile/Kconfig" > -if MIPS || MICROBLAZE > +if MIPS || MICROBLAZE || ARC > choice > prompt "Endianness selection" > @@ -502,11 +500,11 @@ choice > config SYS_BIG_ENDIAN > bool "Big endian" > - depends on (SUPPORTS_BIG_ENDIAN && MIPS) || MICROBLAZE > + depends on (SUPPORTS_BIG_ENDIAN && MIPS) || MICROBLAZE || (CPU_BI= G_ENDIAN && ARC) > config SYS_LITTLE_ENDIAN > bool "Little endian" > - depends on (SUPPORTS_LITTLE_ENDIAN && MIPS) || MICROBLAZE > + depends on (SUPPORTS_LITTLE_ENDIAN && MIPS) || MICROBLAZE || (CPU= _LITTLE_ENDIAN && ARC) > endchoice >=20 >=20 >=20 > A *make savedefconfig* should than automatically add *CONFIG_SYS_LITTLE_E= NDIAN=3Dy* or > *CONFIG_SYS_BIG_ENDIAN=3Dy* to the ARC board defconfig's. Thanks for explaining. --=20 Tom --f6n7KeKNMdlx5FcK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPT8ksACgkQFHw5/5Y0 tywvgwwArQ6T9DJ9GhfVKR/4fo1nhXt36T8Ebb7qgIg0FHT5QKvCtFqfJFeReMmN foOx/XVk5hotof7GIA0D4BjruF5zN3ghiwEbn8UJCEhCWZH0jwaaolz+yWKVSDEx cVBBS90AW2k+rW17NJIPPHoFJfbzClYtLZ7b3WP7ps2KJ/nQ0iR4kZsE0OfAUiGv nC1+6mqShL3g3l/5CrfrgzyiWhf5TLGsboxJ78uvgAYhdVYcN/QlxMedwq95l0Sh 6E5E3oqCkjqjxc7SDj8sh0ES0I7TdGhZE4lz5DnRZB6vuaaSzOBOEcU/5HRs81iW g/w1CSMyqwbxu00sPsXSOdlvOuKRGOphptVa2jhYGOE+IfoQbEDr9QokjCiFQGAA Bvs67QlNnJWOkj4nMt8jp8qfzG9cSRAmOSd2m6m6q/ANeEG1pCh1/fcZIy8MSGV1 SP3HW1u5un8bAg5ldEYLNovEdVQVC2ZPw2BEUxX04SmNz3tLlz1+ReCWawLt9xXp io+709r9 =d9bL -----END PGP SIGNATURE----- --f6n7KeKNMdlx5FcK--