From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0005BC54EAA for ; Fri, 27 Jan 2023 17:58:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8FD77856DD; Fri, 27 Jan 2023 18:58:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kbCbjq4F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0CA47856E7; Fri, 27 Jan 2023 18:58:21 +0100 (CET) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 92FC3851E4 for ; Fri, 27 Jan 2023 18:58:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id x17so4680258qto.10 for ; Fri, 27 Jan 2023 09:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wOmIv7Fl36XLvEz/wXZwIwQ8DNfvQz47CrYFNwIBpL8=; b=kbCbjq4FZXvGTXkLFaMwqpkwVpw2EWIkwF3ZLRWpqzVcFtASGoCg+9eRehdLwo1N7A 8wzkC03OGdJh+OMJx3EnOSFOi3WaTpVJfMwb6bYvGSDo7eXeYCri9vgHfdRnT3R+Ls95 MyfP7D10xMd3442SmOFYMKF4nqb6s8nbUwn6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wOmIv7Fl36XLvEz/wXZwIwQ8DNfvQz47CrYFNwIBpL8=; b=zika3vzd0J2iW6F0RQEdz0sSo7oye9C14pig0LSHVlGOr/1Ce67eGyEwmGwX6JMENG IS1+bLpORGC3QfFioPtyMZeFQtdWzHz1Mn4Eqzth0DzqfEXpesmwKhYvX5vcdKr4iEaI IYCj33OlaIQHWhBOFV/HNB2Nvg4kQehrmcq4vhjQvtHG3QIg+wvXs9VmwT+70+kOZDhG VfTxKaOhQAzpAa0UTr7RptogKYuLvoTbaEOmNMXCJA7KQWuZPiPmVcu6KWj9He0DsQmm MIQpZNFFa+c49XcyhgxMTkaE+meyFp9f2ZhyfreV1LJ6LLvIEdXjgBttQEk9mlPyP/qv qtyg== X-Gm-Message-State: AFqh2krBIZYoHoRUO9HCDxYtZzpvJf5zo+3Bi3Q8DWWP05y3mBl44WkW mD1R0sB/0kQA7jDVtu31wo9DMw== X-Google-Smtp-Source: AMrXdXthsBZp6O/R3lx8xRpg+U3TQAB9Qg2M8VVLGr7Gjb5SUQ4UF0iSWOjis+x4WiVVi2Qgl9ig6Q== X-Received: by 2002:ac8:605a:0:b0:3b6:2b39:4373 with SMTP id k26-20020ac8605a000000b003b62b394373mr63355399qtm.23.1674842289372; Fri, 27 Jan 2023 09:58:09 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-bacc-4546-b75d-3c88.res6.spectrum.com. [2603:6081:7b00:6400:bacc:4546:b75d:3c88]) by smtp.gmail.com with ESMTPSA id k21-20020ac81415000000b003b63a734434sm2979767qtj.52.2023.01.27.09.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 09:58:09 -0800 (PST) Date: Fri, 27 Jan 2023 12:58:07 -0500 From: Tom Rini To: Mario Kicherer Cc: u-boot@lists.denx.de, sbabic@denx.de, festevam@gmail.com, uboot-imx@nxp.com, daniel.schwierzeck@gmail.com, weijie.gao@mediatek.com, GSS_MTK_Uboot_upstream@mediatek.com, rick@andestech.com, ycliang@andestech.com Subject: Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD Message-ID: References: <20230119152822.1214202-1-dev@kicherer.org> <20230119152822.1214202-2-dev@kicherer.org> <0f606ddab66a5dab3b8f0bcb856a73f3@kicherer.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CShWivwIF1Hj/lMm" Content-Disposition: inline In-Reply-To: <0f606ddab66a5dab3b8f0bcb856a73f3@kicherer.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --CShWivwIF1Hj/lMm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 27, 2023 at 06:55:46PM +0100, Mario Kicherer wrote: > On 2023-01-27 18:10, Tom Rini wrote: > > Yes, all of the platforms that define the value (since it roughly means > > "ROM set this value in something we can check") instead of enum'ing it > > still compile that file and now fail to build. >=20 > Okay, I think I understand your point now. I am not sure what's the best > way to proceed here. Should I try to build all targets that contain > BOOT_DEVICE_NOR and add a #define for BOOT_DEVICE_NOR2 if my patch really > breaks the build? Or should I just add a #define BOOT_DEVICE_NOR2 to every > #define BOOT_DEVICE_NOR? >=20 > It looks like a change would be necessary in these files then: >=20 > arch/arm/include/asm/arch-am33xx/spl.h > arch/arm/include/asm/arch-orion5x/spl.h > arch/arm/mach-k3/include/mach/j721e_spl.h > arch/arm/mach-k3/include/mach/j721s2_spl.h > arch/microblaze/include/asm/spl.h > arch/powerpc/include/asm/spl.h >=20 > > Ah, OK. Keep in mind that MMC1/MMC2 are for different physical MMC > > devices on a given platform. I think this is more like the case where > > you should be able to override spl_nor_get_uboot_base at the board level > > to say if you're loading A or B? >=20 > Ah yes, it's been a while since I wrote this patch originally. > spl_nor_get_uboot_base() chooses between A and B and BOOT_DEVICE_NOR2 > signals that I should choose the other one now. I think you should be able to solve this problem without making further changes upstream, yes. --=20 Tom --CShWivwIF1Hj/lMm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPUEKwACgkQFHw5/5Y0 tyz35Av/fxv9mI7lXkp43i1gjXdAlLMzMmOMiI27miMbJ1SONH5n1zijK/IYRD4g kuGcrj+yBg+z1avnkS8/UcHt58Iigip4ig8DUEKGV/LmVmjrW+awrEzUnSl47f6A dq7fjbIb3MRQ7sL93z0NQ3defEeNM+m5gkJjd2r+dvgO1eta70exHNs2izSd9nYw k2qfDCoVu/tttVT0UzQhtk8DB3HQLMIDEchpaJB29KlcRsuCBa/xzCr9Lg3vavdb nyRQNRvNdjs9VTCwSNCjtgBqF9akycVXbOsodz7oGBfrvpHz6NpXECqw4GmGETuA heV1RZ9wBZ2Jo31SjooyRSSr+nhee/x09rQ/FZzGcKRgZg12baqdTmcLxC3Yg37u K0jPeVbj5gEJ/cqIMDhADh+iuyk64GnGMqzitYptk0nnO7TKLOD98XvEaLggHi4v sB/Y6+XCQeDZjJisKFwk4MH+VobladL7bql8yafhJxmr5SaRWRzGW7EhJ1w5qkIz E4ojsJwT =4cK/ -----END PGP SIGNATURE----- --CShWivwIF1Hj/lMm--