From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C331C54EAA for ; Mon, 30 Jan 2023 17:10:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5678F8583C; Mon, 30 Jan 2023 18:10:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FmWR+nVH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4432E857A2; Mon, 30 Jan 2023 18:10:45 +0100 (CET) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 746C085802 for ; Mon, 30 Jan 2023 18:10:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id x17so10686539qto.10 for ; Mon, 30 Jan 2023 09:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6D1+1m3U7xY3et2J+Pka5Y4Akr+NuLCUSJcEend3DCg=; b=FmWR+nVHr/g+8iFWcQg8Ppq43J0qtLYCFm0sMvOozQxwFaVnmY0yluJZZ5EGnhIKf7 uIyCWgMOQ0IEjj4Dk7Z2E5ZHAdBgz7465JR2dgr/powUDfCPg3EHyR7tm6Os40Q9AT8J WkGAsKZ3dgX5MnAfnVOQPhaPPd6F9S/xlCc9U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6D1+1m3U7xY3et2J+Pka5Y4Akr+NuLCUSJcEend3DCg=; b=IrknV08PtN3s5az09G5LUyiIImyDvMQVOwBaflbdWbO6G8cjRGxrawy4EVfaqRhw6L fUEPQzF6a3RYPPXoE0fIPgYUav+/uyNFDRD4c8m3J9XRq83YeGhVCZX9odk9MpnNdiyd /s9rn2YXpwp2+u34qRwE8lBX7n9/8nZsgBaP2piXT2BZ3hAzM5/kU//DaUhIQ9PQ0Dgl Ui0tvJwZDK7d0uH+OFKy10uROORe9ka4PAZVd2E9CRiO+aBb+CnMPzm0exXX8oDMrdcE gWdmyTxctjPbkmGbhJeoMGv8yPOiOrJoh2XKZh0IXo+IwzYCIpe3AiJkNJqLOIqnsBIv /S5g== X-Gm-Message-State: AFqh2krjBQBsI1nvCf7mQdLhvDDkKLPj1CeZlHwnk3AFlqnbUXGC0rEw Q2/gFM4og957MVNrvGsMZwymKQ== X-Google-Smtp-Source: AMrXdXuUzvYSC2XJTEXjwcxdBb3HBMkLjCYDvV79rW/13kLNNuU/fe04jVf0QedTuiv6db0PPNBohA== X-Received: by 2002:ac8:4e09:0:b0:39c:da21:f1a2 with SMTP id c9-20020ac84e09000000b0039cda21f1a2mr63993407qtw.3.1675098641217; Mon, 30 Jan 2023 09:10:41 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-31da-0362-f50e-b4ac.res6.spectrum.com. [2603:6081:7b00:6400:31da:362:f50e:b4ac]) by smtp.gmail.com with ESMTPSA id cp4-20020a05622a420400b003b9a426d626sm522825qtb.22.2023.01.30.09.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 09:10:40 -0800 (PST) Date: Mon, 30 Jan 2023 12:10:39 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Mark Kettenis Subject: Re: [PATCH v2 2/2] bootstd: Replicate the dtb-filename quirks of distroboot Message-ID: References: <20230129012715.83657-1-sjg@chromium.org> <20230129012715.83657-2-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DvaBrPvp2NN3LyNg" Content-Disposition: inline In-Reply-To: <20230129012715.83657-2-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --DvaBrPvp2NN3LyNg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 28, 2023 at 06:27:15PM -0700, Simon Glass wrote: > For EFI, the distro boot scripts search in three different directories > for the .dtb file. The SOC-based filename fallback is supported only for > 32-bit ARM. >=20 > Adjust the code to mirror this behaviour. >=20 > Also some boards can use a prior-stage FDT if one is not found in the > normal way. Support this and show a warning in that case. >=20 > Signed-off-by: Simon Glass > Suggested-by: Mark Kettenis > --- >=20 > Changes in v2: > - Allow use of the prior-stage FDT if nothing else is found > - Warn about using a prior-stage FDT >=20 > boot/bootflow.c | 3 ++ > boot/bootmeth_efi.c | 70 +++++++++++++++++++++++++++++++++++++++------ > include/bootflow.h | 14 +++++++++ > 3 files changed, 78 insertions(+), 9 deletions(-) >=20 > diff --git a/boot/bootflow.c b/boot/bootflow.c > index 4999018e36e..5ee12eb2bab 100644 > --- a/boot/bootflow.c > +++ b/boot/bootflow.c > @@ -463,6 +463,9 @@ int bootflow_run_boot(struct bootflow_iter *iter, str= uct bootflow *bflow) > =20 > printf("** Booting bootflow '%s' with %s\n", bflow->name, > bflow->method->name); > + if (IS_ENABLED(CONFIG_OF_HAS_PRIOR_STAGE) && > + (bflow->flags & BOOTFLOWF_USE_PRIOR_FDT)) > + printf("** Warning: Using prior-stage device tree\n"); It should not be a warning. It should just be a statement. It's not an inherent failure or problem, but it is something the user should be aware of as it may be unexpected. Or simply because they should be just as aware here as when it's loaded from $file at $location. A huge general stumbling block when working on custom / new hardware is "did the device tree I want really get used?" so being clear where the one being used is from is important. --=20 Tom --DvaBrPvp2NN3LyNg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPX+gsACgkQFHw5/5Y0 tyx2FQwAoF8TN5p9xKvLVerTV2TU8AHMEDZ+1HRZPsYdBRp16H/6kapsmpopshnZ WwkmecXVbtGbGDrlXehumtvjLI2b3cYumVjjImZtxHnxBlbEOX+RL68RHMR/BsbY 3KyRaSD35s3fGlRtNtB8dnHz225CocXEYXaIU5enSDNzrIesx6B3489jW3KhoyAP xeLanWsFiY6e4u0lPKadBI9/BHv3e0/r0keH+NF5LulR4FVJeQC5HDJb4fblocA5 KYvr2niJbMZjUmzU5ji+WsLfaA0NBczlpiUiDB8Nznih8GQzfYxjuSYhoZtjc+eH jXRLpw/ub7Lo6Dkrpa8oS4GO+3vEnEyHMkl27QRn6s0eRrDruk6i0h20teHa4HGt ZMC/dKACk3TC62Uv1O8tabIzH7I7ftrJSMLzwx3Tjab/ma4u50UXFVa/Fu/4dggz eYhTyMsYLBguF0ZK6vGUKBc+tyuiQzgdFfVasKo7e94gLCsS5rayhSVU1b6d6Gp8 1s4CKsUz =AVTQ -----END PGP SIGNATURE----- --DvaBrPvp2NN3LyNg--