From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45BAAC54EAA for ; Mon, 30 Jan 2023 16:12:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9F9D485995; Mon, 30 Jan 2023 17:11:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="oTiEh8uS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B64AE8562D; Mon, 30 Jan 2023 16:12:09 +0100 (CET) Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 622AE85831 for ; Mon, 30 Jan 2023 16:10:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-506609635cbso163634327b3.4 for ; Mon, 30 Jan 2023 07:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XKkOOGFvkFJIDOFdRc3lXewOO8jg8Wy7SQJR/nu2sJI=; b=oTiEh8uS5QuC8qyfLpOGteKHqDJXxzhKwRCtQ2pbUMq9OKdFN76KbfuvULgD7s3zU1 wl1fKcTt5digtyvCzsiqO+hOS2qmdiSa8z8QHIzxqfU+OjLGMGY1aKdIysRapWOZWPG5 nCuq+e6E3Zm+oAIDHGolL5+538/wWZx6ER2CQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XKkOOGFvkFJIDOFdRc3lXewOO8jg8Wy7SQJR/nu2sJI=; b=lnK2UcrOAsaUmQSRI1tECpW1w43j6cqbSM/R95zBO//zee6B1/3OLUhQIgZzJTngXR YbdG2s8dB6i52pBnfm4b5CpRefTeCK8hfiCFDQUO26lr+6ojkD4ORa1DH3UlRNLli5Vy V+RP77J8woBEIPBUhvE5rZ958Dq4Zm8nHDpEbjcJTnpJtb2X/ESLK3kJgcQHE2+y0TcH fk01xMkX5RNHli+iSXOH19ZlGA5qIkcA1rEQDE9CWvA1I24WCkqfaSjW2zWCGAjxwrg4 wo+mSJ/p22MQgWL5hdaHa+DqIpTqemPU/wTdvc3Li1pBGpFkQzkcVpXiVhoqOIdPCDs7 RIJA== X-Gm-Message-State: AO0yUKU6LOMjZDsZoHmkdfwfvc/mh3ujx+S1pM0cIWsz/scvAaOqT6xb w85lrJj5Pj+yMP0QZj1UedK8Ng== X-Google-Smtp-Source: AK7set/FMAtLGbzqeR47oxsS7LJFpOdRS03TSy5K4i4p+MAA0pV8gnAGLBEwxYIJsi9wSOLPqsiAJg== X-Received: by 2002:a05:7500:5445:b0:f3:a349:8e94 with SMTP id e5-20020a057500544500b000f3a3498e94mr1091385gac.49.1675091441276; Mon, 30 Jan 2023 07:10:41 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-31da-0362-f50e-b4ac.res6.spectrum.com. [2603:6081:7b00:6400:31da:362:f50e:b4ac]) by smtp.gmail.com with ESMTPSA id f6-20020a05620a20c600b006f9f714cb6asm2171895qka.50.2023.01.30.07.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 07:10:40 -0800 (PST) Date: Mon, 30 Jan 2023 10:10:37 -0500 From: Tom Rini To: Simon Glass , Troy Kisky Cc: U-Boot Mailing List , AKASHI Takahiro , Aleksandar Gerasimovski , Anastasiia Lukianenko , Andreas Kemnade , Andrew Scull , Angelo Dureghello , Anup Patel , Ashok Reddy Soma , Aswath Govindraju , Bharat Gooty , Bin Meng , Chia-Wei Wang , Claudiu Beznea , Daniel Golle , Heiko Schocher , Heiko Thiery , Heinrich Schuchardt , Huang Jianan , Ilias Apalodimas , Jason Liu , Jeffy Chen , Jens Wiklander , Judith Mendez , Kautuk Consul , Keerthy , Leo Yu-Chi Liang , Lukasz Majewski , Manoj Sai , Marek Vasut , Masahisa Kojima , Matthias Brugger , Meenakshi Aggarwal , Neil Armstrong , Oleksandr Andrushchenko , Oleksandr Suvorov , Ovidiu Panait , Patrice Chotard , Paul Walmsley , Philipp Tomsich , =?iso-8859-1?Q?Pierre-Cl=E9ment?= Tosi , Rayagonda Kokatanur , Rick Chen , Ryan Chen , Sergiu Moga , Stefano Babic , Stephan Gerhold , Sughosh Ganu , T Karthik Reddy , Wasim Khan , Wolfgang Denk Subject: Re: [PATCH 000/171] Kconfig: More cleanup of CONFIG options Message-ID: References: <20230130144324.206208-1-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gqr6qhHB459/+T76" Content-Disposition: inline In-Reply-To: <20230130144324.206208-1-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailman-Approved-At: Mon, 30 Jan 2023 17:11:12 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --gqr6qhHB459/+T76 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 30, 2023 at 07:40:33AM -0700, Simon Glass wrote: > Quite a few CONFIG options without an SPL equivalent are used as if they > have one. For example, we see CONFIG_IS_ENABLED(IOMMU) when there is no > SPL_IOMMU Kconfig option. >=20 > This series adds new features to moveconfig to detect and remove these > problems. It includes additions to the Kconfig for options which are > needed as well as dropping unwanted us of CONFIG_IS_ENABLED, etc. >=20 > This follows on from the previous series[1] >=20 > It is available at u-boot-dm/splb-working >=20 > [1] https://patchwork.ozlabs.org/project/uboot/list/?series=3D339004 I'm a little confused at the rush, and duplication right now. As part off the CONFIG_IS_ENABLED / IS_ENABLED thread, Troy did a series of patches to convert everyone that's using CONFIG_IS_ENABLED to use IS_ENABLED, got it through CI and I assumed was trying to figure out how to get it posted, next. Further, this series does too many things, and needs a bit more thought. All of the CMD_FOO ones are obviously correct, but then the majority of the rest of the cases should likely not be adding a disabled Kconfig option but instead converted as well as it's most likely people are just silencing the checkpatch.pl message and not thinking about the ramificationns. --=20 Tom --gqr6qhHB459/+T76 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPX3eYACgkQFHw5/5Y0 tyy2bQwAtHHyhuurJRJjJ8i51/GZUasMSAEwnr7ghL/rqemThz1sC5JpbPG93lkp 6bECSEGU38rzGJBIszLlofmDccPE+X2TexDn9jDyiG5+J6pnzo8J5zf7L3kgAcRH M2/XY6Ayg6/89YXeKtdu59aZ8AF8wcQiDqwxROItutCT4eGjdNDO6iLZaqUJaEk2 FqOgzHIecx5NVNvOajbtwq1vTQtb7BV8ArbMRKmQ3L3whd5OninMmoKfDqu3LwQK aYRRL5oQyfHWmJz+c6J7UHnwatSkB0VkNHofbHtBPhYaxMT3wKibK/+fj0AVi9m8 GTbMUPYsXP/XhgVjWK6/4Hy4AxGR35qFI62iYEQ7MDpCLiFZD6g+HDHyUhodwFiy iKUeWZG6ScNE4s5Q2Y6918ctnczyP41GVb1zY0HufCp5Vq0HISJ60L1p7jwF7wCr 8ruPBzDLOCI3NLFvPCgG7zALPubRY/PL+KB7KgpNlR2rQVQ4ILA1DTDn+xOnDAG7 KgDM4EeM =CJuO -----END PGP SIGNATURE----- --gqr6qhHB459/+T76--