From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C73C8C61DA4 for ; Mon, 30 Jan 2023 16:29:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6CA11859B9; Mon, 30 Jan 2023 17:29:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="QZnZzEqr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DCDC8859B9; Mon, 30 Jan 2023 17:29:34 +0100 (CET) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C08AD859AD for ; Mon, 30 Jan 2023 17:29:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id j9so9272913qvt.0 for ; Mon, 30 Jan 2023 08:29:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R+UW8d5JsPNx0P1b/kJT412PUHLkNvaGXBgReDSqhnk=; b=QZnZzEqrPOyGJbaCrppSMgAktmRIRyAmno8MCGshp8YDDlvEhT2RxZ1vPJnzHP4pWI 7VEf645iQaUPf7eRmZxirbPIIPLE2dGe9cAX9xuG/3Tf3UsmRINlTy/F6N4OLgEBgPYa EtJL1RMaJmLKjIfvPyO5zwNlLQ6aqYU7vXY94= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R+UW8d5JsPNx0P1b/kJT412PUHLkNvaGXBgReDSqhnk=; b=GvltS8Nxb+KrUG5lCgoG/G1ihYVoa8yNTrF5Bk1osuJEr9fwLDrHdpcAMVPgV/g1qp jMbamPoAT8j/gcGrpbxUyQH74TwBr+i16b5uK12K+hey5Ugp1gnyhNkjYKM6k2rgcnf8 tV9lQQDyu2gvFmK/sYdFJSLulGXVeczvo67Va4XOQFIqxVWdVceia70ajfIGeEy8NnsT y1WWgnrfz6p+8ErgmkpriE6V+Myw5GrYQROU4DSCKFzV97oDTd4/5KtTFyxwxKOrNLAm u1zJeoME2CiGMHh3JU8B4IgWcnc4z7PN/aG9YqWUrPCZOyqTMQgV+glhlo1CtxzjRoyb noQg== X-Gm-Message-State: AFqh2krhUsU0GMxV2wAvDPHRvROoJ4PEbVc4r1a2STCDZKptU48McKXn vpyB6TH9u7HbvKuE7YxCe7XufQ== X-Google-Smtp-Source: AMrXdXvjs05BFL7fI7D8gemFGzPIk7deMID39qfRDJlcLmZ2B4eADHFF4OwL8ZsZnbAXhdIiIH6iPw== X-Received: by 2002:ad4:5301:0:b0:535:5ff1:ccb2 with SMTP id y1-20020ad45301000000b005355ff1ccb2mr49540453qvr.4.1675096169499; Mon, 30 Jan 2023 08:29:29 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-31da-0362-f50e-b4ac.res6.spectrum.com. [2603:6081:7b00:6400:31da:362:f50e:b4ac]) by smtp.gmail.com with ESMTPSA id y77-20020a376450000000b0071c535f3ff3sm4047114qkb.6.2023.01.30.08.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 08:29:29 -0800 (PST) Date: Mon, 30 Jan 2023 11:29:27 -0500 From: Tom Rini To: Mark Kettenis , Marek =?iso-8859-1?Q?Beh=FAn?= , Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , u-boot@lists.denx.de, sr@denx.de Subject: Re: [PATCH 016/171] iommu: Add a Kconfig for SPL_PINCTRL_ARMADA_38X Message-ID: References: <20230130144324.206208-1-sjg@chromium.org> <20230130144324.206208-17-sjg@chromium.org> <87k014knbe.fsf@bloch.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7IvjEQWpgIwalj4i" Content-Disposition: inline In-Reply-To: <87k014knbe.fsf@bloch.sibelius.xs4all.nl> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --7IvjEQWpgIwalj4i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 30, 2023 at 05:19:01PM +0100, Mark Kettenis wrote: > > From: Simon Glass > > Date: Mon, 30 Jan 2023 07:40:49 -0700 > >=20 > > This is implicitly used in the source and seems useful, so add it. >=20 > Not sure how this ended up with an "iommu" tag, but that seems wrong. >=20 > > Signed-off-by: Simon Glass > > --- > >=20 > > drivers/pinctrl/mvebu/Kconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/drivers/pinctrl/mvebu/Kconfig b/drivers/pinctrl/mvebu/Kcon= fig > > index 7c51d138c8b..0b2be88e3a1 100644 > > --- a/drivers/pinctrl/mvebu/Kconfig > > +++ b/drivers/pinctrl/mvebu/Kconfig > > @@ -7,6 +7,10 @@ config PINCTRL_ARMADA_38X > > Support pin multiplexing and pin configuration control on > > Marvell's Armada-38x SoC. > > =20 > > +config SPL_PINCTRL_ARMADA_38X > > + def_bool n # Armada 38x pin control driver (SPL) > > + depends on SPL && ARMADA_38X && SPL_PINCTRL_FULL > > + > > config PINCTRL_ARMADA_37XX > > depends on ARMADA_3700 && PINCTRL_FULL > > bool "Armada 37xx pin control driver" Looking at the code in question, it's because in drivers/gpio/mvebu_gpio.c we conditionally not set request / rfree dm_gpio_ops because turris_omnia (only platform in question) does not set pinctrl in SPL, but does set SPL_DM_GPIO. So the question I have, is all of that intentional and used today, in SPL, on the platform? I guess some set/get directions / values, to check board revs or something? --=20 Tom --7IvjEQWpgIwalj4i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPX8GAACgkQFHw5/5Y0 tywCKQwAqlPIYEE4aI/jZf99UBGjZ3DFOw9+/9o0CfR3MjE3iisXQ2J7gr85IGon SogeBM4ZYFUuzGv9CCgTUOnDpUIdAHTRjaXxiqXUoBx6H8wKFik1ra+d7KWD+bcW G8Ej0DGAGpcCQw7EdTuPP3DnY83BQ5PG57OTV6o5WBVfrGEQRs8Rl7pTewNBA71a IYkatPNj4yZoMkNtQEsE1RpLMilNX82zqntd2/ADQanYsMAaAezDws2rVLM8Ke8N WKeRml+Ib8NM9QQsgri7mnrEAmPLyqxbYHI0A3DEKRg6IVpIFowaXAsGswrZediB cBbsIjc/W0mpDkPAjhIdlAwHDw5RTQh4qeS4ZryrkDd6pfS6K9Q6qISbi2KRnyTC lB1SQv18tkncki7VuHD+hHmf8k/mWrRXSQuZ+GpWNZtw9DXL6OwakZZ1Vc6neMFo UohmkAC24sn1EOyNyFaAlIKnOEiG3OlWji0pciNSwiDFlQYms+1eRj/4AKLQ24LE wInJqNwz =CCYe -----END PGP SIGNATURE----- --7IvjEQWpgIwalj4i--