From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1164C61D97 for ; Mon, 30 Jan 2023 18:25:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5A756858E2; Mon, 30 Jan 2023 19:25:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="cBYTcCvG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BE41080E87; Mon, 30 Jan 2023 19:25:31 +0100 (CET) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 012D1858E2 for ; Mon, 30 Jan 2023 19:25:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id w3so2335536qts.7 for ; Mon, 30 Jan 2023 10:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l4KX1hNeiZ2MWLuukxMbhYnsWVPfiz77CFx4NAYEB9E=; b=cBYTcCvGWpqHZDk5pfWWON6VrjmhjcwGln7/nRagDQkCYqndk33lGFJv0ialJBRJD6 khMylGIMKdBmJ7+DtI1f42mjrXee1dcWLqcZJ8e0jLbsuBzD3VRTp0SHbE9pvWSJOBET ua02b4J4WevXVy6SPNmSRdf9sAN8l0StsiOw4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l4KX1hNeiZ2MWLuukxMbhYnsWVPfiz77CFx4NAYEB9E=; b=3NXyLyV5rVS2KLBbmPyt+fdJNRcibw2KsmE5aArP2cFFBkNvooYK81QeWSBrv0X+nr dQNRY9pwUA40/BDcTF4EwlKu2T4cRzHDVRGcTUhJFh2SDk6N6SZkWnH1qcEDOfRHQd9A 1rjl6+g1Mvm5Jm8ETfcJ1nGUTjn3m5Wa9mKD6g0WakSbUyqk506n2wiA7NHrjkJjKrDi RGRvof5ivSwtpKYkbbhbqPhmlTR5rGWLrwFxjO5jE6akbt7Org4iSyB1CrrcugzF1UTs GUA6uzMHRtw7e6RN2b1ThWNUUV+1qs7ymdW1UAk9Dr6NyShLektQAhj5a4tT+x36Oxaa inqQ== X-Gm-Message-State: AO0yUKUmwCF1n6aZ/Rbr8QMGGqIaRp42izQSlvrLs6HtUKG18jcFNSAp 4fEEMT3RX9AuKUjKMFEmZepB8g== X-Google-Smtp-Source: AK7set9PjGFek3oRsMnSapwDojI0bszoVowageF1bMWd17F3o4hnP8QCGimigeLYJkCBTALdV2b7Ag== X-Received: by 2002:a05:622a:24a:b0:3b8:6bef:61de with SMTP id c10-20020a05622a024a00b003b86bef61demr6776682qtx.34.1675103127755; Mon, 30 Jan 2023 10:25:27 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-31da-0362-f50e-b4ac.res6.spectrum.com. [2603:6081:7b00:6400:31da:362:f50e:b4ac]) by smtp.gmail.com with ESMTPSA id br40-20020a05620a462800b006fcc3858044sm8551664qkb.86.2023.01.30.10.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 10:25:27 -0800 (PST) Date: Mon, 30 Jan 2023 13:25:25 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Mark Kettenis , Marek =?iso-8859-1?Q?Beh=FAn?= , Simon Glass , u-boot@lists.denx.de, sr@denx.de Subject: Re: [PATCH 016/171] iommu: Add a Kconfig for SPL_PINCTRL_ARMADA_38X Message-ID: References: <20230130144324.206208-1-sjg@chromium.org> <20230130144324.206208-17-sjg@chromium.org> <87k014knbe.fsf@bloch.sibelius.xs4all.nl> <20230130181626.mramh3hgwwmtdm2n@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8hv8haFtnlfUB3jg" Content-Disposition: inline In-Reply-To: <20230130181626.mramh3hgwwmtdm2n@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --8hv8haFtnlfUB3jg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 30, 2023 at 07:16:26PM +0100, Pali Roh=E1r wrote: > On Monday 30 January 2023 11:29:27 Tom Rini wrote: > > On Mon, Jan 30, 2023 at 05:19:01PM +0100, Mark Kettenis wrote: > > > > From: Simon Glass > > > > Date: Mon, 30 Jan 2023 07:40:49 -0700 > > > >=20 > > > > This is implicitly used in the source and seems useful, so add it. > > >=20 > > > Not sure how this ended up with an "iommu" tag, but that seems wrong. > > >=20 > > > > Signed-off-by: Simon Glass > > > > --- > > > >=20 > > > > drivers/pinctrl/mvebu/Kconfig | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > >=20 > > > > diff --git a/drivers/pinctrl/mvebu/Kconfig b/drivers/pinctrl/mvebu/= Kconfig > > > > index 7c51d138c8b..0b2be88e3a1 100644 > > > > --- a/drivers/pinctrl/mvebu/Kconfig > > > > +++ b/drivers/pinctrl/mvebu/Kconfig > > > > @@ -7,6 +7,10 @@ config PINCTRL_ARMADA_38X > > > > Support pin multiplexing and pin configuration control on > > > > Marvell's Armada-38x SoC. > > > > =20 > > > > +config SPL_PINCTRL_ARMADA_38X > > > > + def_bool n # Armada 38x pin control driver (SPL) > > > > + depends on SPL && ARMADA_38X && SPL_PINCTRL_FULL > > > > + > > > > config PINCTRL_ARMADA_37XX > > > > depends on ARMADA_3700 && PINCTRL_FULL > > > > bool "Armada 37xx pin control driver" > >=20 > > Looking at the code in question, it's because in > > drivers/gpio/mvebu_gpio.c we conditionally not set request / rfree > > dm_gpio_ops because turris_omnia (only platform in question) does not > > set pinctrl in SPL, but does set SPL_DM_GPIO. So the question I have, is > > all of that intentional and used today, in SPL, on the platform? I guess > > some set/get directions / values, to check board revs or something? >=20 > I think this is because no A38x board use DM pinctrl framework for > configuring pin muxing. All boards set pin muxing in open coded board > function which directly touch HW registers. DM pinctrl driver for A38x > is relatively new and I think nobody converted any board to use it for > initialization. I do see that turris_omnia builds the pinctrl driver for full U-Boot today. But, does that mean that at some point in the future it should be converted to use SPL_PINCTRL ? As that would imply that we do not need / want SPL_PINCTRL_ARMADA_38X added (I suspect SPL_PINCTRL_STMFX and SPL_PINCTRL_ROCKCHIP are wrong) as it will be handled like the majority of other platforms in this area. --=20 Tom --8hv8haFtnlfUB3jg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPYC44ACgkQFHw5/5Y0 tyypNQv/RyUj/vhZggCAjjksyp1RmJDXBTeAesXzVerSejwG5RV7rPjcvb6+lJ+1 W/ll1KwcBUBfUa80mqyP2nKy2/m3ZigqjOQdD1h27m7bYE8Sa8hOmy1N9lrt2EFI avFA4c1OjzzMGrSdTHtSPAx3IzGQgRzY2E9dwNhHt5T6A0bRSVIyR55FnZ77aPFz DJSwLHLEyb22+WrfYif7dyUmGTDPEaFGfGrPjKUv48HWp+jECFTYMR1nWZGvT/vF 48fU4DeHNrB2sAOzi11rQCOLYmfG3Xa+4fvypvz+wOvc7GSBMn/N9UUawGj18HcR 0hb1vrDOBOlfq9NUQl2UQwlJr3hKhSEPWUytpsyRLIuwRC2Tp7XFdLvkNqxhDpEx NEiUjLxO+XxFg7Gq/6CWmAXO4z9eBvKIAtD7AcydOXXJ/BVNNJ+am2fPVKAx4GFu kCqyGRHvtlB36O6MnnElt03q+PASHI+Lv9lppjg1UqEftktzacMDAw3injrdCGJo WljC94x5 =th6q -----END PGP SIGNATURE----- --8hv8haFtnlfUB3jg--