From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FDC5C54EAA for ; Mon, 30 Jan 2023 19:44:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9D954858F6; Mon, 30 Jan 2023 20:44:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AzW5l38E"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 72A4D858EC; Mon, 30 Jan 2023 20:44:23 +0100 (CET) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DE571858E2 for ; Mon, 30 Jan 2023 20:44:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id z5so1655497qtn.8 for ; Mon, 30 Jan 2023 11:44:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bMwbnxKbpxk7zL6TOSOBTpWp6yJrmlVPtzoyqZLtyCI=; b=AzW5l38ENLxn6wYY5gRq6/PTQ/HqILJ8nhdKNVZZu8SZjh1KIc54EIwjbhB/5eI2t2 wZr23JtknGv/Q/1xLo0WMBZnmf9akC85ENAK2u9+7oTZFyF5u5Q7+DUCkGBhUmvSQeEM mPrdjf3YJk5CACUA/n5snQaKT27eclo1+7NUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bMwbnxKbpxk7zL6TOSOBTpWp6yJrmlVPtzoyqZLtyCI=; b=Uoi94iU5NY5bV3her+3NF08TQlkPCY55OVXDPeA+Ech17yqsOq4XDSwJSa7dXWZQOm 4II92EhsNnnIOsSOoOCRpEKY34yJUwddRotL78XnGsq2TP7yRQQj6AevsIoeywMnKQ6v 2eH5Tcsw9JGDar7fh4+E7sc7VJ72SqbHgwjY27y0DqgEKIyISidJdCBSmCIKaigTH26S TU1pNKMZ3xNQVNC1wIofT6I3tJE26sSu17CnYqc9jxdbv7PTRabzt8KRxsKnGoHhHIzI +myU2Fr9/5eCD+9xpOaUReCEGWPaSKRFHaaAv0zifPZhoEJCsVBgIXWbDMDzEZdUNorJ cBlw== X-Gm-Message-State: AO0yUKV4R+uOJr8YPtL9ykV6GnHfcfxiZFc+B5HgVm1edgB/MwMszQJp S/BRt94Uxzq/06q0FPvDzvVxYQ== X-Google-Smtp-Source: AK7set/MpRckxzYFIqOQ0lAd2uh2jLBEl4t37rVTR7XDEsbziBOxYRt4snbCppTHH8RDoO8WSXDlSg== X-Received: by 2002:a05:622a:2c3:b0:3b8:6a9f:9144 with SMTP id a3-20020a05622a02c300b003b86a9f9144mr9161327qtx.46.1675107858710; Mon, 30 Jan 2023 11:44:18 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-31da-0362-f50e-b4ac.res6.spectrum.com. [2603:6081:7b00:6400:31da:362:f50e:b4ac]) by smtp.gmail.com with ESMTPSA id f23-20020ac80157000000b003b868cdc689sm3011367qtg.5.2023.01.30.11.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 11:44:18 -0800 (PST) Date: Mon, 30 Jan 2023 14:44:16 -0500 From: Tom Rini To: Troy Kisky Cc: "u-boot@lists.denx.de" , sjg@chromium.org, festevam@gmail.com, marex@denx.de, gary.bisson@lairdconnect.com Subject: Re: CONFIG_IS_ENABLED vs IS_ENABLED Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="C+/kFtnzS0dzF5if" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --C+/kFtnzS0dzF5if Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 30, 2023 at 10:51:03AM -0800, Troy Kisky wrote: > Hi Tom >=20 >=20 > On Mon, Jan 30, 2023 at 9:18 AM Tom Rini wrote: >=20 > > On Sat, Jan 28, 2023 at 09:25:54AM -0800, Troy Kisky wrote: > > > Thanks Tom, > > > > > > I cleaned up the PR based on the CI results. Here's my current change= s. > > > > > > Author: Troy Kisky > > > Date: Fri Jan 27 11:03:11 2023 -0800 > > > > > > dm: device-internal: use EVENT instead of DM_EVENT, because > > > event_notify is built for EVENT > > > > > > Signed-off-by: Troy Kisky > > > > > > diff --git a/include/dm/device-internal.h b/include/dm/device-interna= l.h > > > index f31c4702086..2e725aa9416 100644 > > > --- a/include/dm/device-internal.h > > > +++ b/include/dm/device-internal.h > > > @@ -431,7 +431,7 @@ static inline void devres_release_all(struct udev= ice > > > *dev) > > > > > > static inline int device_notify(const struct udevice *dev, enum even= t_t > > > type) > > > { > > > -#if CONFIG_IS_ENABLED(DM_EVENT) > > > +#if CONFIG_IS_ENABLED(EVENT) > > > return event_notify(type, &dev, sizeof(dev)); > > > #else > > > return 0; > > > > Given 448e2b6327d0 ("event: Correct dependencies on the EVENT > > framework") I'm a little worried about this change here and want to be > > extra sure it doesn't break something inadvertently. >=20 >=20 > event_notify is in common/event, and the Makefile has > obj-$(CONFIG_$(SPL_TPL_)EVENT) +=3D event.o >=20 > So, the other option is to change the Makefile line to > obj-$(CONFIG_$(SPL_TPL_)DM_EVENT) +=3D event.o >=20 > I don't know which is best. Right, event_notify is part of the general event framework. The function above, device_notify, is part of DM_EVENT. This should probably be IS_ENABLED and not CONFIG_IS_ENABLED. > > Aside from that, > > are you able to post your series? >=20 >=20 >=20 > I was hoping each of the maintainers could run the script and see if the > patches for their area make sense. > I don't need my sign-off on any of the patches. Ah. I'm not sure how likely that is to happen. > And incorporate your checking script > > in to .gitlab-ci.yml / .azure-pipline.yml ? > > >=20 > I'll post a patch for that as an RFC OK. --=20 Tom --C+/kFtnzS0dzF5if Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPYHgoACgkQFHw5/5Y0 tywtdQv+LQL3/ykB51p7L4+indZXOtW5wml+sqkqZ7ZVfP+IQLSTpyKu19U+nsVg O8ZPpaXXym4+ongrHlP4xxErsjG+YOB90G7mNVlqVumxhi7Ge0DyTLufokRyIMBz aKS22vWCIpURq2lHVyjHAwqjRTp/Dp3OaMArbwU+GHKE+LPVmXnQv8Wm9S1ztm53 bWASRf916Z/xCPZDAvT+m3l7A77LP8Dcmi299Fm87TbkSwmduKTebNdqZF2DWJnB hAQqzu1Qib3AaLJ8F9BTvzMJY33NtlbS37XXKXf2Np32h0TcG+onNG2ZTAj8Iu78 izqR8Uh6qEell/sTcWMXipukBKuQWtqODqS1D6TjU3jkANuIZ1qdVoVfsdIFMT4K yTX0/l8oBh4VayvjgeOk9ioa3FjVLFz2cc3wPTjeqt9TR9ZsYRVJH9pwHTrYiwjt pjBqKLje3z2u72Ao8S9Ww/0Z1AYx/o1E4L+C+RipIi7erDkkQJbIxt3J5cAlRuXE BLgltGeS =Hobc -----END PGP SIGNATURE----- --C+/kFtnzS0dzF5if--