From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A851C636D4 for ; Tue, 31 Jan 2023 03:09:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BBDCB857AD; Tue, 31 Jan 2023 04:09:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="P4bDIlWP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CFA7A856B2; Tue, 31 Jan 2023 04:09:36 +0100 (CET) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 42912856B2 for ; Tue, 31 Jan 2023 04:09:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id bb40so4758138qtb.2 for ; Mon, 30 Jan 2023 19:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G5oLEezUuehmkGxHS6Vf7OsT/qC3zSAq08FDCoXCXtM=; b=P4bDIlWPQC8it5kDjPI2ESB7Csiz7FJhHs+FKXEc04e+j9d62HyBPiBkweBuicDQ5W ydPaMRbCuifq2Zlz2Y3wgk505VYxNmo054x8LhUAERRsUbnRQHjhGv7lVSdXgZH0sUwI GUzAe3WXQ1CYcaIHizd/ACDp6+wPFJjPAXOho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G5oLEezUuehmkGxHS6Vf7OsT/qC3zSAq08FDCoXCXtM=; b=nFPCU1zkr/Rc9ZD9O4dcHXo8FZu+bnet6GXmD6YRHVeYoVezB+1Yq+CQ8AKEN9Tl49 2UJIul/c2GjqR0u55sOdQwLVyjtZxwACTN71phjgRew1eRMljA6aEFg/0Pd01kZbGTDC 68MxSk9nm+yjyAKhYiWzdMov//oDi2tbYsRz+4cuWafU7sIIsgkM4NXp1lRl4M1B26Qw eXe3U6fY+MsbU7wGE0HV2MwfqRqvvq4bxRXqGztZKtINCUt/b9vh/auGv0IZTrPA4//z 0Vi/IRnJ6qL6YGEQ1PBVE2P2BPmm+SBxq7Tt7AH46bjsvQzoin0l64LVD5aE5zlogQBi m7Qw== X-Gm-Message-State: AO0yUKW4thKEDNJM9/20xNbymQ30a7fXjJ0Wi2PRKU7rv+/2IlYmVyC7 +yO2V+2JS5ioCl5h3pV3F3W0zw== X-Google-Smtp-Source: AK7set9SSrAF2WF+2KwReachI4RX5i4ACTta1w7yztAm51M3BGz8AraF0nG5wR5cul0fA8ff8xa1dw== X-Received: by 2002:a05:622a:138f:b0:3b8:696b:95e9 with SMTP id o15-20020a05622a138f00b003b8696b95e9mr11086105qtk.47.1675134571911; Mon, 30 Jan 2023 19:09:31 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-ab18-c1e6-432f-199f.res6.spectrum.com. [2603:6081:7b00:6400:ab18:c1e6:432f:199f]) by smtp.gmail.com with ESMTPSA id e15-20020ac8414f000000b003b868174e6dsm3731127qtm.4.2023.01.30.19.09.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 19:09:31 -0800 (PST) Date: Mon, 30 Jan 2023 22:09:29 -0500 From: Tom Rini To: Kever Yang Cc: Jagan Teki , Simon Glass , u-boot@lists.denx.de, Quentin Schulz Subject: Re: [PATCH] Revert "rockchip: Only call binman when TPL available" Message-ID: References: <20230127072133.852818-1-jagan@edgeble.ai> <841474fb-0cdc-cd13-8d7a-4dc4dd16626e@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mb/AqlxA7gYDpAFC" Content-Disposition: inline In-Reply-To: <841474fb-0cdc-cd13-8d7a-4dc4dd16626e@rock-chips.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --mb/AqlxA7gYDpAFC Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 31, 2023 at 10:53:38AM +0800, Kever Yang wrote: > Hi >=20 > =A0=A0=A0 I think I do this modify for those soc not have TPL, or else it= will > cause the CI build error. >=20 >=20 > TPL/ddr binary is mandatory in all rockchip SoCs now, but the mainline > U-Boot may not >=20 > able to provide the the available TPL, will need ddr init binary from > rockchip rkbin repository >=20 > instead. >=20 > So the policy is clear, the binary output on mainline U-Boot rockchip > platform: >=20 > - TPL available: u-boot-rockchip.bin with TPL, SPL, ATF, U-Boot proper; >=20 > - TPL not available: u-boot.itb with ATF, U-Boot proper. >=20 > =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0= =A0=A0 =A0=A0=A0 =A0=A0=A0 idbloader.bin generate by the > TPL(ddr init binary instead) and SPL via mkimage cmd; The thing is, this sounds an awful lot like the challenges that are presented by imx8*, and sunxi and others now. We need to have binman know what binaries need to be there for a functional output, build the functional image by default, and then only CI will also pass the flag to say "fake the missing binaries", so CI will pass, with bad binaries no one would try and use, and real users will have the build fail due to missing binaries. >=20 >=20 > Thanks, > - Kever > On 2023/1/27 15:21, Jagan Teki wrote: > > This reverts commit f5315dd6290a588434e4f79bfd2886bb7df9210d. > >=20 > > [why] > > TPL is not mandatory for not all Rockchip SoCs, some SoCs like > > RK356x, and RK3588 still use mainline u-boot without TPL as > > their ddr init programs are accessed via binaries provided by > > Rockchip instead of ddr source code. > >=20 > > Marking TPL build makes it not able to build u-boot.itb on > > RK356x targets so revert this so that it can build an SPL build > > that would support all across Rockchip platforms. > >=20 > > Suggested-by: Quentin Schulz > > Signed-off-by: Jagan Teki > > --- > > arch/arm/dts/rockchip-u-boot.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-= u-boot.dtsi > > index 234fc5df43..6d1fd7769e 100644 > > --- a/arch/arm/dts/rockchip-u-boot.dtsi > > +++ b/arch/arm/dts/rockchip-u-boot.dtsi > > @@ -11,7 +11,7 @@ > > }; > > }; > > -#ifdef CONFIG_TPL > > +#ifdef CONFIG_SPL > > &binman { > > simple-bin { > > filename =3D "u-boot-rockchip.bin"; --=20 Tom --mb/AqlxA7gYDpAFC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPYhl8ACgkQFHw5/5Y0 tyyxygv/V7d/Uff8f0Tb7ANO4ZbkBDFNXzavP9FtcZP24kNeIdtdqs2N+3+ifyhe 4ThiXjaMr9VWumMHmP1Weu/S/KaVRi3EsGsJuH3c25LwlaN4A5WtdV+8c1M91lpS EWW1y+WeeV/IjhGbCD8rWpENoIeAiEd+yd6ivNb0OciXb97t/eguS7BC7m6JpcbQ xr8NhMpDHAzt6Sbv+29KxC6XKqnoTFLbe97fQs9099hDwqNJihEk/+TM0E0RwlEt o8JWf4zkQHUiQf10D++VGSWNY6XQ8btvpGcTDzRrPL8zsbNNhzeJvolqWjHCfWQk m17jaJSZrruekuK4eRkNL3jykHyXFxo7dJWvNcz0ual319LFaYJDijDaoF5GIEg9 x3Fs4qL4XfftZs/qXZXdRTrsIlQ/EmLQ/uaa+0bvC7Z2iJFGKVydfy9kZhGcClwJ mit7cNRjUUmUmvg4WzSy5qJNsfdnUwcsre9S70KcEiI71QqhPUzS7uaYLTu29vPm 5zZi96hq =pkrs -----END PGP SIGNATURE----- --mb/AqlxA7gYDpAFC--