From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH v3 01/11] tpm: Don't include cr50 in TPL/SPL
Date: Mon, 25 Jan 2021 10:26:05 +0200 [thread overview]
Message-ID: <YA6AnXuRLJt4CdvS@apalos.home> (raw)
In-Reply-To: <20210123172607.2879600-2-sjg@chromium.org>
On Sat, Jan 23, 2021 at 10:25:57AM -0700, Simon Glass wrote:
> At present the security chip is not used in these U-Boot phases. Update
> the Makefile to exclude it.
>
> Fix a few logging statements while we are here.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
> drivers/tpm/Makefile | 2 +-
> drivers/tpm/cr50_i2c.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tpm/Makefile b/drivers/tpm/Makefile
> index 8f075b9f45f..f64d20067f8 100644
> --- a/drivers/tpm/Makefile
> +++ b/drivers/tpm/Makefile
> @@ -10,7 +10,7 @@ obj-$(CONFIG_TPM_TIS_SANDBOX) += tpm_tis_sandbox.o
> obj-$(CONFIG_TPM_ST33ZP24_I2C) += tpm_tis_st33zp24_i2c.o
> obj-$(CONFIG_TPM_ST33ZP24_SPI) += tpm_tis_st33zp24_spi.o
>
> -obj-$(CONFIG_TPM2_CR50_I2C) += cr50_i2c.o
> +obj-$(CONFIG_$(SPL_TPL_)TPM2_CR50_I2C) += cr50_i2c.o
> obj-$(CONFIG_TPM2_TIS_SANDBOX) += tpm2_tis_sandbox.o
> obj-$(CONFIG_TPM2_TIS_SPI) += tpm2_tis_spi.o
> obj-$(CONFIG_TPM2_FTPM_TEE) += tpm2_ftpm_tee.o
> diff --git a/drivers/tpm/cr50_i2c.c b/drivers/tpm/cr50_i2c.c
> index b103a6fdc39..76432bdec1f 100644
> --- a/drivers/tpm/cr50_i2c.c
> +++ b/drivers/tpm/cr50_i2c.c
> @@ -309,7 +309,7 @@ static int cr50_i2c_recv(struct udevice *dev, u8 *buf, size_t buf_len)
> int status;
> int ret;
>
> - log_debug("%s: len=%x\n", __func__, buf_len);
> + log_debug("%s: buf_len=%x\n", __func__, buf_len);
> if (buf_len < TPM_HEADER_SIZE)
> return -E2BIG;
>
> @@ -386,7 +386,7 @@ static int cr50_i2c_send(struct udevice *dev, const u8 *buf, size_t len)
> ulong timeout;
> int ret;
>
> - log_debug("%s: len=%x\n", __func__, len);
> + log_debug("len=%x\n", len);
> timeout = timer_get_us() + TIMEOUT_LONG_US;
> do {
> ret = cr50_i2c_status(dev);
> --
> 2.30.0.280.ga3ce27912f-goog
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
next prev parent reply other threads:[~2021-01-25 8:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 17:25 [PATCH v3 00/11] tpm: Support using TPM1 and TPM2 from a single API Simon Glass
2021-01-23 17:25 ` [PATCH v3 01/11] tpm: Don't include cr50 in TPL/SPL Simon Glass
2021-01-25 8:26 ` Ilias Apalodimas [this message]
2021-01-23 17:25 ` [PATCH v3 02/11] tpm: Use logging in the uclass Simon Glass
2021-01-25 8:26 ` Ilias Apalodimas
2021-01-23 17:25 ` [PATCH v3 03/11] tpm: Add debugging of request in tpm_sendrecv_command() Simon Glass
2021-01-25 8:28 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 04/11] tpm: Add an API that can support v1.2 and v2 Simon Glass
2021-01-25 8:31 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 05/11] tpm: Switch TPMv1 over to use the new API Simon Glass
2021-01-25 8:32 ` Ilias Apalodimas
2021-02-07 14:37 ` Simon Glass
2021-01-23 17:26 ` [PATCH v3 06/11] tpm: Add a basic API implementation for TPMv2 Simon Glass
2021-01-25 8:33 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 07/11] tpm: Reduce duplication in a few functions Simon Glass
2021-01-25 8:34 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 08/11] tpm: Add an implementation of define_space Simon Glass
2021-01-25 8:36 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 09/11] tpm: Add TPM2 support for read/write values Simon Glass
2021-01-25 8:37 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 10/11] tpm: Add TPM2 support for write_lock Simon Glass
2021-01-25 8:38 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 11/11] tpm: Allow disabling platform hierarchy with TPM2 Simon Glass
2021-01-25 8:38 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA6AnXuRLJt4CdvS@apalos.home \
--to=ilias.apalodimas@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox