From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH v3 02/11] tpm: Use logging in the uclass
Date: Mon, 25 Jan 2021 10:26:20 +0200 [thread overview]
Message-ID: <YA6ArJsGSzQYM/aH@apalos.home> (raw)
In-Reply-To: <20210123172607.2879600-3-sjg@chromium.org>
On Sat, Jan 23, 2021 at 10:25:58AM -0700, Simon Glass wrote:
> Update this to use log_debug() instead of the old debug().
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
> drivers/tpm/tpm-uclass.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tpm/tpm-uclass.c b/drivers/tpm/tpm-uclass.c
> index beb0fa3f93c..35774a6289e 100644
> --- a/drivers/tpm/tpm-uclass.c
> +++ b/drivers/tpm/tpm-uclass.c
> @@ -4,6 +4,8 @@
> * Written by Simon Glass <sjg@chromium.org>
> */
>
> +#define LOG_CATEGORY UCLASS_TPM
> +
> #include <common.h>
> #include <dm.h>
> #include <log.h>
> @@ -87,15 +89,15 @@ int tpm_xfer(struct udevice *dev, const uint8_t *sendbuf, size_t send_size,
> ordinal = get_unaligned_be32(sendbuf + TPM_CMD_ORDINAL_BYTE);
>
> if (count == 0) {
> - debug("no data\n");
> + log_debug("no data\n");
> return -ENODATA;
> }
> if (count > send_size) {
> - debug("invalid count value %x %zx\n", count, send_size);
> + log_debug("invalid count value %x %zx\n", count, send_size);
> return -E2BIG;
> }
>
> - debug("%s: Calling send\n", __func__);
> + log_debug("%s: Calling send\n", __func__);
> ret = ops->send(dev, sendbuf, send_size);
> if (ret < 0)
> return ret;
> --
> 2.30.0.280.ga3ce27912f-goog
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
next prev parent reply other threads:[~2021-01-25 8:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 17:25 [PATCH v3 00/11] tpm: Support using TPM1 and TPM2 from a single API Simon Glass
2021-01-23 17:25 ` [PATCH v3 01/11] tpm: Don't include cr50 in TPL/SPL Simon Glass
2021-01-25 8:26 ` Ilias Apalodimas
2021-01-23 17:25 ` [PATCH v3 02/11] tpm: Use logging in the uclass Simon Glass
2021-01-25 8:26 ` Ilias Apalodimas [this message]
2021-01-23 17:25 ` [PATCH v3 03/11] tpm: Add debugging of request in tpm_sendrecv_command() Simon Glass
2021-01-25 8:28 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 04/11] tpm: Add an API that can support v1.2 and v2 Simon Glass
2021-01-25 8:31 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 05/11] tpm: Switch TPMv1 over to use the new API Simon Glass
2021-01-25 8:32 ` Ilias Apalodimas
2021-02-07 14:37 ` Simon Glass
2021-01-23 17:26 ` [PATCH v3 06/11] tpm: Add a basic API implementation for TPMv2 Simon Glass
2021-01-25 8:33 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 07/11] tpm: Reduce duplication in a few functions Simon Glass
2021-01-25 8:34 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 08/11] tpm: Add an implementation of define_space Simon Glass
2021-01-25 8:36 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 09/11] tpm: Add TPM2 support for read/write values Simon Glass
2021-01-25 8:37 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 10/11] tpm: Add TPM2 support for write_lock Simon Glass
2021-01-25 8:38 ` Ilias Apalodimas
2021-01-23 17:26 ` [PATCH v3 11/11] tpm: Allow disabling platform hierarchy with TPM2 Simon Glass
2021-01-25 8:38 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA6ArJsGSzQYM/aH@apalos.home \
--to=ilias.apalodimas@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox