From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Thu, 28 Jan 2021 20:18:47 +0200 Subject: [PATCH v1] usb: kbd: destroy device after console is stopped In-Reply-To: <20210128175830.GW7530@bill-the-cat> References: <20210128165525.39826-1-andriy.shevchenko@linux.intel.com> <20210128175830.GW7530@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Jan 28, 2021 at 12:58:30PM -0500, Tom Rini wrote: > On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > > > Hi Andy, > > > > > > > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > > > > > In case of IOMUX enabled it assumes that console devices in the list > > > > > are available to get them stopped properly via ->stop() callback. > > > > > However, the USB keyboard driver violates this assumption and tries > > > > > to play tricks so the device get destroyed while being listed as > > > > > an active console. > > > > > > > > > > Swap the order of device deregistration and IOMUX update to avoid > > > > > the use-after-free. > > > > > > > > > > Fixes: 3cbcb2892809 ("usb: Fix usb_kbd_deregister when console-muxing is used") > > > > > Fixes: 8a8348703081 ("dm: usb: Add a remove() method for USB keyboards") > > > > > Reported-by: Nicolas Saenz Julienne > > > > > Signed-off-by: Andy Shevchenko > > > > > --- > > > > > v2: Nicolas, can you test this one instead of yours? > > > > > > > > Sadly this doesn't seem to work, and breaks a bunch of other tests in the > > > > process. You can try it yourself by running: './test/py/test.py --bd sandbox > > > > --build' > > > > > > Thanks for trying. > > > > > > Unfortunately I have unrelated bug somewhere: > > > Traceback (most recent call last): > > > File "/home/andy/prj/u-boot/./test/py/test.py", line 20, in > > > sys.exit(load_entry_point('pytest', 'console_scripts', 'pytest')(args)) > > > TypeError: console_main() takes 0 positional arguments but 1 was given > > > > Seems test cases are broken in U-Boot. > > I'm not sure how you were able to run them. > > This is I guess what Heinrich was posting a patch for earlier today. > The supported way to run the tests (so that they're the same for > everyone) is to use "pip" and "pip install -r test/py/requirements.txt". My Gosh! It is full of package == version, which is simply awful. Can it be more flexible? I hate this Python hell. -- With Best Regards, Andy Shevchenko