From: "Roger Pau Monné" <royger@freebsd.org>
To: u-boot@lists.denx.de
Subject: [PATCH] odroid-go2: remove setting SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR
Date: Sat, 6 Mar 2021 16:37:38 +0100 [thread overview]
Message-ID: <YEOhwghBYRsHzAVZ@Air-de-Roger> (raw)
In-Reply-To: <YDN2Mw8YhJoUWPw/@Air-de-Roger>
Ping?
On Mon, Feb 22, 2021 at 10:15:34AM +0100, Roger Pau Monn? wrote:
> On Wed, Feb 17, 2021 at 02:08:55PM +0100, Heiko Stuebner wrote:
> > Hi Tom,
> >
> > Am Mittwoch, 17. Februar 2021, 03:21:25 CET schrieb Tom Rini:
> > > I would say that yes, it's quite intentional that all boards for a given
> > > SoC (or SoC family) would use the same value for
> > > SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR and NOT leave it up to be per-board.
> > > It should be a matter of kilobytes being potentially wasted which is
> > > (often or most likely) worth sacrificing in the name of consistency and
> > > ease of future use / development. In other cases this ends up being
> > > something around "ROM will only load something of $X size, round that up
> > > a little bit, place U-Boot there, as it's the next thing to load".
> >
> > Ok ... then I'guess I'll not stand in the way ;-) .
> >
> > Though we're in the megabyte range with
> > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR being 0x4000 * 512 .
> > But I guess with current emmc sizes that might not matter too much.
> >
> > But should there be some sort of warning when the
> > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR doesn't match the expected
> > value? Because for example rk3399-puma and rk3368-lion historical use that
> > 0x200 instead of 0x4000 block offset and I think at least their default
> > firmware also expects u-boot to not reach that far into the emmc.
>
> Hello,
>
> It's not clear to me whether there's anything else expected from my side
> to get this accepted. Could you please clarify if the current patch is
> OK, or if it needs any changes?
>
> Thanks, Roger.
prev parent reply other threads:[~2021-03-06 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 15:59 [PATCH] odroid-go2: remove setting SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR Roger Pau Monne
2021-02-13 22:45 ` Heiko Stuebner
2021-02-14 7:25 ` Roger Pau Monné
2021-02-14 15:07 ` Roger Pau Monné
2021-02-16 14:26 ` Tom Rini
2021-02-17 1:42 ` Heiko Stuebner
2021-02-17 2:21 ` Tom Rini
2021-02-17 13:08 ` Heiko Stuebner
2021-02-22 9:15 ` Roger Pau Monné
2021-03-06 15:37 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEOhwghBYRsHzAVZ@Air-de-Roger \
--to=royger@freebsd.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox