public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH] Revert "usb: kbd: destroy device after console is stopped"
Date: Thu, 22 Apr 2021 13:52:41 +0300	[thread overview]
Message-ID: <YIFVeT8egNwswDVZ@smile.fi.intel.com> (raw)
In-Reply-To: <20210422091910.83560-1-pbrobinson@gmail.com>

On Thu, Apr 22, 2021 at 10:19:10AM +0100, Peter Robinson wrote:

Thanks for the report.

> Reverts commit eb5fd9e46c1, it causes ARMv7 devices to stop booting
> Linux when a USB keyboard is attached. The kernels starts but there's
> no output. Reverting it makes things work again.

It's not good. When we revert, we introduce another (I consider more serious)
bug.

> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> 
> This has caused us issues on a number of ARMv7 deviices. I'm not sure
> why specifically ARMv7 because it happens on a RPi3 running Fedora
> armhfp, but doesn't happen on aarch64. Issue seen on RPis, Cubietruck,
> and others.

Can we conduct a bit of investigation here?
Is it using ATAGs or command line? How Linux kernel gets its parameters?

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-04-22 10:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  9:19 [PATCH] Revert "usb: kbd: destroy device after console is stopped" Peter Robinson
2021-04-22 10:52 ` Andy Shevchenko [this message]
2021-04-22 11:11   ` Peter Robinson
2021-04-22 11:28     ` Andy Shevchenko
2021-04-22 11:30     ` Andy Shevchenko
2021-04-22 19:34       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIFVeT8egNwswDVZ@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox