public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH v4 3/3] efi_loader: add required option to use hash_calculate()
Date: Wed, 12 May 2021 11:32:10 +0300	[thread overview]
Message-ID: <YJuSiqUzpLUIZUOi@apalos.home> (raw)
In-Reply-To: <20210512065947.23998-4-masahisa.kojima@linaro.org>

On Wed, May 12, 2021 at 03:59:47PM +0900, Masahisa Kojima wrote:
> Build error occurs when CONFIG_EFI_SECURE_BOOT/
> CONFIG_EFI_CAPSULE_AUTHENTICATE/CONFIG_EFI_TCG2_PROTOCOL
> is enabled, because hash-checksum.c is not compiled.
> 
> With the following commit,
> commit 0bcb28dfb946 ("lib: Rename rsa-checksum.c to hash-checksum.c")
> CONFIG_FIT_SIGNATURE option is required to use hash_calculate() function.
> 
> This commit adds CONFIG_FIT_SIGNATURE option in Kconfig, and missing
> required options for CONFIG_EFI_TCG2_PROTOCOL.
> 
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
> ---
> 
> Changes in v4:
> - newly added in this patch series, due to rebasing
>   the base code.
> 
>  lib/efi_loader/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index b76e77180e..93463fb362 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -175,6 +175,7 @@ config EFI_CAPSULE_AUTHENTICATE
>  	select PKCS7_VERIFY
>  	select IMAGE_SIGN_INFO
>  	select EFI_SIGNATURE_SUPPORT
> +	select FIT_SIGNATURE
>  	default n
>  	help
>  	  Select this option if you want to enable capsule
> @@ -302,6 +303,12 @@ config EFI_RNG_PROTOCOL
>  config EFI_TCG2_PROTOCOL
>  	bool "EFI_TCG2_PROTOCOL support"
>  	depends on TPM_V2
> +	select FIT_SIGNATURE
> +	select SHA1
> +	select SHA256
> +	select SHA512_ALGO
> +	select SHA384
> +	select SHA512
>  	help
>  	  Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware
>  	  of the platform.
> @@ -338,6 +345,7 @@ config EFI_SECURE_BOOT
>  	select PKCS7_MESSAGE_PARSER
>  	select PKCS7_VERIFY
>  	select EFI_SIGNATURE_SUPPORT
> +	select FIT_SIGNATURE
>  	default n
>  	help
>  	  Select this option to enable EFI secure boot support.
> -- 
> 2.17.1
> 

I've sent a similar patch yesterday that Heinrich already applied on his
tree, you'll only need to add FIT_SIGNATURE now

Cheers
/Ilias

  reply	other threads:[~2021-05-12  8:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  6:59 [PATCH v4 0/3] PE/COFF measurement support Masahisa Kojima
2021-05-12  6:59 ` [PATCH v4 1/3] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled Masahisa Kojima
2021-05-12  6:59 ` [PATCH v4 2/3] efi_loader: add PE/COFF image measurement Masahisa Kojima
2021-05-12  8:34   ` Ilias Apalodimas
2021-05-12  6:59 ` [PATCH v4 3/3] efi_loader: add required option to use hash_calculate() Masahisa Kojima
2021-05-12  8:32   ` Ilias Apalodimas [this message]
2021-05-12 11:32     ` Masahisa Kojima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJuSiqUzpLUIZUOi@apalos.home \
    --to=ilias.apalodimas@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox