From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 155D7C4707A for ; Sun, 23 May 2021 08:07:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8817660234 for ; Sun, 23 May 2021 08:07:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8817660234 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E19CD81CDE; Sun, 23 May 2021 10:07:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="WSt6w9qk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4B87482AC3; Sun, 23 May 2021 10:07:26 +0200 (CEST) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB3CF81C67 for ; Sun, 23 May 2021 10:07:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ej1-x632.google.com with SMTP id n2so36885857ejy.7 for ; Sun, 23 May 2021 01:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Al4ki6xLcBvAiqgcEss6RGlWOmCTpADHv03z/ra6hN0=; b=WSt6w9qk60JEJHWTBOk+c36HQyiBGkAK8aeWxEjCyS5+QwSZOgUO5mSi6tCIJQyby/ 6Xx9u01Gnxv00v9JNHIM6SuRPATbBDMoAgyeSjd2+lcZhIcgLgSVvUxdlDPNjy5yURLV LbJ6BkUnTZRMPL62zUrzZuw5nvGS6y0JW8zRmAY3RgqSGCLThokf8NPK4a10FjQvxt4D 87tJAwiJPyL33gXDpHoxuqm+KwhWEXCe9NFCKJrIAT5mvu0OcaOb9OXZ8/Vwx3kB5Cgt o0hw/OMVE/jWmAxMpNehznODzdDzkCGSAHlHG39pOpNwFV0x2wB4uqoBcqAtM3d++amN hU8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Al4ki6xLcBvAiqgcEss6RGlWOmCTpADHv03z/ra6hN0=; b=NZR6rvpXR5Eqd/4nYqHMvcPzq+DV6UOWIcWSYlNbONHtkQUqTAYXt5UYHn6sxLfI3N VVc2mz4QWtjy4pSc5heaR7RcPkashqFCEvH+KjizLpZ/zfN0AodF2w6r+fwyj8xgw4hV cxUQMsj5KsabIGJLrR6XpYS+xtpeH3JQzDRrpZ5jtqyg0hKtEsCMqZbQux8ivv3DEaxG zYvj1f7Y/B99SFHj2K4mJjukRVIYVZ8TShA3Ltw5rj/SLHuGyf/ue4qpCLUBtuPVEh+8 d5OlhUBqsGNmXqcnk+gcU4+aCIKnWM12JprCxew7T0igJ7eID5p2UFEIOARRs2fiQFiE jf+A== X-Gm-Message-State: AOAM531nmtpaoftl1HsarlKEu51JNBXg+1lzyXn+uaqk2gxjMd6Wht6P 8QHObm9tLW3s/1sRAqkPsa5ycg== X-Google-Smtp-Source: ABdhPJzXX7J+gUKlpwDfExT/BfTLFIQpJHZVg4DoxeVBt4g2mm+0b8HzNP66Lzkr1oXg3AGiKW8tGw== X-Received: by 2002:a17:906:4cc5:: with SMTP id q5mr17920136ejt.302.1621757242196; Sun, 23 May 2021 01:07:22 -0700 (PDT) Received: from apalos.home ([94.69.77.156]) by smtp.gmail.com with ESMTPSA id y10sm6016834ejm.76.2021.05.23.01.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 01:07:21 -0700 (PDT) Date: Sun, 23 May 2021 11:07:18 +0300 From: Ilias Apalodimas To: Masami Hiramatsu Cc: Peng Fan , Simon Glass , Tom Rini , Heinrich Schuchardt , Alexander Graf , Jagan Teki , Vignesh R , Joe Hershberger , Ramon Fried , Sughosh Ganu , Jassi Brar , Masahisa Kojima , Takahiro Akashi , Tim Harvey , Bin Meng , u-boot@lists.denx.de, Jaehoon Chung Subject: Re: [PATCH v4 00/14] arm64: synquacer: Add SynQuacer/DeveloperBox support Message-ID: References: <162140306116.47256.6799058439792039400.stgit@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162140306116.47256.6799058439792039400.stgit@localhost> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Masami, On Wed, May 19, 2021 at 02:44:21PM +0900, Masami Hiramatsu wrote: > Hi, > > Here is the 4th version of the series (including some fixes for build > errors) to add SynQuacer/DeveloperBox 96board EE suport on U-Boot. > > This series includes not only DeveloperBox support but also some fixes > for the issues which I faced while porting U-Boot on the DeveloperBox. > First 3 patches are fixes, next 1 patch is a code cleanup for generic > gpio for arm. The next 7 patches adding DeveloperBox devices > and board support. The last 3 patches are related to the UEFI capsule > update (including bugfixes). > > Previous version is here: > > https://lists.denx.de/pipermail/u-boot/2021-May/449305.html > > The default debug level is set to 7. I think it would be better to set it to something more reasonable for the final commit. Unfortunately I don't have time for a more detailed review, but I did manage to run this on my Synquacer and managed to run a full linux distro with EFI. Tested-by: Ilias Apalodimas > Changes in v4 > ------------- > > I dropped a PCI bugfix because it has been merged. And add I2C driver > and enable RTC and EBBR support on the configuration. > > [06/14]: > - Add Jaehoon's reviewed-by (Thanks!) > [09/14]: > - Add a new i2c driver. > [10/14]: > - Add i2c0 and RTC node. > [11/14]: > - Add I2C and RTC configuration. > - Enable RTC and Date command. > - Remove I2C0 node before booting linux to hide it same as EDK2 does. > - Add some configurations to make it EBBR compliant. > [14/14]: > - Add some config options for EBBR. > > > BTW, should I split fixes from this series? (since I didn't expect this took > so long...) > > > DeveloperBox > ============ > > DeveloperBox is a certified 96boards Enterprise Edition board. The board/SoC has: - > * Socionext SC2A11 24-cores ARM Cortex-A53 on tbe Mini-ATX form factor motherboard > * 4 DIMM slots (4GB DDR4-2400 UDIMM shipped by default) > * 1 4xPCIe Gen2 slot and 2 1xPCIe Gen2 slots > (1x slots are connected via PCIe bridge chip) > * 4 USB-3.0 ports > * 2 SATA ports > * 1 GbE network port > * 1 USB-UART serial port (micro USB) > * 64MB SPI NOR Flash > * 8GB eMMC Flash Storage > * 96boards LS connector > > The DeveloperBox schematic can be found here: - > https://www.96boards.org/documentation/enterprise/developerbox/hardware-docs/mzsc2am_v03_20180115_a.pdf > > And the other documents can be found here: - > https://www.96boards.org/documentation/enterprise/developerbox/ > > > Currently, the U-Boot port supports: - > * USB > * eMMC > * SPI-NOR > * SATA > * GbE > > The DeveloperBox boots the TF-A and EDK2 as a main bootloader by default. > The DeveloperBox U-Boot port will replace the EDK2 and boot from TF-A as > BL33, but no need to combine with it. > > > Thank you, > > --- > > Jassi Brar (4): > mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver > spi: synquacer: Add HSSPI SPI controller driver for SynQuacer > net: synquacer: Add netsec driver > i2c: synquacer: SNI Synquacer I2C controller > > Masami Hiramatsu (10): > ata: ahci-pci: Use scsi_ops to initialize ops > dm: pci: Skip setting VGA bridge bits if parent device is the host bus > efi: Fix to use null handle to create new handle for efi_fmp_raw > gpio: Introduce CONFIG_GPIO_EXTRA_HEADER to cleanup #ifdefs > pci: synquacer: Add SynQuacer ECAM based PCIe driver > ARM: dts: synquacer: Add device trees for DeveloperBox > board: synquacer: Add DeveloperBox 96boards EE support > dfu_mtd: Ignore non-implemented lock device failure > doc: qemu: arm64: Fix the documentation of capsule update > configs: synquacer: Enable EFI capsule update support > > > arch/arm/Kconfig | 108 ++ > arch/arm/dts/Makefile | 2 > arch/arm/dts/synquacer-sc2a11-caches.dtsi | 73 + > .../dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 75 + > arch/arm/dts/synquacer-sc2a11-developerbox.dts | 56 + > arch/arm/dts/synquacer-sc2a11.dtsi | 595 ++++++++++ > arch/arm/include/asm/gpio.h | 8 > board/socionext/developerbox/Kconfig | 36 + > board/socionext/developerbox/MAINTAINERS | 14 > board/socionext/developerbox/Makefile | 9 > board/socionext/developerbox/developerbox.c | 146 +++ > configs/synquacer_developerbox_defconfig | 131 ++ > doc/board/emulation/qemu_capsule_update.rst | 11 > doc/board/index.rst | 1 > doc/board/socionext/developerbox.rst | 87 ++ > doc/board/socionext/index.rst | 9 > drivers/ata/ahci-pci.c | 2 > drivers/dfu/dfu_mtd.c | 2 > drivers/i2c/Kconfig | 7 > drivers/i2c/Makefile | 1 > drivers/i2c/synquacer_i2c.c | 338 ++++++ > drivers/mmc/Kconfig | 10 > drivers/mmc/Makefile | 1 > drivers/mmc/f_sdh30.c | 81 + > drivers/net/Kconfig | 8 > drivers/net/Makefile | 1 > drivers/net/sni_netsec.c | 1134 ++++++++++++++++++++ > drivers/pci/Kconfig | 12 > drivers/pci/Makefile | 1 > drivers/pci/pci-uclass.c | 3 > drivers/pci/pcie_ecam_synquacer.c | 600 +++++++++++ > drivers/spi/Kconfig | 8 > drivers/spi/Makefile | 1 > drivers/spi/spi-synquacer.c | 491 +++++++++ > include/configs/synquacer.h | 115 ++ > lib/efi_loader/efi_capsule.c | 2 > 36 files changed, 4162 insertions(+), 17 deletions(-) > create mode 100644 arch/arm/dts/synquacer-sc2a11-caches.dtsi > create mode 100644 arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi > create mode 100644 arch/arm/dts/synquacer-sc2a11-developerbox.dts > create mode 100644 arch/arm/dts/synquacer-sc2a11.dtsi > create mode 100644 board/socionext/developerbox/Kconfig > create mode 100644 board/socionext/developerbox/MAINTAINERS > create mode 100644 board/socionext/developerbox/Makefile > create mode 100644 board/socionext/developerbox/developerbox.c > create mode 100644 configs/synquacer_developerbox_defconfig > create mode 100644 doc/board/socionext/developerbox.rst > create mode 100644 doc/board/socionext/index.rst > create mode 100644 drivers/i2c/synquacer_i2c.c > create mode 100644 drivers/mmc/f_sdh30.c > create mode 100644 drivers/net/sni_netsec.c > create mode 100644 drivers/pci/pcie_ecam_synquacer.c > create mode 100644 drivers/spi/spi-synquacer.c > create mode 100644 include/configs/synquacer.h > > -- > Masami Hiramatsu