From: Patrick Wildt <patrick@blueri.se>
To: Anand Moon <linux.amoon@gmail.com>
Cc: u-boot@lists.denx.de, Neil Armstrong <narmstrong@baylibre.com>,
Kever Yang <kever.yang@rock-chips.com>
Subject: Re: [PATCHv3 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning
Date: Fri, 4 Jun 2021 17:45:48 +0200 [thread overview]
Message-ID: <YLpKrIRKJjMnLzm6@mini.fritz.box> (raw)
In-Reply-To: <20210604045607.1003-2-linux.amoon@gmail.com>
Am Fri, Jun 04, 2021 at 04:56:06AM +0000 schrieb Anand Moon:
> Drop the unused variable warning below.
>
> drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable
> 'val' [-Wunused-variable]
> 161 | u32 val;
> | ^~~
> Cc: Patrick Wildt <patrick@blueri.se>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> V1
> V2: Added Neil review tags.
> ---
> drivers/pci/pcie_dw_rockchip.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> index 3ac2434b69..4e448c0a3d 100644
> --- a/drivers/pci/pcie_dw_rockchip.c
> +++ b/drivers/pci/pcie_dw_rockchip.c
> @@ -158,8 +158,6 @@ static inline void rk_pcie_writel_apb(struct rk_pcie *rk_pcie, u32 reg,
> */
> static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed)
> {
> - u32 val;
> -
> dw_pcie_dbi_write_enable(&pci->dw, true);
>
> clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY,
> --
> 2.31.1
>
Reviewed-by: Patrick Wildt <patrick@blueri.se>
next prev parent reply other threads:[~2021-06-04 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 4:56 [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Anand Moon
2021-06-04 4:56 ` [PATCHv3 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning Anand Moon
2021-06-04 15:45 ` Patrick Wildt [this message]
2021-06-08 7:05 ` Kever Yang
2021-06-04 4:56 ` [PATCHv3 3/3] pci: pcie_dw_rockchip: Replace msleep occurences by udelay Anand Moon
2021-06-04 15:44 ` Patrick Wildt
2021-06-05 11:56 ` Anand Moon
2021-06-08 7:06 ` Kever Yang
2021-06-04 15:46 ` [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Patrick Wildt
2021-06-08 7:05 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLpKrIRKJjMnLzm6@mini.fritz.box \
--to=patrick@blueri.se \
--cc=kever.yang@rock-chips.com \
--cc=linux.amoon@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox