Re: [PATCH 2/3 v2] efi_loader: Force a sinlge FMP instance per hardware store

[Ilias Apalodimas <ilias.apalodimas@linaro.org>]

On Fri, Jun 18, 2021 at 10:52:51PM +0900, Masami Hiramatsu wrote:
> Hi Ilias,
> 
> 2021???6???18???(???) 19:51 Ilias Apalodimas <ilias.apalodimas@linaro.org>:
> >
> > Chapter 23 of the EFI spec (rev 2.9) says:
> > "A specific updatable hardware firmware store must be represented by
> > exactly one FMP instance".
> > This is not the case for us, since both of our FMP protocols can be
> > installed at the same time because they are controlled by a single
> > 'dfu_alt_info' env variable.
> > So make the config options depend on each other and allow the user to
> > install one of them at any given time.  If we fix the meta-data provided
> > by the 'dfu_alt_info' in the future,  to hint about the capsule type
> > (fit or raw) we can revise this and enable both FMPs to be installed, as
> > long as they target different firmware hardware stores
> >
> > Note that we are not using a Kconfig 'choice' on purpose, since we
> > want to allow both of those to be installed and tested in sandbox
> 
> This sounds like changing the Kconfig, thus...
> 

It does 

> [...]
> >
> > -       /* Load capsule drivers */
> > -       ret = arch_efi_load_capsule_drivers();
> > -       if (ret != EFI_SUCCESS)
> > -               return ret;
> 
> I think this part of the change should be included in the next patch.
> 
> Thank you,

Yep, I completely missed this during the rebasing.  I'll send a v3.

Thanks!
/Ilias