From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 124B0C11F68 for ; Fri, 2 Jul 2021 07:32:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22B7A6137D for ; Fri, 2 Jul 2021 07:32:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22B7A6137D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E3EC480C84; Fri, 2 Jul 2021 09:32:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iLlnPJY9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0C32680F0E; Fri, 2 Jul 2021 09:32:49 +0200 (CEST) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B770A80C84 for ; Fri, 2 Jul 2021 09:32:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x430.google.com with SMTP id v5so11273876wrt.3 for ; Fri, 02 Jul 2021 00:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/HZR9J/v2t1zQhlaaVL6fNiaTRzcV0hnlQiozUVJNyI=; b=iLlnPJY9m5j10FsuxlxF70DGYD67pXJJN7R4xsd6SHVl8PnbjRsrfeVf6C3IopaBtm Vj4wwNQYKE1j8agdBwFxzxKf7EKFupAutO9z94rl5MP53TJcig1S1IWZWOptznbz14Uu R1NDjTORr8klCqFqzJYMYns9rThfC/ywE+cKfO5sJZHRsb9eHrKVQIA+KhzUrolZJ9MG a9dq/H4WLjYECyBEU5Ze/fPgxemABcU+BGAq/FNeKW2cIr/yWVOcWcpNXcoB16VCicK9 qhKXyl1ixzqh8PpjZdQEa/6rFwbUeW1nC5rL9uX/HcR/k2EVL7orp8MxvhQ4g2V+oa5F a8rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/HZR9J/v2t1zQhlaaVL6fNiaTRzcV0hnlQiozUVJNyI=; b=f9yq4Vb22CPMTKqfYEWCsC18ex6aJoUXJMnTeRweK6+kodP2jgKTnncKvAjT1wFPcw qOKme5/I4JUXdQsfm3ahl7OjFehLho7ST/TJcEtPw6BhP5gE5OQ2O9yTSohGxZtd9nlm udxCCPeRV33ebCz+a5YRRuGqyIF/xdRbsSDr7XBdmrpeyvVV8NK+aegOnfo/yn1QY1Yp YM3ImTA02aJvpI/D3s1w//iQhd4w1OVnHCRJY7ExkXjmxvDmhU/tCocN3MKOqKqoz+cw BaJaHxmKlUOXJrWQjdd+G75t1EPxO1v7tIwNDrQhSBKlxgr5PtH+5cCO5WQBUFzx1Is/ qoVg== X-Gm-Message-State: AOAM533QnKnoCGYGKgbvjoQdzO4WhVMOGT8paibuyoO/rDgBvUtf1hqG 25L1H2PuvGi7Rses+MDlwrlFfQ== X-Google-Smtp-Source: ABdhPJzCjbqHfA64tT5ayLWTlWpH6teuqdSykVfwOQ7lvrJsGz2LIftO2CCfnLO2Eonruxg3qu3uZA== X-Received: by 2002:adf:e507:: with SMTP id j7mr4164729wrm.152.1625211165331; Fri, 02 Jul 2021 00:32:45 -0700 (PDT) Received: from enceladus (ppp-94-66-242-227.home.otenet.gr. [94.66.242.227]) by smtp.gmail.com with ESMTPSA id w13sm2453909wrl.47.2021.07.02.00.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 00:32:44 -0700 (PDT) Date: Fri, 2 Jul 2021 10:32:42 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: masami.hiramatsu@linaro.org, takahiro.akashi@linaro.org, Michal Simek , Alexander Graf , u-boot@lists.denx.de Subject: Re: [PATCH 2/3 v3] efi_loader: Force a sinlge FMP instance per hardware store Message-ID: References: <20210622143854.15682-1-ilias.apalodimas@linaro.org> <20210622143854.15682-2-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > > + bool "FMP driver for FIT images" [...] > > + depends on FIT > > + depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT > > Should here be: > > depends on SANDBOX || (!SANDBOX && !EFI_CAPSULE_FIRMWARE_RAW) > Well on of them is enough and makes them mutually exclusive. If you choose EFI_CAPSULE_FIRMWARE_RAW in this specific case the FIT variant will dissapear. I dont mind adding it for completeness, up to you Cheers /Ilias > Best regards > > Heinrich > > > + select UPDATE_FIT > > + select DFU > > + select EFI_CAPSULE_FIRMWARE > > + help > > + Select this option if you want to enable firmware management protocol > > + driver for FIT image > > + > > +config EFI_CAPSULE_FIRMWARE_RAW > > + bool "FMP driver for raw images" > > + depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT > > + depends on SANDBOX || (!SANDBOX && !EFI_CAPSULE_FIRMWARE_FIT) > > + select DFU_WRITE_ALT > > + select DFU > > + select EFI_CAPSULE_FIRMWARE > > + help > > + Select this option if you want to enable firmware management protocol > > + driver for raw image > > + > > config EFI_CAPSULE_AUTHENTICATE > > bool "Update Capsule authentication" > > depends on EFI_CAPSULE_FIRMWARE > > @@ -181,29 +203,6 @@ config EFI_CAPSULE_AUTHENTICATE > > Select this option if you want to enable capsule > > authentication > > > > -config EFI_CAPSULE_FIRMWARE_FIT > > - bool "FMP driver for FIT image" > > - depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT > > - depends on FIT > > - select UPDATE_FIT > > - select DFU > > - select EFI_CAPSULE_FIRMWARE > > - default n > > - help > > - Select this option if you want to enable firmware management protocol > > - driver for FIT image > > - > > -config EFI_CAPSULE_FIRMWARE_RAW > > - bool "FMP driver for raw image" > > - depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT > > - select DFU > > - select DFU_WRITE_ALT > > - select EFI_CAPSULE_FIRMWARE > > - default n > > - help > > - Select this option if you want to enable firmware management protocol > > - driver for raw image > > - > > config EFI_DEVICE_PATH_TO_TEXT > > bool "Device path to text protocol" > > default y > > >