public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Bin Meng <bmeng.cn@gmail.com>,
	Christian Gmeiner <christian.gmeiner@gmail.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH] smbios: Fix BIOS Characteristics Extension Byte 2
Date: Sat, 26 Jun 2021 21:40:20 +0300	[thread overview]
Message-ID: <YNd0lGwb3qnM3mlU@enceladus> (raw)
In-Reply-To: <CAPnjgZ0M2MQJq=DwV8q8rEYHroRzOqza5QDcLXaf445moRtsUA@mail.gmail.com>

Hi Simon, 

> >         t->bios_characteristics_ext1 = BIOS_CHARACTERISTICS_EXT1_ACPI;
[...]
> >  #endif
> >  #ifdef CONFIG_EFI_LOADER
> 
> Can you please drop this #ifdef while you are here - should use IS_ENABLED()
> 

I think Heinrich already merged those and sent a request to Tom. Regardless
I'll send a follow up chaning this as well

> > -       t->bios_characteristics_ext1 |= BIOS_CHARACTERISTICS_EXT1_UEFI;
> > +       t->bios_characteristics_ext2 |= BIOS_CHARACTERISTICS_EXT2_UEFI;
> >  #endif
> > -       t->bios_characteristics_ext2 = BIOS_CHARACTERISTICS_EXT2_TARGET;
> > +       t->bios_characteristics_ext2 |= BIOS_CHARACTERISTICS_EXT2_TARGET;
> >
> >         /* bios_major_release has only one byte, so drop century */
> >         t->bios_major_release = U_BOOT_VERSION_NUM % 100;
> > --
> > 2.32.0.rc0
> >
> 
> Regards,
> Simon

Cheers
/Ilias

      reply	other threads:[~2021-06-26 18:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 15:14 [PATCH] smbios: Fix BIOS Characteristics Extension Byte 2 Ilias Apalodimas
2021-06-10 10:11 ` Heinrich Schuchardt
2021-06-10 10:18   ` Ilias Apalodimas
2021-06-26 18:29 ` Simon Glass
2021-06-26 18:40   ` Ilias Apalodimas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNd0lGwb3qnM3mlU@enceladus \
    --to=ilias.apalodimas@linaro.org \
    --cc=bmeng.cn@gmail.com \
    --cc=christian.gmeiner@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox