From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE0CC11F65 for ; Wed, 30 Jun 2021 19:18:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD31661464 for ; Wed, 30 Jun 2021 19:18:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD31661464 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AA45E82E13; Wed, 30 Jun 2021 21:18:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="XZZPIqie"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 73AC482E32; Wed, 30 Jun 2021 21:18:19 +0200 (CEST) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D400882C60 for ; Wed, 30 Jun 2021 21:18:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ej1-x62b.google.com with SMTP id o5so6079093ejy.7 for ; Wed, 30 Jun 2021 12:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cFLEyUAvH1jD/tW0L8aGHKm7aJnRfnoobqmvyx1Nljo=; b=XZZPIqielE2emuAir4yk5uBr7/dagoQT2vlyRpPJN8Du6y8w1UC2Xwp4sWRX/OqSr7 c7th3ySMGkp6Gd3gWmTdEerBniBdDxsjWZ+M3S9PzbjyGHQaup8k8/hi2CyfS8GP+37N AneuNFnKZaNuBzO3Q1hOWdO1WKpfOpOrr2bxgsshu68V5yFur+32ZOq4R1yjFNuLVDaN qzk5eWUue75VPMGaBYAZ/TOkxpHrqHENv0dPu7/a7pd9P3CnVFswp9e5MCpP6gxaESBp HubGqwKXgNwbiqhl/LobkEG7isVaA8Ek2wS2eLEu1KBSoxFF72ax1oMH7N+dactXdTkB yHgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cFLEyUAvH1jD/tW0L8aGHKm7aJnRfnoobqmvyx1Nljo=; b=DlL/RMWPAt/UxL2vz14Bbj7A3vnYHD0kXuFrqiBp//XRi3GB299BQKmihTBXjFXyY/ XvPhchQ8BilbIujAmREJiErB88b96Qvc2txqrjQcUMONirJ1egza9P8iIzuen3vyGkbE DiSmZr6E21xD2PSIQocdwfCsV+AaNhjVSH0CpzeAHiAAep//XjdNfMp1JmNUYfYcUsVE bR6Oqc7C5ivmtQpVLzrLpPWBK7wfRFsDA0cKsBULEb9fU6E8K2icNHk8Eiq4nSxKlcii qTCdatUoEJ44xhnK39q6lFNoe6EC9+CS3OqX76T9X3wPDC9KRdVjmmMHZ6SgRUH6A5RW x9/Q== X-Gm-Message-State: AOAM531/ordZXmP7F7RDxSw7Z0QNMuDAkD8RtW0FXSG59eP7HgxT9I3M s2L4yFhFvV8SDPueCreqpHvzcQ== X-Google-Smtp-Source: ABdhPJw61nWoLKoKooS/p3qyoWUmrASZ5qV/I5b4wnMsF8Vk8XrrQq3eBM140Zp5npXTDgFenqlJMQ== X-Received: by 2002:a17:907:97ce:: with SMTP id js14mr3828322ejc.232.1625080696550; Wed, 30 Jun 2021 12:18:16 -0700 (PDT) Received: from enceladus (ppp-94-66-242-227.home.otenet.gr. [94.66.242.227]) by smtp.gmail.com with ESMTPSA id df20sm13382696edb.76.2021.06.30.12.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 12:18:16 -0700 (PDT) Date: Wed, 30 Jun 2021 22:18:13 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Alexander Graf , AKASHI Takahiro Subject: Re: [PATCH v2 2/2] efi_loader: clear OsIndications Message-ID: References: <20210630153116.26756-1-xypron.glpk@gmx.de> <20210630153116.26756-3-xypron.glpk@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630153116.26756-3-xypron.glpk@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, > if (IS_ENABLED(CONFIG_EFI_CAPSULE_ON_DISK) && [...] > !IS_ENABLED(CONFIG_EFI_CAPSULE_ON_DISK_EARLY)) > ret = efi_launch_capsules(); > + if (ret != EFI_SUCCESS) > + goto out; > + I think OsIndications should be cleared reagrdless of the capsuleupdate result. There's a detailed explanation on your v1 Cheers Ilias > + ret = efi_clear_os_indications(); > out: > efi_obj_list_initialized = ret; > return ret; > -- > 2.30.2 >