From: Patrick Wildt <patrick@blueri.se>
To: Simon Glass <sjg@chromium.org>
Cc: Pratyush Yadav <p.yadav@ti.com>,
Jean-Jacques Hiblot <jjhiblot@ti.com>,
u-boot@lists.denx.de
Subject: [PATCH] mux: correct prototype for mux_control_try_select()
Date: Tue, 13 Jul 2021 23:02:18 +0200 [thread overview]
Message-ID: <YO3/WmyXZfbj+jbf@mini.fritz.box> (raw)
The macro should be passed a state, which should be passed
to the actual function. Otherwise using that macro would
yield a build error.
Signed-off-by: Patrick Wildt <patrick@blueri.se>
---
include/mux.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/mux.h b/include/mux.h
index 23844f480a..9f80991274 100644
--- a/include/mux.h
+++ b/include/mux.h
@@ -51,7 +51,7 @@ unsigned int mux_control_states(struct mux_control *mux);
*/
int __must_check mux_control_select(struct mux_control *mux,
unsigned int state);
-#define mux_control_try_select(mux) mux_control_select(mux)
+#define mux_control_try_select(mux, state) mux_control_select(mux, state)
/**
* mux_control_deselect() - Deselect the previously selected multiplexer state.
@@ -128,7 +128,7 @@ int __must_check mux_control_select(struct mux_control *mux,
return -ENOSYS;
}
-#define mux_control_try_select(mux) mux_control_select(mux)
+#define mux_control_try_select(mux, state) mux_control_select(mux, state)
int mux_control_deselect(struct mux_control *mux)
{
--
2.32.0
next reply other threads:[~2021-07-13 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 21:02 Patrick Wildt [this message]
2021-07-14 8:12 ` [PATCH] mux: correct prototype for mux_control_try_select() Pratyush Yadav
2021-07-23 12:34 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO3/WmyXZfbj+jbf@mini.fritz.box \
--to=patrick@blueri.se \
--cc=jjhiblot@ti.com \
--cc=p.yadav@ti.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox