Re: Pull request for efi-2021-07-rc5-2

[Ilias Apalodimas <ilias.apalodimas@linaro.org>]

> >      >EFI stub: Booting Linux Kernel...

[...]

> >      >EFI stub: Using DTB from configuration table
> >      >...
> >      >[?? ?? 0.000000] Linux version 5.10.45 (dxue@build-server)
> >      >(aarch64-buildroot-linux-musl-gcc.br_real (Buildroot
> >      >2019.08-10705-g7cb51d4843-dirty) 10.3.0, GNU ld (GNU Binutils) 2.36.1)
> >      >#21
> >      >[?? ?? 0.000000] Machine model: Libre Computer AML-S805X-AC
> >      >...
> >      >[?? ?? 0.000000] efi: ESRT=0x3aeea040 RTPROP=0x3aee8040
> >     SMBIOS=0x3aee4000
> >      >RNG=0x394ee040 MEMRESERVE=0x394ed040
> >      >
> >      >/sys/firmware/devicetree/base/smbios/smbios # grep -r . *
> >      >baseboard/manufacturer:libre-computer
> >      >baseboard/product:aml-s805x-ac
> >      >baseboard/name:baseboard
> >      >chassis/manufacturer:libre-computer
> >      >chassis/product:aml-s805x-ac
> >      >chassis/name:chassis
> > 
> >     This matces the device tree segment below.
> > 
> >      >name:smbios
> >      >system/manufacturer:libre-computer
> >      >system/product:aml-s805x-ac
> >      >system/name:system
> >      >/sys/firmware/devicetree/base/smbios/smbios # cd
> >      >/sys/devices/virtual/dmi/id
> >      >/sys/devices/virtual/dmi/id # grep -r . *
> >      >bios_date:07/03/2021
> >      >bios_release:21.7
> >      >bios_vendor:U-Boot
> >      >bios_version:2021.07-rc5+
> >      >board_name:Unknown Product
> >      >board_vendor:Unknown
> >      >chassis_type:3
> >      >chassis_vendor:Unknown
> > 
> >     All that is marked unknown is not in your device-tree below.
> > 
> >     What are you expecting here?
> >     Was it here before the pull request?
> > 
> >     Best regards
> > 
> >     Heinrich
> > 
> >      >modalias:dmi:bvnU-Boot:bvr2021.07-rc5+:bd07/03/2021:br21.7:svnUnknown:pnUnknownProduct:pvr:rvnUnknown:rnUnknownProduct:rvr:cvnUnknown:ct3:cvr:
> >      >power/runtime_active_time:0
> >      >power/runtime_status:unsupported
> >      >power/runtime_suspended_time:0
> >      >power/control:auto
> >      >product_name:Unknown Product
> >      >sys_vendor:Unknown
> >      >uevent:MODALIAS=dmi:bvnU-Boot:bvr2021.07-rc5+:bd07/03/2021:br21.7:svnUnknown:pnUnknownProduct:pvr:rvnUnknown:rnUnknownProduct:rvr:cvnUnknown:ct3:cvr:
> >      >
> >      >diff --git a/arch/arm/dts/meson-gxl-s805x-libretech-ac-u-boot.dtsi
> >      >b/arch/arm/dts/meson-gxl-s805x-libretech-ac-u-boot.dtsi
> >      >index 39270ea71c..02177c64a6 100644
> >      >--- a/arch/arm/dts/meson-gxl-s805x-libretech-ac-u-boot.dtsi
> >      >+++ b/arch/arm/dts/meson-gxl-s805x-libretech-ac-u-boot.dtsi
> >      >@@ -5,3 +5,26 @@
> >      >?? */
> >      >
> >      > #include "meson-gxl-u-boot.dtsi"
> >      >+
> >      >+/ {
> >      >+?? ?? ?? ??smbios {
> >      >+?? ?? ?? ?? ?? ?? ?? ??compatible = "u-boot,sysinfo-smbios";
> >      >+
> >      >+?? ?? ?? ?? ?? ?? ?? ??smbios {
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??system {
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??manufacturer = "libre-computer";
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??product = "aml-s805x-ac";
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??};
> >      >+
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??baseboard {
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??manufacturer = "libre-computer";
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??product = "aml-s805x-ac";
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??};
> >      >+
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??chassis {
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??manufacturer = "libre-computer";
> >      >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??};
> >      >+?? ?? ?? ?? ?? ?? ?? ??};
> >      >+?? ?? ?? ??};
> >      >+};
> >      >
> >      >Any ideas?
> >      >
> >      >Best,
> >      >Da
> > 
> > There's two issues:
> > 
> > 1) I just saw this patch: "x86: Provide default SMBIOS
> > manufacturer/product". Should we add the same thing for ARM or maybe
> > generically across the board?
> > 
> > 2) The DMI entries previously took CONFIG_SYS_VENDOR and
> > CONFIG_SYS_BOARD entries as manufacturer and product respectively. Now
> > those entries become Unknown and Unknown Product.

Which version was that? My patch changed nothing in that regard.
The only thing my patch did was fix e4f8e543f1a9 which removed some Kconfig
options. Removing those made the strings "" which is against the spec. 
Heinrich fixed a similar issue with 00a871d34e2f back when we had 
CONFIG_SMBIOS_MANUFACTURER and CONFIG_SMBIOS_PRODUCT_NAME. Any chance that 
was your working version and those values were used?

> 
> Having file smbios.dtsi in an x86 specific path (arch/x86/dts/) does not
> make much sense. There is nothing architecture specific in it.
> 
> Maybe where Ilias now has filled the missing properties with 'Unknown'
> he should have opted for CONFIG_SYS* instead if available. This would
> make smbios.dtsi superfluous.

We discussed this with Simon and I'll send a follow up patch. The idea is to
try and use CONFIG_SYS* and if those are not available, pop a warning and use
Unknown

Cheers
/Ilias
> 
> Best regards
> 
> Heinrich