From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7554BC07E97 for ; Sat, 3 Jul 2021 19:24:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B0476191C for ; Sat, 3 Jul 2021 19:24:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B0476191C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4DD7582903; Sat, 3 Jul 2021 21:24:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="rFNvNdyP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 20ACC829BA; Sat, 3 Jul 2021 21:24:37 +0200 (CEST) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4FAF18074A for ; Sat, 3 Jul 2021 21:24:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x32b.google.com with SMTP id g10so2850285wmh.2 for ; Sat, 03 Jul 2021 12:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iXFyAQ+QYa/Y58Jf/VWUwVqn77R3bdH3SUOtTy8GkCE=; b=rFNvNdyPJ6NgmFjqH1byssJzh/l/bZM7vP0UWo1VXxiut18JhfMhrwuqfWlJhUobxR AfjiQneo3yJnspa2CQpLlAPT1X7ujiV3j/3BLdq1MiR2OeZcabLsOJgreZemZoFbaxa0 r64tlSGw1KTGd7eBtXi/oGZNGzg6Eqdku+10k9oofZYfX4rR40zvfDQ64z1mgF+O4bDZ ZUKYxLMm9yzj4TYgOJBkNVLImdMcwBslFA+dSi3XjuDOYXxCpoy7+yyt7gt/DMcUnzTk /7wWqfx1YsvG5UDfxDQ7ZEeSO1+2xMJx3zP7lukwkdbdkzhwyDVM2P6wNfhYcAUDUGkX 3nAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iXFyAQ+QYa/Y58Jf/VWUwVqn77R3bdH3SUOtTy8GkCE=; b=ZbKVHcGT9dxOcWXRNzMjz6B4poZTmQgRCC+HzsOo7ekgOPjnuV22cHkA0WqQFq7mqu Ob7iCYrjGHO+ep/cuP/t6mz0HcdeZxOaaTvZ+TLCGlcxr0MaUynAlH+UqVRUl004IHyl tTITq/WNm6+W178auE3WYdse/Ju/+vBs9dABJidbcxiYoLKhh0jOj+EsydDT7xQ4wYoh Y+aGbXWN7PGx8E3XtdsRTFfqNQjBCCyzy7ngHfDl3PeRPyIhw9SHLRP4wiIZAU0tfocq 9VFke9iCgsv6bTYoTyRh7sBKc9qg09A8AocyOrw3vqYLN5umuA2PGuFllerbcUoNh2eO awpw== X-Gm-Message-State: AOAM532BTYm+PHfNCgHEPGRXvnuSO+AB0N6v1zAZXP0UOvrJtVrObaBb TttMFMatmlH/56kiS+DkgHFA2g== X-Google-Smtp-Source: ABdhPJwv+0DKOZs7TP7UBpscFpMoW97hDvlbd4OP5naYNn6fo3JqTY9mMJKFclHena9hz4lEzvb4zw== X-Received: by 2002:a1c:26c2:: with SMTP id m185mr6420343wmm.146.1625340273871; Sat, 03 Jul 2021 12:24:33 -0700 (PDT) Received: from enceladus (ppp-94-66-242-227.home.otenet.gr. [94.66.242.227]) by smtp.gmail.com with ESMTPSA id o11sm6715528wmq.1.2021.07.03.12.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jul 2021 12:24:33 -0700 (PDT) Date: Sat, 3 Jul 2021 22:24:30 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: Da Xue , Tom Rini , U-Boot Mailing List , Alexander Graf , Adarsh Babu Kalepalli Subject: Re: Pull request for efi-2021-07-rc5-2 Message-ID: References: <83a286bc-b7c3-4ca8-02a8-60746b7f512e@gmx.de> <20210630120617.GD9516@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > > >EFI stub: Booting Linux Kernel... [...] > > >EFI stub: Using DTB from configuration table > > >... > > >[?? ?? 0.000000] Linux version 5.10.45 (dxue@build-server) > > >(aarch64-buildroot-linux-musl-gcc.br_real (Buildroot > > >2019.08-10705-g7cb51d4843-dirty) 10.3.0, GNU ld (GNU Binutils) 2.36.1) > > >#21 > > >[?? ?? 0.000000] Machine model: Libre Computer AML-S805X-AC > > >... > > >[?? ?? 0.000000] efi: ESRT=0x3aeea040 RTPROP=0x3aee8040 > > SMBIOS=0x3aee4000 > > >RNG=0x394ee040 MEMRESERVE=0x394ed040 > > > > > >/sys/firmware/devicetree/base/smbios/smbios # grep -r . * > > >baseboard/manufacturer:libre-computer > > >baseboard/product:aml-s805x-ac > > >baseboard/name:baseboard > > >chassis/manufacturer:libre-computer > > >chassis/product:aml-s805x-ac > > >chassis/name:chassis > > > > This matces the device tree segment below. > > > > >name:smbios > > >system/manufacturer:libre-computer > > >system/product:aml-s805x-ac > > >system/name:system > > >/sys/firmware/devicetree/base/smbios/smbios # cd > > >/sys/devices/virtual/dmi/id > > >/sys/devices/virtual/dmi/id # grep -r . * > > >bios_date:07/03/2021 > > >bios_release:21.7 > > >bios_vendor:U-Boot > > >bios_version:2021.07-rc5+ > > >board_name:Unknown Product > > >board_vendor:Unknown > > >chassis_type:3 > > >chassis_vendor:Unknown > > > > All that is marked unknown is not in your device-tree below. > > > > What are you expecting here? > > Was it here before the pull request? > > > > Best regards > > > > Heinrich > > > > >modalias:dmi:bvnU-Boot:bvr2021.07-rc5+:bd07/03/2021:br21.7:svnUnknown:pnUnknownProduct:pvr:rvnUnknown:rnUnknownProduct:rvr:cvnUnknown:ct3:cvr: > > >power/runtime_active_time:0 > > >power/runtime_status:unsupported > > >power/runtime_suspended_time:0 > > >power/control:auto > > >product_name:Unknown Product > > >sys_vendor:Unknown > > >uevent:MODALIAS=dmi:bvnU-Boot:bvr2021.07-rc5+:bd07/03/2021:br21.7:svnUnknown:pnUnknownProduct:pvr:rvnUnknown:rnUnknownProduct:rvr:cvnUnknown:ct3:cvr: > > > > > >diff --git a/arch/arm/dts/meson-gxl-s805x-libretech-ac-u-boot.dtsi > > >b/arch/arm/dts/meson-gxl-s805x-libretech-ac-u-boot.dtsi > > >index 39270ea71c..02177c64a6 100644 > > >--- a/arch/arm/dts/meson-gxl-s805x-libretech-ac-u-boot.dtsi > > >+++ b/arch/arm/dts/meson-gxl-s805x-libretech-ac-u-boot.dtsi > > >@@ -5,3 +5,26 @@ > > >?? */ > > > > > > #include "meson-gxl-u-boot.dtsi" > > >+ > > >+/ { > > >+?? ?? ?? ??smbios { > > >+?? ?? ?? ?? ?? ?? ?? ??compatible = "u-boot,sysinfo-smbios"; > > >+ > > >+?? ?? ?? ?? ?? ?? ?? ??smbios { > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??system { > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??manufacturer = "libre-computer"; > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??product = "aml-s805x-ac"; > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??}; > > >+ > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??baseboard { > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??manufacturer = "libre-computer"; > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??product = "aml-s805x-ac"; > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??}; > > >+ > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??chassis { > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??manufacturer = "libre-computer"; > > >+?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??}; > > >+?? ?? ?? ?? ?? ?? ?? ??}; > > >+?? ?? ?? ??}; > > >+}; > > > > > >Any ideas? > > > > > >Best, > > >Da > > > > There's two issues: > > > > 1) I just saw this patch: "x86: Provide default SMBIOS > > manufacturer/product". Should we add the same thing for ARM or maybe > > generically across the board? > > > > 2) The DMI entries previously took CONFIG_SYS_VENDOR and > > CONFIG_SYS_BOARD entries as manufacturer and product respectively. Now > > those entries become Unknown and Unknown Product. Which version was that? My patch changed nothing in that regard. The only thing my patch did was fix e4f8e543f1a9 which removed some Kconfig options. Removing those made the strings "" which is against the spec. Heinrich fixed a similar issue with 00a871d34e2f back when we had CONFIG_SMBIOS_MANUFACTURER and CONFIG_SMBIOS_PRODUCT_NAME. Any chance that was your working version and those values were used? > > Having file smbios.dtsi in an x86 specific path (arch/x86/dts/) does not > make much sense. There is nothing architecture specific in it. > > Maybe where Ilias now has filled the missing properties with 'Unknown' > he should have opted for CONFIG_SYS* instead if available. This would > make smbios.dtsi superfluous. We discussed this with Simon and I'll send a follow up patch. The idea is to try and use CONFIG_SYS* and if those are not available, pop a warning and use Unknown Cheers /Ilias > > Best regards > > Heinrich