Re: Pull request for efi-2021-07-rc5-2

[Ilias Apalodimas <ilias.apalodimas@linaro.org>]

> 
[...]
> commit 44ffb6f0ecaf ("smbios: Allow properties to come from the device
> tree") still used CONFIG symbols.
> 
> commit e4f8e543f1a9 ("smbios: Drop the unused Kconfig options") dropped
> the CONFIG symbols

Exactly, that was the point I tried to make.  I think whatever Da was seing
on his entires as 'correct' was prior to e4f8e543f1a9.

Cheers
/Ilias

> 
> Best regards
> 
> Heinrich
> 
> > The only thing my patch did was fix e4f8e543f1a9 which removed some Kconfig
> > options. Removing those made the strings "" which is against the spec.
> > Heinrich fixed a similar issue with 00a871d34e2f back when we had
> > CONFIG_SMBIOS_MANUFACTURER and CONFIG_SMBIOS_PRODUCT_NAME. Any chance that
> > was your working version and those values were used?
> > 
> > > 
> > > Having file smbios.dtsi in an x86 specific path (arch/x86/dts/) does not
> > > make much sense. There is nothing architecture specific in it.
> > > 
> > > Maybe where Ilias now has filled the missing properties with 'Unknown'
> > > he should have opted for CONFIG_SYS* instead if available. This would
> > > make smbios.dtsi superfluous.
> > 
> > We discussed this with Simon and I'll send a follow up patch. The idea is to
> > try and use CONFIG_SYS* and if those are not available, pop a warning and use
> > Unknown
> > 
> > Cheers
> > /Ilias
> > > 
> > > Best regards
> > > 
> > > Heinrich
>