From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C034C07E98 for ; Mon, 5 Jul 2021 05:56:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64F9461370 for ; Mon, 5 Jul 2021 05:56:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64F9461370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5418E8033E; Mon, 5 Jul 2021 07:56:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="kC6pZHcn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DB01B82B30; Mon, 5 Jul 2021 07:56:13 +0200 (CEST) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 591F48033E for ; Mon, 5 Jul 2021 07:56:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x433.google.com with SMTP id p8so20546292wrr.1 for ; Sun, 04 Jul 2021 22:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EEGWe/hqw/h/KdlWkrB/7eYA5oYEeyJbMIm6aoRr7f8=; b=kC6pZHcnWVTDR/up4saBuw4YLYhpeX0pwKBeIFeWBdRSpNFnQai9jmKr30gaznsWBJ 9LXqKw2bUU+ajv7nuI53jPVii6sQjqXX6ZrVstQmzPdQ7ZQJFXss3i7I+IquZyGao51i ALxAPOEdEJJ6O0cdbsotrHRjZMexA6s8QQ1jAjVVNNhgE5BRjIHarrRC7YIEiSsabAcE ffOraxvvHTN6Ocbgfw7d2Gmq0YmvFk6OEYBdzZ1YwAyedZuISVjthxDi+l6H0Mp8YJ5Y /PTtNDT7TFCe/PNodnP9cUGtuYjrj+CPqBilbp0LAlsh4dEGzi9MXndMewCd71NbzS39 4Aag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EEGWe/hqw/h/KdlWkrB/7eYA5oYEeyJbMIm6aoRr7f8=; b=J8azKKsE7kSQzMoubSMAjANy7nzXFxPD+oUai1UARHIrRIweHoRu3VIsGZ0Odb8OLI LkRMXq6VRQ3yKKK6Pm33SAaY5xdOYhBeJTeljOKpn+0nf0nY6G4/LJiQGaCE3wSn8+db y+tVTkhvhpvy9lqoWc6ImYvEXxOg3DthVEaIUV4SByZyOXf7axHq5klMf0MgCfnKeYwW 6Q47mgJum6dPex9JSwxMGMIpgUt1vAVAyUlMj+j9aFbGcH4OT10hchrGXCT9tKSkd3Xg RJ7XCynTuxko9cn7LHezVOg8WQqj9h0N7jkzpG26TFmU9vIHlqDZcM5P4FMnHZD5I44x Psag== X-Gm-Message-State: AOAM533lvtbS0k3JsEdmLrA1HEbpNS5LjQN93xfx8NQQbJSkS0h1hHwT 0O6G+Ew0yf75POERnUWG1EdmKg== X-Google-Smtp-Source: ABdhPJzMHsA23Yb6lP3J8C7kUoLJF1xY1NYw+TalFf8lIJ/HhIhLJeS6s1kppLGOBm6CPuizwClMkQ== X-Received: by 2002:a5d:4ac6:: with SMTP id y6mr13493225wrs.347.1625464570948; Sun, 04 Jul 2021 22:56:10 -0700 (PDT) Received: from enceladus (ppp-94-66-242-227.home.otenet.gr. [94.66.242.227]) by smtp.gmail.com with ESMTPSA id l34sm23292916wms.45.2021.07.04.22.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jul 2021 22:56:10 -0700 (PDT) Date: Mon, 5 Jul 2021 08:56:08 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: Da Xue , Tom Rini , U-Boot Mailing List , Alexander Graf , Adarsh Babu Kalepalli , Simon Glass Subject: Re: Pull request for efi-2021-07-rc5-2 Message-ID: References: <83a286bc-b7c3-4ca8-02a8-60746b7f512e@gmx.de> <20210630120617.GD9516@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > [...] > commit 44ffb6f0ecaf ("smbios: Allow properties to come from the device > tree") still used CONFIG symbols. > > commit e4f8e543f1a9 ("smbios: Drop the unused Kconfig options") dropped > the CONFIG symbols Exactly, that was the point I tried to make. I think whatever Da was seing on his entires as 'correct' was prior to e4f8e543f1a9. Cheers /Ilias > > Best regards > > Heinrich > > > The only thing my patch did was fix e4f8e543f1a9 which removed some Kconfig > > options. Removing those made the strings "" which is against the spec. > > Heinrich fixed a similar issue with 00a871d34e2f back when we had > > CONFIG_SMBIOS_MANUFACTURER and CONFIG_SMBIOS_PRODUCT_NAME. Any chance that > > was your working version and those values were used? > > > > > > > > Having file smbios.dtsi in an x86 specific path (arch/x86/dts/) does not > > > make much sense. There is nothing architecture specific in it. > > > > > > Maybe where Ilias now has filled the missing properties with 'Unknown' > > > he should have opted for CONFIG_SYS* instead if available. This would > > > make smbios.dtsi superfluous. > > > > We discussed this with Simon and I'll send a follow up patch. The idea is to > > try and use CONFIG_SYS* and if those are not available, pop a warning and use > > Unknown > > > > Cheers > > /Ilias > > > > > > Best regards > > > > > > Heinrich >