From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F976C07E95 for ; Wed, 7 Jul 2021 17:40:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0BD461CC2 for ; Wed, 7 Jul 2021 17:40:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0BD461CC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 22D998311B; Wed, 7 Jul 2021 19:40:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="s9FrOZ7L"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 35AD28311C; Wed, 7 Jul 2021 19:40:24 +0200 (CEST) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8DCEF8311B for ; Wed, 7 Jul 2021 19:40:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x42d.google.com with SMTP id q17so4022316wrv.2 for ; Wed, 07 Jul 2021 10:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HGm6VOKgCuW6ddVkgBHTs+v9tTCnfxM+7kb9mpE1dgY=; b=s9FrOZ7L1Wg72exQlaRm1oc9gljjPsIBPnOfZa2TkXfJyMknLIhF5nGMCPSSwOwctn GcNn5EIQ0f+3j6HEVCCvS1AZMZxj1pH76rqQp41SO1hO9FOtGeUEVozg6oS07MLpCAsJ kZO9ZYmgzd9RM6Yn3dfj1Eu0urkoJWrqPnzjHrNxbtR0sizi6F311638BlI4s2y4IXLz ShFwL4B1fCUZT3y+ldHXdaNb+Tp2PxDUgcwubf+zsCL/gtY2x3FMNaXHPby806yEmfV5 SwwkO4BRnrFJMF4eKEjXGKJYmKT+bqHsl2Net4rBS8QFJLBOrlI0VqXssG5Dk8HOgdn9 fPiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HGm6VOKgCuW6ddVkgBHTs+v9tTCnfxM+7kb9mpE1dgY=; b=BF6lv6i83iqVF77e//8zpqap9u0uuXC6HM59GyAFY0owhP1L1M88bQ7MMesj9Y28S3 P9XRWsQkw2mwHiXU/9YwAl0gBzq7EurrFAI6RsDK6wXqHjvDoN2XN5tsKJtwFAvkQ294 ALFT8j6tQcYxhuMOP0IFom2tGiTbxSsj/S1VVeejI2manR2djhsC7EMWdlW241V4Me4y lXRyNNq+uXhbbnefqnqwh1iSGmSn606EqSi+onNwcYIDB31D1wQXSvXEiGImn1SPsuNx nbJUmpq7dS4tLQvOIcCylU37YAvzH3kHtT1Eosh5PEHMp3soyvQvhpKDWeqT1gBtJUu1 d8Uw== X-Gm-Message-State: AOAM533uO573VtUOh28xEEcfqB4S+uT5Hafm2cxLKynBvD0KGvchlFZn MAiBMz3je4ab9r5YrCLD2EvpJg== X-Google-Smtp-Source: ABdhPJwYyM9dHSr67AqDdHP35ceGZ73XHXg3pa6WI5d6/xwmFHOpmXwJQ4qxOZpn94erWJwT/f8JMA== X-Received: by 2002:a5d:6982:: with SMTP id g2mr8663473wru.119.1625679621121; Wed, 07 Jul 2021 10:40:21 -0700 (PDT) Received: from enceladus (ppp-94-66-242-227.home.otenet.gr. [94.66.242.227]) by smtp.gmail.com with ESMTPSA id p9sm20609280wrx.59.2021.07.07.10.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 10:40:20 -0700 (PDT) Date: Wed, 7 Jul 2021 20:40:18 +0300 From: Ilias Apalodimas To: Simon Glass Cc: Masahisa Kojima , Heinrich Schuchardt , Alexander Graf , Dhananjay Phadke , U-Boot Mailing List Subject: Re: [PATCH 2/5] efi_loader: add secure boot variable measurement Message-ID: References: <20210707133638.12630-1-masahisa.kojima@linaro.org> <20210707133638.12630-3-masahisa.kojima@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Wed, Jul 07, 2021 at 11:37:01AM -0600, Simon Glass wrote: > Hi Masahisa, > > On Wed, 7 Jul 2021 at 07:36, Masahisa Kojima wrote: > > > > TCG PC Client PFP spec requires to measure the secure > > boot policy before validating the UEFI image. > > This commit adds the secure boot variable measurement > > of "SecureBoot", "PK", "KEK", "db" and "dbx". > > > > Note that this implementation assumes that secure boot > > variables are pre-configured and not be set/updated in runtime. > > > > Signed-off-by: Masahisa Kojima > > --- > > include/efi_tcg2.h | 20 ++++++ > > lib/efi_loader/efi_tcg2.c | 135 ++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 155 insertions(+) > > Where are the tests for this code, please? As we discussed in the past, the EFI TCG code can't be tested with the asndbox as-is. I'll have a look on your sandbox patches in case we can now use those, but in any case, I've sent a TPM mmio based driver. Even if the sandbox is still not enough we can add tests once the mmio TPM driver gets merged Cheers /Ilias > > Regards, > Simon