From: Stephan Gerhold <stephan@gerhold.net>
To: dsankouski@gmail.com
Cc: u-boot@lists.denx.de, Ramon Fried <rfried.dev@gmail.com>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 3/6] pinctrl: qcom: add pinctrl and gpio drivers for SDM845 SoC
Date: Fri, 24 Sep 2021 12:48:49 +0200 [thread overview]
Message-ID: <YU2s6EMRdSPRyhJv@gerhold.net> (raw)
In-Reply-To: <20210923185732.7679-4-dsankouski@gmail.com>
Hi,
On Thu, Sep 23, 2021 at 09:57:29PM +0300, dsankouski@gmail.com wrote:
> From: Dzmitry Sankouski <dsankouski@gmail.com>
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> arch/arm/mach-snapdragon/pinctrl-sdm845.c | 44 +++++++++++++++++++
> arch/arm/mach-snapdragon/pinctrl-snapdragon.c | 1 +
> arch/arm/mach-snapdragon/pinctrl-snapdragon.h | 1 +
> drivers/gpio/msm_gpio.c | 1 +
> drivers/gpio/pm8916_gpio.c | 8 ++--
> 5 files changed, 52 insertions(+), 3 deletions(-)
> create mode 100644 arch/arm/mach-snapdragon/pinctrl-sdm845.c
>
> diff --git a/arch/arm/mach-snapdragon/pinctrl-sdm845.c b/arch/arm/mach-snapdragon/pinctrl-sdm845.c
> new file mode 100644
> index 0000000000..6d66582aa6
> --- /dev/null
> +++ b/arch/arm/mach-snapdragon/pinctrl-sdm845.c
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Qualcomm SDM845 pinctrl
> + *
> + * (C) Copyright 2021 Dzmitry Sankouski <dsankouski@gmail.com>
> + *
> + */
> +
> +#include "pinctrl-snapdragon.h"
> +#include <common.h>
> +
> +#define MAX_PIN_NAME_LEN 32
> +static char pin_name[MAX_PIN_NAME_LEN];
Since this is used before relocation (when setting up pinctrl for
serial) you should really add __section(".data") here. I would expect
that you are currently corrupting some random part of your appended DTB
and are just lucky enough this does not cause any crashes. :)
See: https://source.denx.de/u-boot/u-boot/-/commit/548b89f8ad396d238d594f6f6fa1df902b74a303
Thanks,
Stephan
next prev parent reply other threads:[~2021-09-24 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 18:57 [PATCH 0/6] Add support for SDM845 based boards, and SM-G9600 dsankouski
2021-09-23 18:57 ` [PATCH 1/6 v3] serial: qcom: add support for GENI serial driver dsankouski
2021-09-23 18:57 ` [PATCH 2/6 v3] spmi: msm: add arbiter version 5 support dsankouski
2021-10-05 16:53 ` Tom Rini
2021-09-23 18:57 ` [PATCH 3/6] pinctrl: qcom: add pinctrl and gpio drivers for SDM845 SoC dsankouski
2021-09-24 10:48 ` Stephan Gerhold [this message]
2021-09-23 18:57 ` [PATCH 4/6] clocks: qcom: add clocks for SDM845 debug uart dsankouski
2021-09-23 18:57 ` [PATCH 5/6] SoC: qcom: add support for SDM845 dsankouski
2021-09-24 10:55 ` Stephan Gerhold
2021-09-23 18:57 ` [PATCH 6/6 v3] board: samsung: add Samsung Galaxy S9/S9+(SM-G96x0) board dsankouski
2021-09-24 11:02 ` Stephan Gerhold
2021-09-24 14:35 ` Dzmitry Sankouski
2021-09-24 18:50 ` Stephan Gerhold
2021-10-05 16:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU2s6EMRdSPRyhJv@gerhold.net \
--to=stephan@gerhold.net \
--cc=dsankouski@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox