From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0110C433EF for ; Mon, 27 Sep 2021 08:52:34 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A3E460F44 for ; Mon, 27 Sep 2021 08:52:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1A3E460F44 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C8853831BA; Mon, 27 Sep 2021 10:52:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="jbzrL/pf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B2CA78323F; Mon, 27 Sep 2021 10:52:29 +0200 (CEST) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 278E2829FC for ; Mon, 27 Sep 2021 10:52:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x42b.google.com with SMTP id t8so50281620wrq.4 for ; Mon, 27 Sep 2021 01:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Vk8ilpmIO9JSUxCfxljawc31mnGh8RzG6AfW6eZNeMY=; b=jbzrL/pflM4RtXZems0J0jyB4YcXI/yS85i3BA+PzNOJFqErKFODVn1C1+/0X6Vfk/ /JbCvb/7Xot/cP/md92IQZGGgfC4T8frm7tLSeZ6ZLb5JXbTfT/kBKF/DsZDPEFRTCBc 0Yrc+KKJ/Jv39sPR1q6YPm9dqQaAHFPhQK4anv2awEugyTaY0iS7Z3P+toe6E0R87/hh fSUio9KBGOIwDTUFCzoaOlmxOhcVGE+sHVXtac328qO1uKc1Z4viKbygwDV4JdzEpRI/ eVvD8FYbGoPfrFfohhPBTXpcEVt0dIchom3LarrROGlTiy5B9hq7Gv79CbQFhe0JEgnE fEMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Vk8ilpmIO9JSUxCfxljawc31mnGh8RzG6AfW6eZNeMY=; b=Iju1eTBH0c5ob03Tf45c90HZrF42GQeWVYmoHx0GCoZGugLmKVpXhMiTbO35FXpH4o hBa5gmwOxUnUiSs4kRPF2PUfiUPSJf5lnUg7Qsnean5NatbPrx9LmEm2UiYrfCik/ChX X2N+B7rnc4wIWcnV1VEV6dwzps4t3MUsyhACNZ2OBi7kUdJhH1JQamcSuAKu0s6qjVLf scSdNS5G38gkcRnt6YXrMwfaR8P6ehCAbViaIbcvkHwOSy7iXLYGIPeQfMqVjKN+NpYv j980idNBaRj9SoMHiF3eRxcnXECXRg3iJc6GPYSogd31ccnAjUdwdn0eERdRTsMLirdR ENQw== X-Gm-Message-State: AOAM532rHMnGwhdQNARhGcdGEBWMf0Cc6DnYxoCPmUmOOV8nLEkU5Mxq jOruukhyrxkBBnSXwv/tPzwjtQ== X-Google-Smtp-Source: ABdhPJyPXjctPX2mmhZDKGCTpQZ7uY0JzRDw5kR2tb9dVBowOb/Opre36CyBcb9QfOHYE8zdDMJYFg== X-Received: by 2002:a5d:64ca:: with SMTP id f10mr26040238wri.93.1632732745691; Mon, 27 Sep 2021 01:52:25 -0700 (PDT) Received: from apalos.home (ppp-94-66-220-209.home.otenet.gr. [94.66.220.209]) by smtp.gmail.com with ESMTPSA id a3sm15877283wrt.28.2021.09.27.01.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 01:52:25 -0700 (PDT) Date: Mon, 27 Sep 2021 11:52:22 +0300 From: Ilias Apalodimas To: Simon Glass Cc: Masahisa Kojima , U-Boot Mailing List , Heinrich Schuchardt , Alexander Graf , Bin Meng , Christian Gmeiner Subject: Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement Message-ID: References: <20210921071931.3755-1-masahisa.kojima@linaro.org> <20210921071931.3755-2-masahisa.kojima@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, [...] > > > > - remove unnecessary const qualifier from smbios_string() > > > > - create non-const version of next_header() > > > > > > > > include/efi_loader.h | 2 + > > > > include/efi_tcg2.h | 15 ++++ > > > > include/smbios.h | 17 +++- > > > > lib/efi_loader/Kconfig | 1 + > > > > lib/efi_loader/efi_boottime.c | 2 + > > > > lib/efi_loader/efi_smbios.c | 2 - > > > > lib/efi_loader/efi_tcg2.c | 84 +++++++++++++++++++ > > > > lib/smbios-parser.c | 152 +++++++++++++++++++++++++++++++--- > > > > 8 files changed, 261 insertions(+), 14 deletions(-) > > > > > > Where are the tests for this new code, please? > > > > We've mentioned this in the past. The sandbox TPM is very limited wrt > > tpm testing for the EFI TCG protocol. > > So let's add some more features? If it helps, think of the sandbox TPM > as test code, not an emulator. It is a very simple kind of emulator to > allow tests to work. The amount of features needed to test EFI TCG are not minimal. Since I'll upstream the mmio tpm anyway, we'll just test TCG there. If someone wants to go ahead and make the sandbox TPM a TIS compliant device that covers the requirements of the EFI TCG, I am fine using it. > > > I did send TPM MMIO patches a while back [1]. This would allow us to > > test everything under QEMU, but you asked for *another* device to be > > part of the API I posted (apart from the MMIO). I've found some time > > Yes that is because if you just add a new protocol you have not made > anything better, just added one more way of doing things. Our perspective of 'better' seems to be different. I added a TIS API for any driver to use. I actually did 2 iterations of the driver. The first one was replicating all the code and you said 'why are we replicating code', which was done already in a bunch of drivers already... Then I added an API and a driver using it but you wanted to convert more *existing* drivers to the API before merging it. But the fact is that if anyone wants to add a new driver he has to code ~900 lines instead of the ~150 needed with the API in place, not to mention the duplication of bugs all over the place.... > > > and changed the tpm2 spi driver we have, but I can't test it yet, > > since I don't have a device for that. > > OK I think we are both going to get one. > > [..] > > Regards, > SImon Regards /Ilias