From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E797C433EF for ; Fri, 1 Oct 2021 19:47:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CCDA61A58 for ; Fri, 1 Oct 2021 19:47:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2CCDA61A58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 14A3581196; Fri, 1 Oct 2021 21:47:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="KWriJf+N"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F2B9480F9D; Fri, 1 Oct 2021 21:47:17 +0200 (CEST) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4F34C80F9D for ; Fri, 1 Oct 2021 21:47:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x42e.google.com with SMTP id s21so17091885wra.7 for ; Fri, 01 Oct 2021 12:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FNY1qNnUsqyzGWnyelrxOrBKChwkUdNiojokKrUKqpI=; b=KWriJf+NengKCRHQG7tCnWBixqf2fXFzukho0dIuOzupXi+aXThd/aZpndL7li1/nr CDa63PInkVCslvC8plnOuQUxrFRB02SAG+RgWmEzK5dsBUs84SBFawbrvqayPYBrdnoU Bocz3AY2xJxLA+mhnVnhq4pjtVB1d/7zrb2ESgSQfv101jRvP7M6B1Q1SGO9xnD/jIfs hdOWmO7kfvYtO1XLQd+RCmXbzRGqBwsUUOX+PHdXNeNKGNcMjZX5PNrsoq0I+6rmbpFM gzXpXmALSgABEDV8IdPrvKzYUDyVhycYGxImxXUNCevl2ozJjctXmsEvbZjEOfojLqqR eTUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FNY1qNnUsqyzGWnyelrxOrBKChwkUdNiojokKrUKqpI=; b=gjt0VnT94G3rN1nfF19MM+/WKaoykY5XctfJfiAJFatObT76pJt6xXIK1kncccQMaa BJwuPQnKqVj1M1sYs5LiIQx+Xk17IBiLohdip4UrV6lEhKQ92sdpcQRUpc+LzhIEwP5o IjzRMtTfmbQRH3hlTIwcvQzsifbZdA8zCj5ZpAi7XwihOIBu5IPjP3eJFSYQJYiiWpmg vGd4MradCjr3RT2Jx8BdsRx/vkxmGhxTnpUUHCD6BFcGmZZZiTAH6ixsVywexPQ3U8CV YaNHfrid567g+iMe5wLKEACrLUEQwZtKCdV/IUpjhvHAowRZ7nF589CcbAX8BM8gVs0D ywbA== X-Gm-Message-State: AOAM53157eLXNOMQbZcpNn9hY10HkcHhghUj6RQc98kCUIsQDZazdytG r9MgLotRAS1x1R1FIw3O+qfR5A== X-Google-Smtp-Source: ABdhPJwat3sdpIbTDH2+6PW2/hbYanwaAGU+kX0l2elgoyygGrZQa4FC4YwLPoMf/XoTI7DIM0WFlg== X-Received: by 2002:adf:f011:: with SMTP id j17mr14447686wro.320.1633117633803; Fri, 01 Oct 2021 12:47:13 -0700 (PDT) Received: from apalos.home (ppp-94-66-220-209.home.otenet.gr. [94.66.220.209]) by smtp.gmail.com with ESMTPSA id x12sm4922993wmj.38.2021.10.01.12.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 12:47:13 -0700 (PDT) Date: Fri, 1 Oct 2021 22:47:10 +0300 From: Ilias Apalodimas To: Simon Glass Cc: Masahisa Kojima , U-Boot Mailing List , Heinrich Schuchardt , Alexander Graf , Bin Meng , Christian Gmeiner Subject: Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement Message-ID: References: <20211001111844.7422-1-masahisa.kojima@linaro.org> <20211001111844.7422-2-masahisa.kojima@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, [...] > As part of this work, can you or someone else at Linaro please add > tests for the SMBIOS code? > > Also as mentioned in the previous version, we should have tests for > this. Ilias suggested what needs to be added to the sandbox emulator. I pointed out what's missing on the sandbox. Asking for the tests is fine and those will be added, but since the TPM is already working in QEMU, I strongly prefer doing it there. I know you like sandbox and you are trying to promote using it for testing, but imho having it for the TPM is not the best of examples. You are adding code emulating a really complex device. There's *always* going to be missing functionality (not to mention bugs). The EFI TCG tests will ask more and more from the TPM. E.g there's a call for changing the active PCRs which we haven't implemented yet in EFI. We'll have to keep adding complex features to sandbox for every patch? QEMU and it's TPM already work and have all the functionality we'll ever need. In fact this [1] came out from testing on QEMU. So since QEMU and testing is an acceptable way for testing U-Boot, I'll resend my TPM MMIO patchset and we can create the tests there. [1] https://source.denx.de/u-boot/custodians/u-boot-efi/-/commit/346cee3ac5782fefeaeda2b54914b029547adf52 Thanks /Ilias