From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27FAAC433F5 for ; Tue, 19 Oct 2021 12:05:45 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C993610E7 for ; Tue, 19 Oct 2021 12:05:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C993610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6060F82FC5; Tue, 19 Oct 2021 14:05:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Kyy8FX+6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8158380EFB; Tue, 19 Oct 2021 09:56:39 +0200 (CEST) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ED74281197 for ; Tue, 19 Oct 2021 09:56:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x329.google.com with SMTP id n40-20020a05600c3ba800b0030da2439b21so1762737wms.0 for ; Tue, 19 Oct 2021 00:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JCijkpm+MDVEv2aCCE8gcjIEY2wS1dmhV7v4Y14Uno8=; b=Kyy8FX+6Cw1Dg8fZkToGIXV+n9oq1EXKZhye0hsy5AEbd5ryzQJ15rfBJkXJeOhbRM S0Hb6+u6Ib3s7RWKHT0r++1oZR2tjYmZIed///WlWubaSoV1tbolKAiDgvpB5+XvPwzr IFa/JA/heRYfbNKdiOd+hPri8CvS1DoJ151XPaARRDC91T7uSnQppOcZrQrLNOCZrMAS eS1AtbH/sKKzMujBpKHWfn+lgXNo4OHDRuc7GMJ4SVGJEmVd8KSo51UF3W5hC4rYbwDD swibJUDZrgBSYeYkFrgYxSICEpPw2yuTjMYyqXycO5zIjcZljFClK9EwbLVE1VpFrySZ Z3lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JCijkpm+MDVEv2aCCE8gcjIEY2wS1dmhV7v4Y14Uno8=; b=cBXTyA7sg1iJbqF2UYiQ2bC2fvUMLc61g7MGRXkhUtOkaL2L+D+uXBbjcZ/K+4UJ/b KnYHxD9a61t2wPDjKbPL5X5mcluNU+nmNXONt4nCuryIsatEZ3AI/QsX2N9EiZtiZpQ2 mNXzBozbIbT8/GM0NQ0Y8URsuQWuvUfP7vZaTlv6ADzbGVyAhPQmjboVSDJEpnCMhIZ7 JFVM1FBn1ukDo0J8PdjpTNGmY159GtvINeYRSQVVTqCz7mNxzezL4rnr685wnbJKoCB2 L4My5WCU2E6gvSKBFklngaNtgcFKYY7Yxxlm95pFbSuDKTttzsut5MnZJb1gwlsMEMp2 H38w== X-Gm-Message-State: AOAM530glBBs4hdHHBAlqSF/6ntWFr8KejgsHlEmqDo+bwaS4UWsZrO7 6tHq0SMaYTvzBnm+k0kwwDHhQw== X-Google-Smtp-Source: ABdhPJy3tWWgPZ15I93iX7dQ1HExAR5w9KqhYMWspBesKHb6ljgicYWHOSW8Tbbu/UMZg8ll7aRaYw== X-Received: by 2002:a1c:740e:: with SMTP id p14mr4286873wmc.109.1634630191501; Tue, 19 Oct 2021 00:56:31 -0700 (PDT) Received: from apalos.home (ppp-94-66-220-13.home.otenet.gr. [94.66.220.13]) by smtp.gmail.com with ESMTPSA id g2sm14314995wrq.62.2021.10.19.00.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 00:56:30 -0700 (PDT) Date: Tue, 19 Oct 2021 10:56:26 +0300 From: Ilias Apalodimas To: Tom Rini Cc: sjg@chromium.org, Patrick Delaunay , Patrice Chotard , Liviu Dudau , Thomas Fitzsimmons , Matthias Brugger , Michal Simek , Pali =?iso-8859-1?Q?Roh=E1r?= , Marek =?iso-8859-1?Q?Beh=FAn?= , Bin Meng , Heinrich Schuchardt , Stefan Roese , Tim Harvey , Harald Seiler , Sughosh Ganu , Priyanka Jain , Vladimir Oltean , Andre Przywara , Ramon Fried , Nicolas Saenz Julienne , Peter Robinson , "Ivan T. Ivanov" , Marek Szyprowski , Leo Yu-Chi Liang , Zong Li , Sean Anderson , Rick Chen , Green Wan , T Karthik Reddy , Ashok Reddy Soma , Alper Nebi Yasak , AKASHI Takahiro , Wasim Khan , Alexandru Gagniuc , Nandor Han , Steffen Jaeckel , Heiko Schocher , Asherah Connor , u-boot@lists.denx.de, uboot-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v3] sandbox: Remove OF_HOSTFILE Message-ID: References: <20211015084243.285423-1-ilias.apalodimas@linaro.org> <20211018205033.GA3078606@bill-the-cat> <20211019002924.GW7964@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211019002924.GW7964@bill-the-cat> X-Mailman-Approved-At: Tue, 19 Oct 2021 14:05:24 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Oct 18, 2021 at 08:29:24PM -0400, Tom Rini wrote: > On Mon, Oct 18, 2021 at 04:50:33PM -0400, Tom Rini wrote: > > On Fri, Oct 15, 2021 at 11:42:40AM +0300, Ilias Apalodimas wrote: > > > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > > unique and rarely causes confusion, we are better of having simpler > > > config options for the DTB. > > > > > > So let's replace that with the existing OF_BOARD. U-Boot would then > > > have only three config options for the DTB origin. > > > - OF_SEPARATE, build separately from U-Boot > > > - OF_BOARD, board specific way of providing the DTB > > > - OF_EMBED embedded in the u-boot binary(should not be used in production) > > > > > > Signed-off-by: Ilias Apalodimas > > > --- > > > Note that this must be applied on top of > > > https://lore.kernel.org/u-boot/20211011210016.135929-1-ilias.apalodimas@linaro.org/ > > > changes since v2: > > > - Rebased on top of the updated OF_BOARD patchset > > > Changes since v1: > > > - Added internal error value on board_fdt_blob_setup(). Arguably > > > we can just check against NULL and simplify this even more if we > > > don't care about the errno > > > - OF_BOARD is now default for sandbox builds > > > > With the previous series applied, this breaks xilinx_zynq_virt: > > https://source.denx.de/u-boot/u-boot/-/jobs/337428 > > > > I had a little trouble in general getting the board to run locally, even > > without the patches, so I didn't debug further yet. > > Here's another thing, that might be related. The dependency series has > minor size changes, in basically expected platforms and places. This > patch adds tons of size changes on virtually all platforms. That might > provide a clue or two as to what's going on. I'll have a look. What changes here is an extra argument to preserve the errno (which we can get rid of). > Is it the OF_HOSTFILE patch that breaks it? There's one thing this patch changes in functionality. In the new version fdtdec_setup() will return an error if the DTB is not found. Can I reproduce this locally? Thanks! /Ilias > -- > Tom