Re: [PATCH v3] sandbox: Remove OF_HOSTFILE

Tom Rini
2021-10-18T20:51:12Z

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

On Fri, Oct 15, 2021 at 11:42:40AM +0300, Ilias Apalodimas wrote:

> OF_HOSTFILE is used on sandbox configs only. Although it's pretty
> unique and rarely causes confusion, we are better of having simpler
> config options for the DTB.
>
> So let's replace that with the existing OF_BOARD. U-Boot would then
> have only three config options for the DTB origin.
> - OF_SEPARATE, build separately from U-Boot
> - OF_BOARD, board specific way of providing the DTB
> - OF_EMBED embedded in the u-boot binary(should not be used in production)
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
> Note that this must be applied on top of
> https://lore.kernel.org/u-boot/20211011210016.135929-1-ilias.apalodimas@linaro.org/
> changes since v2:
> - Rebased on top of the updated OF_BOARD patchset
> Changes since v1:
> - Added internal error value on board_fdt_blob_setup(). Arguably
> we can just check against NULL and simplify this even more if we
> don't care about the errno
> - OF_BOARD is now default for sandbox builds

With the previous series applied, this breaks xilinx_zynq_virt:
https://source.denx.de/u-boot/u-boot/-/jobs/337428

I had a little trouble in general getting the board to run locally, even
without the patches, so I didn't debug further yet.