From: Leo Liang <ycliang@andestech.com>
To: Nick Hu <nick.hu@sifive.com>
Cc: <u-boot@lists.denx.de>, <rick@andestech.com>,
<greentime.hu@sifive.com>, <zong.li@sifive.com>,
<vincent.chen@sifive.com>
Subject: Re: [PATCH] riscv: Avoid io read/write cause wrong result
Date: Tue, 19 Oct 2021 16:30:15 +0800 [thread overview]
Message-ID: <YW6CF9uJmnLzSdg2@ubuntu02> (raw)
In-Reply-To: <20211018035005.16842-1-nick.hu@sifive.com>
On Mon, Oct 18, 2021 at 11:50:05AM +0800, Nick Hu wrote:
> io read/write may cause wrong result because they may read/write data
> from/to register instead of memory. Add 'volatile' to avoid it.
>
> Signed-off-by: Nick Hu <nick.hu@sifive.com>
> ---
> arch/riscv/include/asm/io.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2021-10-19 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 3:50 [PATCH] riscv: Avoid io read/write cause wrong result Nick Hu
2021-10-19 8:30 ` Leo Liang [this message]
2021-10-19 8:59 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW6CF9uJmnLzSdg2@ubuntu02 \
--to=ycliang@andestech.com \
--cc=greentime.hu@sifive.com \
--cc=nick.hu@sifive.com \
--cc=rick@andestech.com \
--cc=u-boot@lists.denx.de \
--cc=vincent.chen@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox