From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1D5C433EF for ; Tue, 19 Oct 2021 12:06:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCAB76113B for ; Tue, 19 Oct 2021 12:06:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CCAB76113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 53ADA83195; Tue, 19 Oct 2021 14:05:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="IktIWJ5C"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BEA2D81F0D; Tue, 19 Oct 2021 13:17:12 +0200 (CEST) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0FCDB82DF6 for ; Tue, 19 Oct 2021 13:17:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x52f.google.com with SMTP id d3so11627661edp.3 for ; Tue, 19 Oct 2021 04:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PhyxchF7/J3efrYGZ7+wUBePuJ814MLwUDzTwQOHnFQ=; b=IktIWJ5C66t+VdFw4pZGJQaEoLsqykCCbT5U1URx6cva4/adltnRobq+bnG8yzNC5M DVhpa+zoF2K2crSEPf2bAnEvu9ShCGyrQaX6NnAHgkS5Bek75fgH6UWvxwzPJhUve2eW cDL3UBsGQZ145eNP/9NZEzGrj/rjuqzgxGPRNoeMD641mqSr8Pw2MHLVKsaUilE4pVnB ToBNSYhbXPfyZC13A0FfQX251DRizQ75HpJ7MU4rz62pd8SQpfX0MhqkJwxjcaHb6hOS DFYu9Z6I2dwIHXZmn9AhK6WROCXbEjhRNg5xS5gMXTl6BQMcOqi+ndykULsstEx8kNYu HH9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PhyxchF7/J3efrYGZ7+wUBePuJ814MLwUDzTwQOHnFQ=; b=BhdWjK9dGPUDiYm2iLr6jxy3AARwlOrBjJwW0mG+omyz6b1V9D/S2B6IBkOGhAHPgU PsBSkX0iwOdzWbGzVVBoNR2QkwUACqZOqHgZhdGYK2WIMkAyfxokNSV9yWFI3ed8Scej 0S7tb5dFG1t0jaMmBIz76Wl1bKai1M71hiQXPRzvSPPMjO7jLf0W1hKhOHQDPkZeS51D KvrCuGj6LlqzgKq7dIPbfIdcsNzclQ2m4nBWTTbKb7bsQqfhVAPIxOPHCKMv5Kw2W8oD KiuIZCI2Qt1KDcJwvpYUnI+ZFFrqVt+7A6Y1MxeimCy7tNJleAu7I7KIvYW7idrMs/93 B2bg== X-Gm-Message-State: AOAM533UUvuKFhuthWP05ZSvqsRPBo0L7gtVlgEhn01oOMuJNdsfTF8+ 1aV1LiIf8PZgPV6VYCTruPiLcw== X-Google-Smtp-Source: ABdhPJwPH1UcqULScfiE7asflEIPJ/2HSh2U6je+OV1+eKm+1khQpQPJB0Eg/1S+rupEeGhh4Q8w4Q== X-Received: by 2002:aa7:d29a:: with SMTP id w26mr2069156edq.96.1634642217139; Tue, 19 Oct 2021 04:16:57 -0700 (PDT) Received: from apalos.home (ppp-94-66-220-13.home.otenet.gr. [94.66.220.13]) by smtp.gmail.com with ESMTPSA id f12sm11797863edx.90.2021.10.19.04.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 04:16:56 -0700 (PDT) Date: Tue, 19 Oct 2021 14:16:52 +0300 From: Ilias Apalodimas To: Tom Rini Cc: sjg@chromium.org, Patrick Delaunay , Patrice Chotard , Liviu Dudau , Thomas Fitzsimmons , Matthias Brugger , Michal Simek , Pali =?iso-8859-1?Q?Roh=E1r?= , Marek =?iso-8859-1?Q?Beh=FAn?= , Bin Meng , Heinrich Schuchardt , Stefan Roese , Tim Harvey , Harald Seiler , Sughosh Ganu , Priyanka Jain , Vladimir Oltean , Andre Przywara , Ramon Fried , Nicolas Saenz Julienne , Peter Robinson , "Ivan T. Ivanov" , Marek Szyprowski , Leo Yu-Chi Liang , Zong Li , Sean Anderson , Rick Chen , Green Wan , T Karthik Reddy , Ashok Reddy Soma , Alper Nebi Yasak , AKASHI Takahiro , Wasim Khan , Alexandru Gagniuc , Nandor Han , Steffen Jaeckel , Heiko Schocher , Asherah Connor , u-boot@lists.denx.de, uboot-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v3] sandbox: Remove OF_HOSTFILE Message-ID: References: <20211015084243.285423-1-ilias.apalodimas@linaro.org> <20211018205033.GA3078606@bill-the-cat> <20211019002924.GW7964@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Tue, 19 Oct 2021 14:05:24 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Oct 19, 2021 at 10:56:26AM +0300, Ilias Apalodimas wrote: > On Mon, Oct 18, 2021 at 08:29:24PM -0400, Tom Rini wrote: > > On Mon, Oct 18, 2021 at 04:50:33PM -0400, Tom Rini wrote: > > > On Fri, Oct 15, 2021 at 11:42:40AM +0300, Ilias Apalodimas wrote: > > > > > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > > > unique and rarely causes confusion, we are better of having simpler > > > > config options for the DTB. > > > > > > > > So let's replace that with the existing OF_BOARD. U-Boot would then > > > > have only three config options for the DTB origin. > > > > - OF_SEPARATE, build separately from U-Boot > > > > - OF_BOARD, board specific way of providing the DTB > > > > - OF_EMBED embedded in the u-boot binary(should not be used in production) > > > > > > > > Signed-off-by: Ilias Apalodimas > > > > --- > > > > Note that this must be applied on top of > > > > https://lore.kernel.org/u-boot/20211011210016.135929-1-ilias.apalodimas@linaro.org/ > > > > changes since v2: > > > > - Rebased on top of the updated OF_BOARD patchset > > > > Changes since v1: > > > > - Added internal error value on board_fdt_blob_setup(). Arguably > > > > we can just check against NULL and simplify this even more if we > > > > don't care about the errno > > > > - OF_BOARD is now default for sandbox builds > > > > > > With the previous series applied, this breaks xilinx_zynq_virt: > > > https://source.denx.de/u-boot/u-boot/-/jobs/337428 > > > > > > I had a little trouble in general getting the board to run locally, even > > > without the patches, so I didn't debug further yet. > > > > Here's another thing, that might be related. The dependency series has > > minor size changes, in basically expected platforms and places. This > > patch adds tons of size changes on virtually all platforms. That might > > provide a clue or two as to what's going on. > > I'll have a look. What changes here is an extra argument to preserve the > errno (which we can get rid of). > > > > > Is it the OF_HOSTFILE patch that breaks it? There's one thing this patch > changes in functionality. In the new version fdtdec_setup() will return an > error if the DTB is not found. > Can I reproduce this locally? Right, I did find a way to reproduce it locally. It's indeed the change in fdtdec_setup() that break this platform. Specifically board_fdt_blob_setup() in board/xilinx/common/board.c will return -ENXIO if the DTB is not found. Apparently that's ok for this platform so returning 0 there fixes the boot. It's also another reason why we need the errno instead of just checking the pointer .... Want me to send a v4 of the OF_HOSTFILE version? Cheers /Ilias