From: "Vincent Stehlé" <vincent.stehle@arm.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: xypron.glpk@gmx.de, ardb@kernel.org,
Alexander Graf <agraf@csgraf.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH] efi_loader: Fix loaded image alignment
Date: Tue, 12 Oct 2021 11:45:07 +0200 [thread overview]
Message-ID: <YWVQRlBXPiVvHX1P@debian> (raw)
In-Reply-To: <20211011121023.110372-1-ilias.apalodimas@linaro.org>
On Mon, Oct 11, 2021 at 03:10:23PM +0300, Ilias Apalodimas wrote:
> We are ignoring the alignment communicated via the PE/COFF header.
> Starting 5.10 the Linux kernel will loudly complain about it. For more
> details look at [1] (in linux kernel).
>
> So add a function that can allocate aligned EFI memory and use it for our
> relocated loaded image.
Hi Ilias,
Thank you for this fix.
I verified that Linux v5.14.3 EFI stub complains about not being aligned to 64k
without this fix and is happy with it, on the following systems:
- qemu with U-Boot latest (after v2021.10)
- Pine64 ROCKPro64 with U-Boot "near" v2021.07[1]
- Lenovo Leez P710 with U-Boot v2021.07[2]
- Compulab IOT-GATE-iMX8 with U-Boot "near" v2021.10-rc3[3]
Feel free to add (or not):
Tested-by: Vincent Stehlé <vincent.stehle@arm.com>
Best regards,
Vincent Stehlé
System Architect - Arm
[1]: https://gitlab.arm.com/systemready/firmware-build/rk3399-manifest/-/blob/rockpro64-21.09/README.md
[2]: https://gitlab.arm.com/systemready/firmware-build/rk3399-manifest/-/blob/leez-21.08/README.md
[3]: https://git.linaro.org/people/paul.liu/systemready/build-scripts.git/tree/docs/iotgateimx8_building_running.md
prev parent reply other threads:[~2021-10-12 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 12:10 [PATCH] efi_loader: Fix loaded image alignment Ilias Apalodimas
2021-10-11 13:45 ` Heinrich Schuchardt
2021-10-11 13:50 ` Ilias Apalodimas
2021-10-11 14:07 ` Ard Biesheuvel
2021-10-11 14:19 ` Ilias Apalodimas
2021-10-12 9:45 ` Vincent Stehlé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWVQRlBXPiVvHX1P@debian \
--to=vincent.stehle@arm.com \
--cc=agraf@csgraf.de \
--cc=ardb@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox