From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95736C433F5 for ; Thu, 11 Nov 2021 14:45:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2ADF61212 for ; Thu, 11 Nov 2021 14:45:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2ADF61212 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 331FC8374A; Thu, 11 Nov 2021 15:45:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E291083A22; Thu, 11 Nov 2021 15:45:49 +0100 (CET) Received: from pwildt.genua.de (pwildt.genua.de [IPv6:2001:1438:2012:c000::a049]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D2EE68374A for ; Thu, 11 Nov 2021 15:45:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrick@blueri.se Received: from lx2k.blueri.se (pc19f8628.dip0.t-ipconnect.de [193.159.134.40]) by pwildt.genua.de (OpenSMTPD) with ESMTPSA id 45d5a828 (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Thu, 11 Nov 2021 15:45:45 +0100 (CET) Date: Thu, 11 Nov 2021 15:45:44 +0100 From: Patrick Wildt To: "Peng Fan (OSS)" Cc: sbabic@denx.de, festevam@gmail.com, u-boot@lists.denx.de, uboot-imx@nxp.com, Peng Fan Subject: Re: [PATCH V3 2/5] imx: imx8mq_phanbell: switch to binman Message-ID: References: <20211022024220.23584-1-peng.fan@oss.nxp.com> <20211022024220.23584-3-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211022024220.23584-3-peng.fan@oss.nxp.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Oct 22, 2021 at 10:42:17AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Switch to binman to pack images Reviewed-by: Patrick Wildt > Signed-off-by: Peng Fan > --- > arch/arm/dts/imx8mq-phanbell-u-boot.dtsi | 2 ++ > arch/arm/mach-imx/imx8m/Kconfig | 7 ++++--- > board/google/imx8mq_phanbell/Kconfig | 2 +- > board/google/imx8mq_phanbell/imximage.cfg | 11 +++++++++++ > configs/imx8mq_phanbell_defconfig | 2 +- > 5 files changed, 19 insertions(+), 5 deletions(-) > create mode 100644 board/google/imx8mq_phanbell/imximage.cfg > > diff --git a/arch/arm/dts/imx8mq-phanbell-u-boot.dtsi b/arch/arm/dts/imx8mq-phanbell-u-boot.dtsi > index 4712cf6a44..a65a942ee7 100644 > --- a/arch/arm/dts/imx8mq-phanbell-u-boot.dtsi > +++ b/arch/arm/dts/imx8mq-phanbell-u-boot.dtsi > @@ -1,5 +1,7 @@ > // SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +#include "imx8mq-u-boot.dtsi" > + > ®_usdhc2_vmmc { > u-boot,off-on-delay-us = <20000>; > }; > diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig > index c556e712b7..b453e5a7da 100644 > --- a/arch/arm/mach-imx/imx8m/Kconfig > +++ b/arch/arm/mach-imx/imx8m/Kconfig > @@ -41,9 +41,10 @@ config TARGET_IMX8MQ_EVK > select IMX8M_LPDDR4 > > config TARGET_IMX8MQ_PHANBELL > - bool "imx8mq_phanbell" > - select IMX8MQ > - select IMX8M_LPDDR4 > + bool "imx8mq_phanbell" > + select BINMAN > + select IMX8MQ > + select IMX8M_LPDDR4 > > config TARGET_IMX8MM_EVK > bool "imx8mm LPDDR4 EVK board" > diff --git a/board/google/imx8mq_phanbell/Kconfig b/board/google/imx8mq_phanbell/Kconfig > index 54cfb99952..e59b03cb17 100644 > --- a/board/google/imx8mq_phanbell/Kconfig > +++ b/board/google/imx8mq_phanbell/Kconfig > @@ -10,6 +10,6 @@ config SYS_CONFIG_NAME > default "imx8mq_phanbell" > > config IMX_CONFIG > - default "arch/arm/mach-imx/imx8m/imximage.cfg" > + default "board/google/imx8mq_phanbell/imximage.cfg" > > endif > diff --git a/board/google/imx8mq_phanbell/imximage.cfg b/board/google/imx8mq_phanbell/imximage.cfg > new file mode 100644 > index 0000000000..74f12b30d2 > --- /dev/null > +++ b/board/google/imx8mq_phanbell/imximage.cfg > @@ -0,0 +1,11 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Copyright 2021 NXP > + */ > + > +#define __ASSEMBLY__ > + > +FIT > +BOOT_FROM sd > +SIGNED_HDMI signed_hdmi.bin > +LOADER mkimage.flash.mkimage 0x7e1000 > diff --git a/configs/imx8mq_phanbell_defconfig b/configs/imx8mq_phanbell_defconfig > index 911c3391db..a8eab85b4a 100644 > --- a/configs/imx8mq_phanbell_defconfig > +++ b/configs/imx8mq_phanbell_defconfig > @@ -18,7 +18,7 @@ CONFIG_SYS_LOAD_ADDR=0x40480000 > CONFIG_FIT=y > CONFIG_FIT_EXTERNAL_OFFSET=0x3000 > CONFIG_SPL_LOAD_FIT=y > -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" > +# CONFIG_USE_SPL_FIT_GENERATOR is not set > CONFIG_SD_BOOT=y > CONFIG_BOARD_EARLY_INIT_F=y > CONFIG_SPL_BOARD_INIT=y > -- > 2.30.0 >