From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E769AC433F5 for ; Fri, 19 Nov 2021 20:56:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C7CF082A65; Fri, 19 Nov 2021 21:56:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gerhold.net header.i=@gerhold.net header.b="tFQvuKlK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 55E1382A65; Fri, 19 Nov 2021 21:56:07 +0100 (CET) Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5633A812BB for ; Fri, 19 Nov 2021 21:56:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=stephan@gerhold.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1637355362; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=tzxOl6yLmqH96VY+d9gLiOVnDURCNdMNAmgEtRvEwn0=; b=tFQvuKlKcml+gqtJkIjlL0hzctfmO08RArfzqg3EA+RZuXfoEZcIyVWgjmf+oIkn0E GyWQDGHxszwKqrmhOGr9FNdV91gaBRJBxeHcaGbyt5kOWN8X7XvNcA1G5wS12dypbis8 ZgVIVb4noBW8F+zR1VpeuRPkC+3frQYoWu9F11BCEM5N8r1hFNrYIsAGqAdLmDQhEcZp hzO5VALwS/4hGEL1pZ1XcFy6aIVDm6XJayTgc3I+0uET5TdL2cQuQKSu3rj1O8ahKmme +oD6GKUiOXt+ltk1iXbdtZ8V7RTnS68psBW3GlmP95u13DyM1p24CDm4dEhxP6uZP524 BqSg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u267FZF9PwpcNKLVrK09lg==" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.34.5 AUTH) with ESMTPSA id j05669xAJKu109F (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 19 Nov 2021 21:56:01 +0100 (CET) Date: Fri, 19 Nov 2021 21:55:56 +0100 From: Stephan Gerhold To: Tom Rini Cc: Linus Walleij , u-boot@lists.denx.de Subject: Re: [PATCH] board: stemmy: Increase boot image to 16 MB Message-ID: References: <20211119143321.2497377-1-linus.walleij@linaro.org> <20211119181243.GI24579@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211119181243.GI24579@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Nov 19, 2021 at 01:12:43PM -0500, Tom Rini wrote: > On Fri, Nov 19, 2021 at 03:33:21PM +0100, Linus Walleij wrote: > > > When using a recent kernel with a bunch of compiled-in > > stuff the kernel image easily becomes bigger than 8 MB > > yielding this error: > > > > Loading Kernel Image > > Image too large: increase CONFIG_SYS_BOOTM_LEN > > Must RESET board to recover > > > > Fix this by bumping to SZ_16MB. > > > > Cc: Stephan Gerhold > > Signed-off-by: Linus Walleij > > --- > > include/configs/stemmy.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/configs/stemmy.h b/include/configs/stemmy.h > > index ed79b1203901..f4700a45daf5 100644 > > --- a/include/configs/stemmy.h > > +++ b/include/configs/stemmy.h > > @@ -14,6 +14,7 @@ > > * bootloader. New images are loaded at the same address for compatibility. > > */ > > #define CONFIG_SYS_INIT_SP_ADDR CONFIG_SYS_TEXT_BASE > > +#define CONFIG_SYS_BOOTM_LEN SZ_16M > > > > /* FIXME: This should be loaded from device tree... */ > > #define CONFIG_SYS_L2_PL310 > > So, the default for CONFIG_SYS_BOOTM_LEN is clearly too small and should > be addressed broadly. And, ugh, I don't see a maximum size for the > kernel itself in > https://www.kernel.org/doc/Documentation/arm64/booting.rst but SZ_64M is > the common "we hope this is always large enough" value used, so can we > push stemmy there as well? Thanks. > I think there is usually less needed on ARM32 since Linux will decompress itself, so the size here is actually for the *compressed* kernel image, not the decompressed one. But it doesn't hurt to have it larger I guess, so 64 MiB also sounds good to me. Linus, can you send a v2 with SZ_64M? Also feel free to add my Reviewed-by: Stephan Gerhold Thanks, Stephan