public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Leo Liang <ycliang@andestech.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] riscv: revert Complete efi header for RV32/64
Date: Thu, 13 Jan 2022 06:41:57 +0000	[thread overview]
Message-ID: <Yd/JtYLBysMBl8uv@ubuntu01> (raw)
In-Reply-To: <20220109173855.239417-1-heinrich.schuchardt@canonical.com>

On Sun, Jan 09, 2022 at 06:38:55PM +0100, Heinrich Schuchardt wrote:
> EDK II refuses to load the EFI binaries created by U-Boot.
> The reason is an incorrect PE-COFF header. The number of
> data directories does not match NumberOfRvaAndSizes.
> This leads to a failed consistency check in
> PeCoffLoaderGetPeHeader():
> 
>     SizeOfOptionalHeader - HeaderWithoutDataDir) !=
>     NumberOfRvaAndSizes * sizeof(DATA_DIRECTORY))
> 
> Fixes: 9afaeec6ef8b ("riscv: Complete efi header for RV32/64")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  arch/riscv/lib/crt0_riscv_efi.S | 10 ----------
>  1 file changed, 10 deletions(-)

LGTM,
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>

p.s. Out of curiosity, could "change the value (0x6) to (0x10) of the
NumberOfRvaAndSizes" also fix the problem ?

Best regards,
Leo

      reply	other threads:[~2022-01-13  6:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-09 17:38 [PATCH 1/1] riscv: revert Complete efi header for RV32/64 Heinrich Schuchardt
2022-01-13  6:41 ` Leo Liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd/JtYLBysMBl8uv@ubuntu01 \
    --to=ycliang@andestech.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox