From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10B01C433EF for ; Thu, 13 Jan 2022 06:45:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 552928338F; Thu, 13 Jan 2022 07:45:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id BC7218340A; Thu, 13 Jan 2022 07:45:12 +0100 (CET) Received: from ATCSQR.andestech.com (atcsqr.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0675E83384 for ; Thu, 13 Jan 2022 07:45:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 20D6iYdd058647; Thu, 13 Jan 2022 14:44:35 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Thu, 13 Jan 2022 14:44:32 +0800 Date: Thu, 13 Jan 2022 06:44:30 +0000 From: Leo Liang To: Andre Przywara CC: , Subject: Re: [PATCH 4/6] arm: Clean up asm/io.h Message-ID: References: <20220109173009.25522-1-andre.przywara@arm.com> <20220109173009.25522-5-andre.przywara@arm.com> <20220109213903.35417cb4@slackpad.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220109213903.35417cb4@slackpad.fritz.box> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: ATCSQR.andestech.com 20D6iYdd058647 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Jan 09, 2022 at 09:39:03PM +0000, Andre Przywara wrote: > On Sun, 9 Jan 2022 17:30:07 +0000 > Andre Przywara wrote: > > Hi Rick, Leo: > > > asm/io.h is the header file containing the central MMIO accessor macros. > > Judging by the header and the comments, it was apparently once copied > > from the Linux kernel, but has deviated since then *heavily*. There is > > absolutely no point in staying close to the original Linux code anymore, > > so just remove the old cruft, by: > > - removing pointless Linux history > > - removing commented code > > - removing outdated comments > > - removing unused definitions (for mem_isa) > > > > This massively improves the readability of the file. > > it looks like arch/risc-v/include/asm/io.h is a copy of the ARM > version, and includes the same pointless legacy. You might want to > remove those parts there as well. > > Cheers, > Andre > > > Signed-off-by: Andre Przywara > > --- > > arch/arm/include/asm/io.h | 98 +-------------------------------------- > > 1 file changed, 2 insertions(+), 96 deletions(-) Hi Andre, Thanks for the reminder! Will do ASAP! Best regards, Leo