From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1BF8C433EF for ; Wed, 12 Jan 2022 11:12:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4196E83105; Wed, 12 Jan 2022 12:12:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=metanate.com header.i=@metanate.com header.b="p+8XyuY8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 37D088313E; Wed, 12 Jan 2022 12:12:00 +0100 (CET) Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C485C83103 for ; Wed, 12 Jan 2022 12:11:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=john@metanate.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Type:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=wIfUYkr38UbuxxLP20vdIx3l3wZ4kj85hhzNLXGHZBc=; b=p+8Xy uY8pJ7CHawlVti9YkIk9WS2E3LrHdcanaY7cWJRIc4Vb/HL6ZsEzJYs2525ISF+mxWg8jmJnCIH46 1D9vZFCv26YX78ZIrIPyQCEoHOiNdDuIfVQf1UaiBtSu4BZLg3WZm3RJQHiPL7ys5f7jg5fu+OOFZ VuyTKdyqbj30QNUHvoNp894Fe3DVTjZxWDVR2nIHMtp9mjoAsUTsbsMbU4cJnQf/V3mx8hQJ3sZuG SNR7GKMM0myl9SaVuVElcAtEGgIhH7iTtTFkT4awtiI+uQQW9Qi6u/4r58vBPCSY4e23bu8+S4hHm fy76CqwMpRlNogdsJRsT1bzG6d5yA==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1n7bXk-0007A2-TX; Wed, 12 Jan 2022 11:11:52 +0000 Date: Wed, 12 Jan 2022 11:11:51 +0000 From: John Keeping To: Jaehoon Chung Cc: u-boot@lists.denx.de, Peng Fan Subject: Re: [PATCH] mmc: dwmmc: return a proper error code when busy Message-ID: References: <20220111161525.2499825-1-john@metanate.com> <7ae1c9e1-137c-d1e6-4b1c-c6441597ca74@samsung.com> <65f26a03-4ca8-e75d-c737-79dd08ead939@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65f26a03-4ca8-e75d-c737-79dd08ead939@samsung.com> X-Authenticated: YES X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Jan 12, 2022 at 08:38:01AM +0900, Jaehoon Chung wrote: > On 1/12/22 7:12 AM, Jaehoon Chung wrote: > > On 1/12/22 1:15 AM, John Keeping wrote: > >> When failing to send a command because the hardware is busy, return > >> EBUSY to indicate the cause instead of just -1. > > Is this patch same? > > https://patchwork.ozlabs.org/project/uboot/patch/20211207160935.404395-1-john@metanate.com/ Yes, sorry - I still had the patch file lying around and passed the wrong filename to git send-email! > >> > >> Signed-off-by: John Keeping > > > > Reviewed-by: Jaehoon Chung > > > Best Regards, > > Jaehoon Chung > > > >> --- > >> drivers/mmc/dw_mmc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c > >> index a949dad574..4232c5eb8c 100644 > >> --- a/drivers/mmc/dw_mmc.c > >> +++ b/drivers/mmc/dw_mmc.c > >> @@ -301,7 +301,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, > >> flags = dwmci_set_transfer_mode(host, data); > >> > >> if ((cmd->resp_type & MMC_RSP_136) && (cmd->resp_type & MMC_RSP_BUSY)) > >> - return -1; > >> + return -EBUSY; > >> > >> if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION) > >> flags |= DWMCI_CMD_ABORT_STOP; > >> > > > > >