From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F9FCC433F5 for ; Mon, 17 Jan 2022 09:59:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 64A2880FF2; Mon, 17 Jan 2022 10:59:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="QSIYBcQC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0CA3A8197F; Mon, 17 Jan 2022 10:59:09 +0100 (CET) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D747380FE4 for ; Mon, 17 Jan 2022 10:59:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x32f.google.com with SMTP id c126-20020a1c9a84000000b00346f9ebee43so21353135wme.4 for ; Mon, 17 Jan 2022 01:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0RwfH+bxXuvAzYlWxhIPxgUW1l+Vf6L1Yc3BMKNc/wo=; b=QSIYBcQC1XqibZb/Q25Xq+cutlqXMnU/6SLrbv5BwVYRnFaYdwaz30ezWYXIgDovVw QEPLSi5OE1Sg8nfIp3LTJm85C+DMX1q9S+9iP8PEAI4gaY5BizW60DVsgi1KtSbr7uuH dIAk8FEZXV2zooonf6UWfFvQZNJ/2EwpHM7W9HNbLPjrFkKFrkWux0DkaMaTAWWAZHrq 9gT020oIeDmhBXIbK6wIjM7k/WK9mYqNpufyE5ZS3ZoxtiAeNjOwqn8dQIM8e6/z5jrk gjHUTfbG9GxDMbROTVFde/RPq/Exb9w/LHk6doyRVBKvwB/rTMHL86Gdl0/8KUYI2ig1 atWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0RwfH+bxXuvAzYlWxhIPxgUW1l+Vf6L1Yc3BMKNc/wo=; b=F754Tr+y176AHuGIbgwaRTb1b+oB+FmRmqhHNo5GBb14RfTAM5AISKBxcuojZ8WmNc 19T+yBH3LFCsTeXMPfkuxJvIBASD7CF43jeVoWKttIf3s9G/ODk0wmjBES9H+zzWQPjJ mZwg5x+YfLeVEfmdtvf8Rlrk5ZlezUOA100xAvLx4ufhGLGI8b5OdaDR4YAMsvNN/wTP b2HW0zV7l4s8nggE06Zz/3R4zENWvRQAzpAmKBlRN0CZrqnELVstMtkjH6AQQVUg6/60 ciTjJMSLSTWa5JvzH62lJCyr1LrV/M5U+W+xCkfvH6b8xg6qA4gY5bDmlQDbGC/gHG6M G5hg== X-Gm-Message-State: AOAM532KVDoPWUd0shL0NuVuoNRVliA/7R3UgbIG1Gsja+ZVTQSD5zSN hLeMb1x2QKewOcj8PnncsQC7/Q== X-Google-Smtp-Source: ABdhPJzxgbRKjOc+CDyTIXFQ3DbpPlHnwnQ1xoiCLQDH+MewjCLW+BrQn4aQpgKCjBZh4o74yLknyQ== X-Received: by 2002:a05:600c:582:: with SMTP id o2mr19132471wmd.159.1642413545375; Mon, 17 Jan 2022 01:59:05 -0800 (PST) Received: from hades (athedsl-4461669.home.otenet.gr. [94.71.4.85]) by smtp.gmail.com with ESMTPSA id d5sm13450573wrs.61.2022.01.17.01.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 01:59:04 -0800 (PST) Date: Mon, 17 Jan 2022 11:59:02 +0200 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: AKASHI Takahiro , u-boot@lists.denx.de, Masahisa Kojima , Alexander Graf Subject: Re: [RFC 1/1] efi_loader: rename 'efidebug boot' 'bootefi' Message-ID: References: <20220115004907.80919-1-heinrich.schuchardt@canonical.com> <20220117011651.GB7045@laputa> <6f5fcac5-4ae3-c401-0121-db7f80197ad5@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f5fcac5-4ae3-c401-0121-db7f80197ad5@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich On Mon, Jan 17, 2022 at 10:25:01AM +0100, Heinrich Schuchardt wrote: > On 1/17/22 08:58, Ilias Apalodimas wrote: > > On Mon, Jan 17, 2022 at 10:16:51AM +0900, AKASHI Takahiro wrote: > > > On Sat, Jan 15, 2022 at 01:49:07AM +0100, Heinrich Schuchardt wrote: > > > > The efidebug command was conceived for testing purposes. > > > > > > Well, I initially implemented the command as an alternative of > > > "EFI shell" as the shell was not able to run on EFI U-Boot at that time. > > > > > > > The manipulation of boot options does better fit to the bootefi command > > > > that is used to invoke the boot manager. > > > > > > I believe that it would be best to have those two features > > > in separate commands(/applications) since the bootefi/bootmgr be focused > > > on booting EFI images while efidebug/EFI shell provides a kind of > > > user interfaces for manipulating the system. > > > > > > *If* you dare to move the code to bootefi/bootmgr, I'd ask you to honor > > > and add my copyright to the file as "efidebug boot" feature is a core part > > > of efidebug. Or export sub-command functions from efidebug.c and import > > > them in bootefi.c. > > > > I think renaming the efidebug command is overall good idea, since it does > > way more that debugging. OTOH I think moving it to 'bootefi' is the wrong > > way to go. I'd be much happier if we kept bootefi for booting related > > commands and purposes and rename 'efidebug' to 'efi'. Then we could split > > off the debug related commands to 'efi debug xxxxxxxxx' and put it under a > > Kconfig option. > > For me the important thing is that we should be able enable boot options > related commands without the rest of efidebug to limit code size increase. > Yes, but isn't that doable by what I suggested? > efidebug boot is only needed if CONFIG_CMD_BOOTEFI_BOOTMGR=y. > > efidebug capsule is only needed for testing on QEMU, Sandbox if capsules are > enabled. I can't see that a normal user would ever use it. > > efidebug devices, drivers, dh, images, memmap, query, tables is only needed > for debugging and should be disabled by default. Yes, those would be the options we could place under a new Kconfig, which enables debugging capabilities on the command Cheers /Ilias > > efidebug test is only needed on the Sandbox. > > All commands lack documentation in /doc/usage/ > > Best regards > > Heinrich