public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: Grant Edwards <grant.b.edwards@gmail.com>
Cc: u-boot@lists.denx.de
Subject: Re: How to modify defconfig file - make savedefconfig?
Date: Fri, 28 Jan 2022 11:26:46 +0100	[thread overview]
Message-ID: <YfPE5thhnKx54a+J@ada.ifak-system.com> (raw)
In-Reply-To: <ssui9o$33b$1@ciao.gmane.io>

Hello Grant,

Am Thu, Jan 27, 2022 at 04:46:48PM -0000 schrieb Grant Edwards:
> What is the "right" way to modify a defconfig file?
> 
> Most sources I've found just say things like "edit the defconfig
> file". That seems error-prone -- especially when dealing with settings
> that have side effects.
> 
> I did stumble across one mention of "make savedefconfig", and this
> seems to be the right way to modify a defconfig file:
> 
>     make myboard_defconfig
>     make menuconfig
>     make savedefconfig
>     cp defconfig configs/myboard_defconfig

That's what I do.

> Do people manually edit their defconfig file when they want to make a
> change, or do they use "make savedefconfig" like I show above?

You can do both.  If you already have a defconfig, this:

1) edit your myboard_defconfig
2) make myboard_defconfig
3) make savedefconfig
4) cp defconfig configs/myboard_defconfig

You might want to `git add configs/myboard_defconfig` in between those
stages if you want to inspect what changed with those calls.

> One reason I'm asking is that the original defconfig file provided by
> the silicon vendor (Renesas) appears to be a manually stripped-down
> ..config file, because when I do
> 
>    make vendors_defconfig
>    make savedefconfig
> 
> The defconfig file generated by 'make savedefconfig' looks _nothing_
> like the starting vendors_defconfig. The new defconfig generates the
> same .config file as the vendors_defconfig file. But the
> vendors_defconfig file is arranged completely differently with
> different/extra comments, extra blank lines, etc.

I think U-Boot expects those files to be created by savedefconfig, 
see all the changesets in Git reading 
'configs: Resync with savedefconfig'.

Greets
Alex


      reply	other threads:[~2022-01-28 10:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 16:46 How to modify defconfig file - make savedefconfig? Grant Edwards
2022-01-28 10:26 ` Alexander Dahl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfPE5thhnKx54a+J@ada.ifak-system.com \
    --to=ada@thorsis.com \
    --cc=grant.b.edwards@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox