From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05899C433F5 for ; Fri, 11 Feb 2022 19:51:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4AE1283B9E; Fri, 11 Feb 2022 20:51:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A451183B7D; Fri, 11 Feb 2022 20:51:42 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5296383B95; Fri, 11 Feb 2022 20:51:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=andy.shevchenko@gmail.com X-IronPort-AV: E=McAfee;i="6200,9189,10255"; a="310536105" X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; d="scan'208";a="310536105" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 11:51:37 -0800 X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; d="scan'208";a="527078132" Received: from smile.fi.intel.com ([10.237.72.61]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 11:51:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nIbwE-003ajJ-Qq; Fri, 11 Feb 2022 21:50:38 +0200 Date: Fri, 11 Feb 2022 21:50:38 +0200 From: Andy Shevchenko To: Simon Glass Cc: Tom Rini , Bin Meng , U-Boot Mailing List , u-boot-custodians@lists.denx.de, u-boot-board-maintainers@lists.denx.de Subject: Re: [ANN] U-Boot v2022.04-rc1 released Message-ID: References: <20220131225930.GJ7515@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Fri, Feb 11, 2022 at 09:47:52PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko wrote: > > > On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: > > > > On Fri, 11 Feb 2022 at 11:28, Andy Shevchenko > > > > wrote: > > > > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrote: > > > > > > ... > > > > > > > FWIW here is my tboot flash script for Edison: > > > > > > This is rather unbriking script, DFU (luckily) works > > > > Not if it is bricked: :-) I need something that always works. > > > > > > > > > def flash_edison(self, repo): > > > > vid = 0x8086 > > > > pid = 0xe005 > > > > expect = "%04x:%04x" % (vid, pid) > > > > self.wait_for_dfu(expect) > > > > u_boot = os.path.join(repo._local_str(), "u-boot-edison.img") > > > > bindir = self.usbboot_xfstk_dir > > > > self.host.exec0( > > > > "xfstk-dldr-solo", "--gpflags", "0x80000007", > > > > "--osimage", u_boot, > > > > "--fwdnx", os.path.join(bindir, "edison_dnx_fwr.bin"), > > > > "--fwimage", os.path.join(bindir, "edison_ifwi-dbg-00.bin"), > > > > "--osdnx", os.path.join(bindir, "edison_dnx_osr.bin")) > > > > > > To the topic, any suggestions on how to fix the current U-Boot regression? > > > > The easiest thing is to use 'acpi list' and 'acpi dump facp' etc. to > > see what is different between the two commits. My testing was on coral > > and minnowmax and I must have missed it. We don't actually have any > > test coverage on the board-specific code. > > => acpi dump facp > Table 'FACP' not found > > This explains I believe everything. Side question(s): - Why out of a sudden different name here: ACPI_WRITER(5fadt, "FACS", apl_write_fadt, 0); FACS vs FACP - Why do you need double assignment of the same revision in acpi_fadt_common() header->revision = 4; ... /* Use ACPI 3.0 revision */ fadt->header.revision = 4; -- With Best Regards, Andy Shevchenko